From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B590FCD11C2 for ; Sun, 7 Apr 2024 08:03:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23E456B0095; Sun, 7 Apr 2024 04:03:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EDD26B0096; Sun, 7 Apr 2024 04:03:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B7186B0098; Sun, 7 Apr 2024 04:03:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DF82B6B0095 for ; Sun, 7 Apr 2024 04:03:14 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 666D5160887 for ; Sun, 7 Apr 2024 08:03:14 +0000 (UTC) X-FDA: 81981995508.30.77F0EEE Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf10.hostedemail.com (Postfix) with ESMTP id 73C19C000D for ; Sun, 7 Apr 2024 08:03:12 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CF3DDT0+; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712476992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tDol3Thk1zGuXnMJZM7JUv81lJKthEk370IWT+a5GiA=; b=yO+w4LiT8sPO5uy6YbDDoPG9ezceeCAEHYdmPDoZomJOj6e+NS6UCoXUDwbou3nHaGOmbF ceG6TBRBhwxTC6csCuJhacbNUcoe8yYsYGg4OvPlqYkm/aFn5/m6em+cq/YBLrvTkwfL7e JKsqCyXNB5Rkstenl3KDtcxlrSXD2zY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CF3DDT0+; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712476992; a=rsa-sha256; cv=none; b=QlPrRDHHnJ3kv/fJkPyL0g3nZaoUNWVzSGzHglFAq3Bj3Cy2SsMZAL9lFZEG4feHCAeE5k oC+t0H5drnNiFuM5SOp7CR1Lq9lLBFws+cRroKjjf6i0wPS3zMAW/FfCJl1GtOqQzeRLum YbI/u0nQGjzQDVuTE81wyr0p/OBcAaw= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712476990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tDol3Thk1zGuXnMJZM7JUv81lJKthEk370IWT+a5GiA=; b=CF3DDT0+NCXjui8lYn41GwetR5UjLID4XSWDzMloC8+rMpUZJAXTbXwgZ1V7Od+eXBCyBw CHC6cUUDnod1a53rMx9Oos0rmTBG73MVQg9Gzp51/dVh/sup81/srVTq0u3+8cp6E4Pa3+ 7//QRlZbmuPkEFfjnH9gn9fVGVFQhPc= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: [PATCH 2/2] mm/hugetlb: pass correct order_per_bit to cma_declare_contiguous_nid X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240404162515.527802-2-fvdl@google.com> Date: Sun, 7 Apr 2024 16:02:35 +0800 Cc: Linux-MM , Andrew Morton , linux-kernel@vger.kernel.org, Roman Gushchin Content-Transfer-Encoding: quoted-printable Message-Id: <5037C21B-92A9-4125-B644-02CC6EBD7B08@linux.dev> References: <20240404162515.527802-1-fvdl@google.com> <20240404162515.527802-2-fvdl@google.com> To: Frank van der Linden X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 73C19C000D X-Stat-Signature: foemekiqoxz6ey7md5114kohy3e6k6ga X-HE-Tag: 1712476992-308823 X-HE-Meta: U2FsdGVkX1+i+z1BbJlmhobXU4jWLhi9fpbbEoxF2e8WAZtmrnHAmh8V0usrhLmfbSj9UPFrofD0MBjgj7ubyVjBsHbt/QGkDEQ2VlD9LYrHCM2tcygEK/srrC+hSnKblbwuPER7c/kZ8cmaZPC4Zr9xN4LHURhi5lL6nLadN3tnOrcrG8ytIuSJWX2YUuWS3s2MlTmDeXkXS7yru7grM/Y5sJXpQ77ctjKT11AGrYndu3GuQNBJPBiIgSymOGSTbZhr1+VHMKRyC3ZFLNBWogb52EY4lev9cXmiESNW74pKDhCU4wL0OAMYFzKX4iM/ZRa3paw8Fc8IVy9Hsnzm8dX2BQfeCJ2vvwhcCsCxJoZeG+HtiZmD6L1JrhhwMURs40J9EMxXfU5z5PQ44yqmB/V6I84rUQvbcdhY6r+6Fsu3++XfpDIz3mlVE6OBaD2UGCmDv4AOMolponV9w1jxF6RNa9T6G6xdmZcRPtcTVn0mQChiS7jG5ABU7pmP25OJHD9qx808uwl/wTZtI1fzk3QsPlcqJI9/XiN2aiapzNWjDgMlMP0IahNvsBcNWGVREMk14TRCmOwYvDgCXUjWE685kI5Nvv73E1gU8T/OmbQHEELqKJU4o0lJy7F73+d5sbXuqmGfBYOXlHGmk/DJoKLsXglXNT1y8d0kEcs3Gf9uYH9CtLx229G4+TpCHGbFSmta73aeOQ9/UO8oKyuClqr/3+0wPy45k9dsNlq4q+gcn6eJ/g8lWGMy8Tdf57GfpZUsmkIOwwD6XIHun6d434cGvN8le4mABUEglzi1McNdQVKAo/erVZwW5xtekDqALcCbuiRilQxj3UBd7r51JcE/zAku9ZJmS5TT2avi5qtmbF/PcP+6M/dFoKqA2ZF3XPHc6Knw8FPh1qjpFTpnNF1h3oh0QPBuf4JTm0rJD3d/qBX2njej1gq2XezuLLPCxHRWB+1chGdHgdwTkSc +edVuqpQ 2NIklF6DBybM5bi3DEhII3bVNzS4zTLMMsuH/v1djhSamV245Ck4XwZRgGy9BX0V2CemuDpJnoI4RKRWCeiCi+aMObuUIPCSOXHDGl/VPUOwLVnkbeJOjPOcLYzonyfRs0R1IOgcpyCbced971sPmt3IFCy5v/LMZOOoYsWCrx9wufYXAxfrvUmxALA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Apr 5, 2024, at 00:25, Frank van der Linden = wrote: >=20 > The hugetlb_cma code passes 0 in the order_per_bit argument to > cma_declare_contiguous_nid (the alignment, computed using the > page order, is correctly passed in). >=20 > This causes a bit in the cma allocation bitmap to always represent > a 4k page, making the bitmaps potentially very large, and slower. >=20 > So, correctly pass in the order instead. >=20 > Signed-off-by: Frank van der Linden > Cc: Roman Gushchin > Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic = hugepages using cma") > --- > mm/hugetlb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 23ef240ba48a..6dc62d8b2a3a 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -7873,9 +7873,9 @@ void __init hugetlb_cma_reserve(int order) > * huge page demotion. > */ > res =3D cma_declare_contiguous_nid(0, size, 0, > - PAGE_SIZE << = HUGETLB_PAGE_ORDER, > - 0, false, name, > - &hugetlb_cma[nid], nid); > + PAGE_SIZE << = HUGETLB_PAGE_ORDER, > + HUGETLB_PAGE_ORDER, = false, name, IIUC, we could make the optimization further to change order_per_bit to 'MAX_PAGE_ORDER + 1' since only gigantic hugetlb pages could allocated = from the CMA pool meaning any gigantic page is greater than or equal to the size of two to the power of 'MAX_PAGE_ORDER + 1'. Thanks. > + &hugetlb_cma[nid], nid); > if (res) { > pr_warn("hugetlb_cma: reservation failed: err = %d, node %d", > res, nid); > --=20 > 2.44.0.478.gd926399ef9-goog >=20