From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx138.postini.com [74.125.245.138]) by kanga.kvack.org (Postfix) with SMTP id 417016B0069 for ; Wed, 15 Aug 2012 09:04:43 -0400 (EDT) Message-ID: <502B9E5F.2080907@parallels.com> Date: Wed, 15 Aug 2012 17:04:31 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v2 04/11] kmem accounting basic infrastructure References: <1344517279-30646-1-git-send-email-glommer@parallels.com> <1344517279-30646-5-git-send-email-glommer@parallels.com> <20120814162144.GC6905@dhcp22.suse.cz> <502B6D03.1080804@parallels.com> <20120815123931.GF23985@dhcp22.suse.cz> <502B9BD4.4070003@parallels.com> <20120815130228.GH23985@dhcp22.suse.cz> In-Reply-To: <20120815130228.GH23985@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, devel@openvz.org, Johannes Weiner , Andrew Morton , kamezawa.hiroyu@jp.fujitsu.com, Christoph Lameter , David Rientjes , Pekka Enberg On 08/15/2012 05:02 PM, Michal Hocko wrote: > On Wed 15-08-12 16:53:40, Glauber Costa wrote: > [...] >>>>> This doesn't check for the hierachy so kmem_accounted might not be in >>>>> sync with it's parents. mem_cgroup_create (below) needs to copy >>>>> kmem_accounted down from the parent and the above needs to check if this >>>>> is a similar dance like mem_cgroup_oom_control_write. >>>>> >>>> >>>> I don't see why we have to. >>>> >>>> I believe in a A/B/C hierarchy, C should be perfectly able to set a >>>> different limit than its parents. Note that this is not a boolean. >>> >>> Ohh, I wasn't clear enough. I am not against setting the _limit_ I just >>> meant that the kmem_accounted should be consistent within the hierarchy. >>> >> >> If a parent of yours is accounted, you get accounted as well. This is >> not the state in this patch, but gets added later. Isn't this enough ? > > But if the parent is not accounted, you can set the children to be > accounted, right? Or maybe this is changed later in the series? I didn't > get to the end yet. > Yes, you can. Do you see any problem with that? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org