From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx168.postini.com [74.125.245.168]) by kanga.kvack.org (Postfix) with SMTP id 1ADC76B0081 for ; Thu, 9 Aug 2012 11:28:59 -0400 (EDT) Message-Id: <5023F3580200007800093F2C@nat28.tlf.novell.com> Date: Thu, 09 Aug 2012 16:28:56 +0100 From: "Jan Beulich" Subject: Re: [PATCH v2 6/6] x86: switch the 64bit uncached page clear to SSE/AVX v2 References: <1344524583-1096-1-git-send-email-kirill.shutemov@linux.intel.com> <1344524583-1096-7-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1344524583-1096-7-git-send-email-kirill.shutemov@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: Andi Kleen , "Kirill A. Shutemov" Cc: Andy Lutomirski , Robert Richter , Johannes Weiner , Hugh Dickins , Alex Shi , KAMEZAWA Hiroyuki , x86@kernel.org, linux-mm@kvack.org, Thomas Gleixner , Andrew Morton , linux-mips@linux-mips.org, Tim Chen , linuxppc-dev@lists.ozlabs.org, Andrea Arcangeli , Ingo Molnar , Mel Gorman , linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, "H. Peter Anvin" >>> On 09.08.12 at 17:03, "Kirill A. Shutemov" wrote: > ENTRY(clear_page_nocache) > CFI_STARTPROC > - xorl %eax,%eax > - movl $4096/64,%ecx > + push %rdi > + call kernel_fpu_begin > + pop %rdi You use CFI annotations elsewhere, so why don't you use pushq_cfi/popq_cfi here? Jan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org