From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Joonsoo Kim <js1304@gmail.com>
Subject: Re: Common10 [13/20] Move kmem_cache allocations into common code.
Date: Wed, 8 Aug 2012 17:51:12 +0400 [thread overview]
Message-ID: <50226ED0.9080404@parallels.com> (raw)
In-Reply-To: <20120803192155.337884418@linux.com>
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
On 08/03/2012 11:21 PM, Christoph Lameter wrote:
> Shift the allocations to common code. That way the allocation
> and freeing of the kmem_cache structures is handled by common code.
>
> V1-V2: Use the return code from setup_cpucache() in slab instead of returning -ENOSPC
This patch doesn't even boot! (slub)
[-- Attachment #2: kmalloc-bug --]
[-- Type: text/plain, Size: 1917 bytes --]
[ 0.000000] Memory: 989060k/1048568k available (5273k kernel code, 452k absent, 59056k reserved, 5916k data, 932k init)
[ 0.000000] Kernel panic - not syncing: Creation of kmalloc slab kmalloc-96 size=96 failed.
[ 0.000000]
[ 0.000000] Pid: 0, comm: swapper Not tainted 3.5.0-rc1+ #3
[ 0.000000] Call Trace:
[ 0.000000] [<ffffffff815116c2>] panic+0xbd/0x1cd
[ 0.000000] [<ffffffff81b2673f>] create_kmalloc_cache+0x54/0x70
[ 0.000000] [<ffffffff81b26897>] kmem_cache_init+0x13c/0x2c2
[ 0.000000] [<ffffffff81b049d0>] start_kernel+0x1ee/0x3d3
[ 0.000000] [<ffffffff81b045ea>] ? repair_env_string+0x5a/0x5a
[ 0.000000] [<ffffffff81b042d6>] x86_64_start_reservations+0xb1/0xb5
[ 0.000000] [<ffffffff81b043d8>] x86_64_start_kernel+0xfe/0x10b
[ 0.000000] ------------[ cut here ]------------
[ 0.000000] WARNING: at kernel/lockdep.c:2585 trace_hardirqs_on_caller+0xdf/0x173()
[ 0.000000] Hardware name: Bochs
[ 0.000000] Modules linked in:
[ 0.000000] Pid: 0, comm: swapper Not tainted 3.5.0-rc1+ #3
[ 0.000000] Call Trace:
[ 0.000000] [<ffffffff81047f89>] warn_slowpath_common+0x83/0x9c
[ 0.000000] [<ffffffff8151178b>] ? panic+0x186/0x1cd
[ 0.000000] [<ffffffff81047fbc>] warn_slowpath_null+0x1a/0x1c
[ 0.000000] [<ffffffff81093e53>] trace_hardirqs_on_caller+0xdf/0x173
[ 0.000000] [<ffffffff81093ef4>] trace_hardirqs_on+0xd/0xf
[ 0.000000] [<ffffffff8151178b>] panic+0x186/0x1cd
[ 0.000000] [<ffffffff81b2673f>] create_kmalloc_cache+0x54/0x70
[ 0.000000] [<ffffffff81b26897>] kmem_cache_init+0x13c/0x2c2
[ 0.000000] [<ffffffff81b049d0>] start_kernel+0x1ee/0x3d3
[ 0.000000] [<ffffffff81b045ea>] ? repair_env_string+0x5a/0x5a
[ 0.000000] [<ffffffff81b042d6>] x86_64_start_reservations+0xb1/0xb5
[ 0.000000] [<ffffffff81b043d8>] x86_64_start_kernel+0xfe/0x10b
[ 0.000000] ---[ end trace a7919e7f17c0a725 ]---
next prev parent reply other threads:[~2012-08-08 13:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 19:20 Common10 [00/20] Sl[auo]b: Common code rework V10 Christoph Lameter
2012-08-03 19:20 ` Common10 [01/20] slub: Add debugging to verify correct cache use on kmem_cache_free() Christoph Lameter
2012-08-03 19:20 ` Common10 [02/20] slub: Use kmem_cache for the kmem_cache structure Christoph Lameter
2012-08-03 19:20 ` Common10 [03/20] Rename oops label Christoph Lameter
2012-08-03 19:20 ` Common10 [04/20] Improve error handling in kmem_cache_create Christoph Lameter
2012-08-03 19:20 ` Common10 [05/20] Move list_add() to slab_common.c Christoph Lameter
2012-08-04 17:01 ` JoonSoo Kim
2012-08-08 14:47 ` Christoph Lameter (Open Source)
2012-08-03 19:20 ` Common10 [06/20] Extract a common function for kmem_cache_destroy Christoph Lameter
2012-08-04 17:21 ` JoonSoo Kim
2012-08-08 14:51 ` Christoph Lameter (Open Source)
2012-08-03 19:20 ` Common10 [07/20] Always use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-08-03 19:21 ` Common10 [08/20] Move freeing of kmem_cache structure to common code Christoph Lameter
2012-08-03 19:21 ` Common10 [09/20] Get rid of __kmem_cache_destroy Christoph Lameter
2012-08-03 19:21 ` Common10 [10/20] Move duping of slab name to slab_common.c Christoph Lameter
2012-08-04 17:34 ` JoonSoo Kim
2012-08-08 14:59 ` Christoph Lameter (Open Source)
2012-08-14 18:42 ` JoonSoo Kim
2012-08-03 19:21 ` Common10 [11/20] Do slab aliasing call from common code Christoph Lameter
2012-08-04 17:44 ` JoonSoo Kim
2012-08-08 15:40 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [12/20] Move sysfs_slab_add to common Christoph Lameter
2012-08-04 17:46 ` JoonSoo Kim
2012-08-08 15:51 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [13/20] Move kmem_cache allocations into common code Christoph Lameter
2012-08-04 17:48 ` JoonSoo Kim
2012-08-08 17:31 ` Christoph Lameter (Open Source)
2012-08-08 13:51 ` Glauber Costa [this message]
2012-08-08 17:56 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [14/20] Shrink __kmem_cache_create() parameter lists Christoph Lameter
2012-08-08 13:15 ` Glauber Costa
2012-08-08 17:45 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [15/20] Move kmem_cache refcounting to common code Christoph Lameter
2012-08-03 19:21 ` Common10 [16/20] slub: Use a statically allocated kmem_cache boot structure for bootstrap Christoph Lameter
2012-08-04 17:50 ` JoonSoo Kim
2012-08-03 19:21 ` Common10 [17/20] slab: Simplify bootstrap Christoph Lameter
2012-08-03 19:21 ` Common10 [18/20] create common functions for boot slab creation Christoph Lameter
2012-08-03 19:21 ` Common10 [19/20] slab: Use the new create_boot_cache function to simplify bootstrap Christoph Lameter
2012-08-03 19:21 ` Common10 [20/20] Common alignment code Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50226ED0.9080404@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox