From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Joonsoo Kim <js1304@gmail.com>
Subject: Re: Common10 [14/20] Shrink __kmem_cache_create() parameter lists
Date: Wed, 8 Aug 2012 17:15:05 +0400 [thread overview]
Message-ID: <50226659.8080608@parallels.com> (raw)
In-Reply-To: <20120803192156.005879886@linux.com>
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
On 08/03/2012 11:21 PM, Christoph Lameter wrote:
> Do the initial settings of the fields in common code. This will allow
> us to push more processing into common code later and improve readability.
>
> Signed-off-by: Christoph Lameter <cl@linux.com>
Doesn't compile.
Log attached
[-- Attachment #2: log --]
[-- Type: text/plain, Size: 1408 bytes --]
make[1]: Nothing to be done for `all'.
make[1]: Nothing to be done for `relocs'.
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CC mm/slub.o
mm/slub.c: In function a??create_kmalloc_cachea??:
mm/slub.c:3231:9: warning: passing argument 2 of a??kmem_cache_opena?? makes integer from pointer without a cast [enabled by default]
mm/slub.c:3001:12: note: expected a??long unsigned inta?? but argument is of type a??const char *a??
mm/slub.c:3231:9: error: too many arguments to function a??kmem_cache_opena??
mm/slub.c:3001:12: note: declared here
mm/slub.c: In function a??kmem_cache_inita??:
mm/slub.c:3686:3: warning: passing argument 2 of a??kmem_cache_opena?? makes integer from pointer without a cast [enabled by default]
mm/slub.c:3001:12: note: expected a??long unsigned inta?? but argument is of type a??char *a??
mm/slub.c:3686:3: error: too many arguments to function a??kmem_cache_opena??
mm/slub.c:3001:12: note: declared here
mm/slub.c:3695:3: warning: passing argument 2 of a??kmem_cache_opena?? makes integer from pointer without a cast [enabled by default]
mm/slub.c:3001:12: note: expected a??long unsigned inta?? but argument is of type a??char *a??
mm/slub.c:3695:3: error: too many arguments to function a??kmem_cache_opena??
mm/slub.c:3001:12: note: declared here
make[1]: *** [mm/slub.o] Error 1
make: *** [mm] Error 2
next prev parent reply other threads:[~2012-08-08 13:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 19:20 Common10 [00/20] Sl[auo]b: Common code rework V10 Christoph Lameter
2012-08-03 19:20 ` Common10 [01/20] slub: Add debugging to verify correct cache use on kmem_cache_free() Christoph Lameter
2012-08-03 19:20 ` Common10 [02/20] slub: Use kmem_cache for the kmem_cache structure Christoph Lameter
2012-08-03 19:20 ` Common10 [03/20] Rename oops label Christoph Lameter
2012-08-03 19:20 ` Common10 [04/20] Improve error handling in kmem_cache_create Christoph Lameter
2012-08-03 19:20 ` Common10 [05/20] Move list_add() to slab_common.c Christoph Lameter
2012-08-04 17:01 ` JoonSoo Kim
2012-08-08 14:47 ` Christoph Lameter (Open Source)
2012-08-03 19:20 ` Common10 [06/20] Extract a common function for kmem_cache_destroy Christoph Lameter
2012-08-04 17:21 ` JoonSoo Kim
2012-08-08 14:51 ` Christoph Lameter (Open Source)
2012-08-03 19:20 ` Common10 [07/20] Always use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-08-03 19:21 ` Common10 [08/20] Move freeing of kmem_cache structure to common code Christoph Lameter
2012-08-03 19:21 ` Common10 [09/20] Get rid of __kmem_cache_destroy Christoph Lameter
2012-08-03 19:21 ` Common10 [10/20] Move duping of slab name to slab_common.c Christoph Lameter
2012-08-04 17:34 ` JoonSoo Kim
2012-08-08 14:59 ` Christoph Lameter (Open Source)
2012-08-14 18:42 ` JoonSoo Kim
2012-08-03 19:21 ` Common10 [11/20] Do slab aliasing call from common code Christoph Lameter
2012-08-04 17:44 ` JoonSoo Kim
2012-08-08 15:40 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [12/20] Move sysfs_slab_add to common Christoph Lameter
2012-08-04 17:46 ` JoonSoo Kim
2012-08-08 15:51 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [13/20] Move kmem_cache allocations into common code Christoph Lameter
2012-08-04 17:48 ` JoonSoo Kim
2012-08-08 17:31 ` Christoph Lameter (Open Source)
2012-08-08 13:51 ` Glauber Costa
2012-08-08 17:56 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [14/20] Shrink __kmem_cache_create() parameter lists Christoph Lameter
2012-08-08 13:15 ` Glauber Costa [this message]
2012-08-08 17:45 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [15/20] Move kmem_cache refcounting to common code Christoph Lameter
2012-08-03 19:21 ` Common10 [16/20] slub: Use a statically allocated kmem_cache boot structure for bootstrap Christoph Lameter
2012-08-04 17:50 ` JoonSoo Kim
2012-08-03 19:21 ` Common10 [17/20] slab: Simplify bootstrap Christoph Lameter
2012-08-03 19:21 ` Common10 [18/20] create common functions for boot slab creation Christoph Lameter
2012-08-03 19:21 ` Common10 [19/20] slab: Use the new create_boot_cache function to simplify bootstrap Christoph Lameter
2012-08-03 19:21 ` Common10 [20/20] Common alignment code Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50226659.8080608@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox