From: Tomasz Stanislawski <t.stanislaws@samsung.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Rob Clark <rob.clark@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org,
linux-media@vger.kernel.org, patches@linaro.org,
linux@arm.linux.org.uk, arnd@arndb.de, jesse.barker@linaro.org,
m.szyprowski@samsung.com, daniel@ffwll.ch, sumit.semwal@ti.com,
maarten.lankhorst@canonical.com, Rob Clark <rob@ti.com>
Subject: Re: [PATCH 2/2] dma-buf: add helpers for attacher dma-parms
Date: Mon, 06 Aug 2012 14:42:28 +0200 [thread overview]
Message-ID: <501FBBB4.6000109@samsung.com> (raw)
In-Reply-To: <xa1tobmoxmdz.fsf@mina86.com>
On 08/06/2012 01:58 PM, Michal Nazarewicz wrote:
>
> Tomasz Stanislawski <t.stanislaws@samsung.com> writes:
>> I recommend to change the semantics for unlimited number of segments
>> from 'value 0' to:
>>
>> #define DMA_SEGMENTS_COUNT_UNLIMITED ((unsigned long)INT_MAX)
Sorry. It should be:
#define DMA_SEGMENTS_COUNT_UNLIMITED ((unsigned int)INT_MAX)
>>
>> Using INT_MAX will allow using safe conversions between signed and
>> unsigned integers.
>
> LONG_MAX seems cleaner regardless.
>
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-08-06 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 16:23 [PATCH 0/2] dma-parms and helpers for dma-buf Rob Clark
2012-07-19 16:23 ` [PATCH 1/2] device: add dma_params->max_segment_count Rob Clark
2012-07-20 6:20 ` Marek Szyprowski
2012-07-19 16:23 ` [PATCH 2/2] dma-buf: add helpers for attacher dma-parms Rob Clark
2012-07-20 16:39 ` Rob Clark
2012-08-06 6:37 ` Semwal, Sumit
2012-08-06 10:29 ` Tomasz Stanislawski
2012-08-06 11:58 ` Michal Nazarewicz
2012-08-06 12:42 ` Tomasz Stanislawski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501FBBB4.6000109@samsung.com \
--to=t.stanislaws@samsung.com \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesse.barker@linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@canonical.com \
--cc=mina86@mina86.com \
--cc=patches@linaro.org \
--cc=rob.clark@linaro.org \
--cc=rob@ti.com \
--cc=sumit.semwal@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox