From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Joonsoo Kim <js1304@gmail.com>
Subject: Re: Common [00/16] Sl[auo]b: Common code rework V8
Date: Thu, 2 Aug 2012 13:18:54 +0400 [thread overview]
Message-ID: <501A45FE.4040008@parallels.com> (raw)
In-Reply-To: <501A3F1E.4060307@parallels.com>
On 08/02/2012 12:49 PM, Glauber Costa wrote:
> On 08/02/2012 01:11 AM, Christoph Lameter wrote:
>>
>> V7->V8:
>> - Do not use kfree for kmem_cache in slub.
>> - Add more patches up to a common
>> scheme for object alignment.
>>
>> V6->V7:
>> - Omit pieces that were merged for 3.6
>> - Fix issues pointed out by Glauber.
>> - Include the patches up to the point at which
>> the slab name handling is unified
>>
>
> After applying v8, and proceeding with cache deletion + later insertion
> as I've previously laid down, I can still see the bug I mentioned here.
>
> Again, I am doing nothing more than:
> 1) Creating a cache
> 2) Deleting that cache
> 3) Creating that cache again.
>
> I am doing this in a synthetic function "mybug" called from memcg
> creation for convenience only (so don't get distracted by this in the
> backtrack). The machine boots okay, and seems to work for everything
> other than those late destructions. So maybe this is a problem that
> happens only after SLAB_FULL?
>
> I am attaching the backtrace I've got with SLUB_DEBUG_ON. My first guess
> based on it would be a double free somewhere.
>
Also worth mentioning, of course, that this test snippet works with the
SLAB without any problems.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-02 9:21 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 21:11 Christoph Lameter
2012-08-01 21:11 ` Common [01/16] slub: Add debugging to verify correct cache use on kmem_cache_free() Christoph Lameter
2012-08-01 21:11 ` Common [02/16] slub: Use kmem_cache for the kmem_cache structure Christoph Lameter
2012-08-01 21:11 ` Common [03/16] Move list_add() to slab_common.c Christoph Lameter
2012-08-01 21:11 ` Common [04/16] Extract a common function for kmem_cache_destroy Christoph Lameter
2012-08-01 21:11 ` Common [05/16] Always use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-08-01 21:11 ` Common [06/16] Move freeing of kmem_cache structure to common code Christoph Lameter
2012-08-01 21:11 ` Common [07/16] Get rid of __kmem_cache_destroy Christoph Lameter
2012-08-01 21:11 ` Common [08/16] Move duping of slab name to slab_common.c Christoph Lameter
2012-08-02 15:41 ` Christoph Lameter
2012-08-01 21:11 ` Common [09/16] Do slab aliasing call from common code Christoph Lameter
2012-08-02 9:29 ` Glauber Costa
2012-08-02 14:13 ` Christoph Lameter
2012-08-01 21:11 ` Common [10/16] Move sysfs_slab_add to common Christoph Lameter
2012-08-01 21:11 ` Common [11/16] slub: Use a statically allocated kmem_cache boot structure for bootstrap Christoph Lameter
2012-08-02 10:11 ` Glauber Costa
2012-08-01 21:11 ` Common [12/16] create common create_kmalloc_cache() Christoph Lameter
2012-08-02 10:22 ` Glauber Costa
2012-08-01 21:11 ` Common [13/16] slub: Introduce function for opening boot caches Christoph Lameter
2012-08-02 10:25 ` Glauber Costa
2012-08-02 14:14 ` Christoph Lameter
2012-08-01 21:11 ` Common [14/16] Move kmem_cache allocations into common code Christoph Lameter
2012-08-02 10:32 ` Glauber Costa
2012-08-02 14:15 ` Christoph Lameter
2012-08-01 21:11 ` Common [15/16] Shrink __kmem_cache_create() parameter lists Christoph Lameter
2012-08-02 8:19 ` Glauber Costa
2012-08-02 14:11 ` Christoph Lameter
2012-08-02 14:14 ` Glauber Costa
2012-08-02 10:34 ` Glauber Costa
2012-08-02 14:31 ` Christoph Lameter
2012-08-02 14:34 ` Christoph Lameter
2012-08-01 21:11 ` Common [16/16] Common alignment code Christoph Lameter
2012-08-02 7:59 ` Common [00/16] Sl[auo]b: Common code rework V8 Glauber Costa
2012-08-02 14:10 ` Christoph Lameter
2012-08-02 8:49 ` Glauber Costa
2012-08-02 9:18 ` Glauber Costa [this message]
2012-08-02 14:13 ` Christoph Lameter
2012-08-02 14:17 ` Glauber Costa
2012-08-02 14:28 ` Christoph Lameter
2012-08-02 14:46 ` Glauber Costa
2012-08-02 14:45 ` Christoph Lameter
2012-08-02 14:47 ` Glauber Costa
2012-08-02 15:13 ` Christoph Lameter
2012-08-02 15:19 ` Christoph Lameter
2012-08-02 18:07 ` Christoph Lameter
2012-08-02 18:09 ` Glauber Costa
2012-08-02 18:13 ` Christoph Lameter
2012-08-02 18:27 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501A45FE.4040008@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox