From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66738C3DA49 for ; Tue, 23 Jul 2024 17:30:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EABB16B0082; Tue, 23 Jul 2024 13:30:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5C826B0083; Tue, 23 Jul 2024 13:30:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D23C16B0085; Tue, 23 Jul 2024 13:30:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A99EC6B0082 for ; Tue, 23 Jul 2024 13:30:45 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 39655A1CDA for ; Tue, 23 Jul 2024 17:30:45 +0000 (UTC) X-FDA: 82371707250.25.157046E Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf11.hostedemail.com (Postfix) with ESMTP id EC24940030 for ; Tue, 23 Jul 2024 17:30:41 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kVpFifPp; spf=pass (imf11.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721755795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9cHdPzr4K9qQeSBivFdfCoG2vPWvfw0XuNk1DtimTEQ=; b=M/PsYzcNlTNYzP2+Qol5FMOc5iCOjC3Ulhfz/9jowlzHw9XEJINxhAany8srJx8izCUzMl jldYl+iBYSk82JKuH79Dm71rrimqztIw1r8wKcWHJUO8WNrZK4405V0ubV4mQ2LtDoBWh7 hDnFUDsU4ayUWUkI/pH1P68go26eN4w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721755795; a=rsa-sha256; cv=none; b=TH9lc2MHtwMP5whMhyj8or7SLWSscTLFYpbA6VM200yk3y23IWBBJsQM5i5MKtbr4tE21J dwfTokmb8Jzi8jFspW0MUREWjBdqhsdFiy9Hw65ZFJMXh0nskftWCC+0ijE6OhOhWgVSnf g3K4UKD/0sL2k5OJRPJKj9QVKwArw2g= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kVpFifPp; spf=pass (imf11.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721755839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9cHdPzr4K9qQeSBivFdfCoG2vPWvfw0XuNk1DtimTEQ=; b=kVpFifPpYQPrrjq5ozBJoceCWBa48WJkEok+vg7l/jgJMGF+t1cKPS5yV36Gp2z9H7ZXiO f3BBBqRu5KkDqc+8YWQ2V7NYKxnI3Ecj9W8UVhJ5tV3WBJl8ZLUH7CwOSbrj1h7ZUhd9qs i5hKD2EvTvAAur5n+4jijr3Nl3A4MxA= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: oliver.sang@intel.com Date: Tue, 23 Jul 2024 10:30:31 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song , kernel test robot Subject: Re: [PATCH] mm: memcg: add cacheline padding after lruvec in mem_cgroup_per_node Message-ID: <4xrfzyqmmq5gmowvyxxqn2xogo4o3rktc2btces3zeamhnaoxz@kor2cgbm46ou> References: <20240723171244.747521-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240723171244.747521-1-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: him3gj5pbn1awnp5dwuj6gxkh9xa8s9f X-Rspamd-Queue-Id: EC24940030 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721755841-437397 X-HE-Meta: U2FsdGVkX1+On3HZ9+7SoxJ5e8sajYtpbRmTMGSsd8iNZMk9p2yQ8jpmy/IOXb+fHpgIX8Kn7nOsLzB4tZNJBXF5UtkTuD+xIZnbxLspYQd0Hn6+qAf8Rgu2GffbmkcW5mbShGklVSeubtdv7BO9lQQnNsAXIZALVraOn5Be5FQwcWwEzzRQyikBjQj31HNzBqmrrgl0xS9joHtsFjtuMZ6MCjc3i1xoOMXE90PZqpv4OqgR1U0UrjduTRNmF2cfqIWBp5bP9bYR6kQWxRivR6JrK81XmOyNcBkwKqwxF5AFLp+Vl+ZxMHUocisCNgU6YOoieNhXsj2TajVbBoAUY5VxQdTIU8CCermhww3PsThUGfjxSGtJJkF3Sy4aQj0btdSffdhupGXXAsnv6UBgOUDdJL5QKrxBjh3ld3+5Eza5MJDelrzk5HlMflYZZOrkpXDjlpPS0DWkfQ7VXa5tbz/RCYbWWtRpG4UlHmY9mysVDOjQu0/udIFR1XirMvIMrCQs9ocgn+FF4y5SSByxwLB5r9JovBzLNveF8Qz4mmfFVeY7m93LTLyLhfsGvDlexuWBWfnyGBJ5QTqsa+bZH4Fd69TMUd5PVoOCzpfnwqLsP3l0Hc+Cu44VTDsDnzNedY7yILIrHNhjTQLj/i0l8T+4WBO33p4uQiasW/5Bh1s6PDswZ0r+vKyiNjNEyaZRnhvPxwa6wAhKwoizerVZ46h249w8iQwEU5ZCgL6b+VAW3NfnL6gHEndsKVjfg5Em51cKex4wRNIkMcSlS7BEkaDZOJN7+cvsmy09is6khsiw1QvJMKvn2uLpViVQMOcj9WTytS0Gs551ifKjuLP9SDnKH3uiULtSy4LFV6+SDMeFIBFJJ0lTI1kbdjnn3T3uxBJ/dCEcOcEvFNAPONgYEZ17O/r/gtMFvdBB5FcWvisUROvRNlo0gyWcGjScnlIMzJCIG95YT0uIi4Yt8W2 lg5/xDkd QfJS0u1zN8pi9onKfKFR4jH4pOrtcn/oQFm+F3upiDgqP5OgiTnMw2aQbpf/smDVCjHUAPxz4G40wAxjvQyQmjYbjTBDGx61gqgSG6VB/Jh0tnH/is1s7iGJtJjdf3rAe0OrpQ5Kt5Zy8/67PPfkAk2GX+SdAi6TyIRuvo9lX3KYetyaB3tujK5LQR7IxMfZctym5aDiNLukxVOQHTDU3iRXOvgUYraUFLfkq+Hqzd3UX/DF/A0qxXJO+2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 23, 2024 at 05:12:44PM GMT, Roman Gushchin wrote: > Oliver Sand Oliver Sang > reported a performance regression caused by > commit 98c9daf5ae6b ("mm: memcg: guard memcg1-specific members of struct > mem_cgroup_per_node"), which puts some fields of the > mem_cgroup_per_node structure under the CONFIG_MEMCG_V1 config option. > Apparently it causes a false cache sharing between lruvec and > lru_zone_size members of the structure. Fix it by adding an explicit > padding after the lruvec member. > > Even though the padding is not required with CONFIG_MEMCG_V1 set, > it seems like the introduced memory overhead is not significant > enough to warrant another divergence in the mem_cgroup_per_node > layout, so the padding is added unconditionally. > > Fixes: 98c9daf5ae6b ("mm: memcg: guard memcg1-specific members of struct mem_cgroup_per_node") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202407121335.31a10cb6-oliver.sang@intel.com > Tested-by: Oliver Sang > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt