From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFD2E77188 for ; Mon, 6 Jan 2025 09:13:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01B566B0082; Mon, 6 Jan 2025 04:13:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0D266B0088; Mon, 6 Jan 2025 04:13:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAD356B0089; Mon, 6 Jan 2025 04:13:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BDCCC6B0082 for ; Mon, 6 Jan 2025 04:13:48 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 43AF9C144D for ; Mon, 6 Jan 2025 09:13:48 +0000 (UTC) X-FDA: 82976464536.14.4321BEF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id B61E41C0004 for ; Mon, 6 Jan 2025 09:13:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KRmrPign; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="vxyQPM/F"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KRmrPign; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="vxyQPM/F"; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736154826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dDkRF+Vf55DYF2+Zua2WtZLKZjL1FB0xYlA/o8pczd8=; b=WNu4p3yVAJ5TuEI033GD2MNgyhHeoV8Jpr9bikWUTw/Llj2g80Ta2pMYdgcOL2tOfxbGF+ hzuUPXfl2vuL+cTD91w0mloY4DBP8OfNBk48qdDWIE0ydXZ/PNGvnHXQ/QV/ichT2dr7Kt 2QRHQMSfcp1nm4jj3HKkthwxd4zn380= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KRmrPign; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="vxyQPM/F"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KRmrPign; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="vxyQPM/F"; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736154826; a=rsa-sha256; cv=none; b=8eqeFqm5V+M2lAXoNGCpBAvBdpgTujfpBfWz/xJNE91Lf33dXqTtzoUvXEFMvqh4wqGZ0q GmtmtBBwJBZ71YO04FxjJWJqcI2O8QcO0EpL8ombxaY3dKUrHLCKfVKJdCQgMF5K2Pt/8C CIeE7uyRAXEhNewQuC2WmNB8PeFoTbE= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0417221157; Mon, 6 Jan 2025 09:13:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736154824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dDkRF+Vf55DYF2+Zua2WtZLKZjL1FB0xYlA/o8pczd8=; b=KRmrPign7EHmD19HO4vsyczHnQ8URTrayWVqOGlCQ1QT8a+xr/aYJU38lveFv703p+tylI 04dr38yadqoaFgejSxFAbdKL4OI9iO3tDJcb1qA9DL6JqsQeyUL18JaCv6zwLh1uFADWxU a1sW9aOHW8fETKv4K5y7PuxoxBqNLNE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736154824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dDkRF+Vf55DYF2+Zua2WtZLKZjL1FB0xYlA/o8pczd8=; b=vxyQPM/FaV4IqQFLjVAINS5ugChoY04ZQ8+n6dBpnBGl3763BAa/znQYeTY6V3+uzzkEmv guZQf6j8oyh9WXBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736154824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dDkRF+Vf55DYF2+Zua2WtZLKZjL1FB0xYlA/o8pczd8=; b=KRmrPign7EHmD19HO4vsyczHnQ8URTrayWVqOGlCQ1QT8a+xr/aYJU38lveFv703p+tylI 04dr38yadqoaFgejSxFAbdKL4OI9iO3tDJcb1qA9DL6JqsQeyUL18JaCv6zwLh1uFADWxU a1sW9aOHW8fETKv4K5y7PuxoxBqNLNE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736154824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dDkRF+Vf55DYF2+Zua2WtZLKZjL1FB0xYlA/o8pczd8=; b=vxyQPM/FaV4IqQFLjVAINS5ugChoY04ZQ8+n6dBpnBGl3763BAa/znQYeTY6V3+uzzkEmv guZQf6j8oyh9WXBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E6CB3139AB; Mon, 6 Jan 2025 09:13:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qZVXOMeee2coagAAD6G6ig (envelope-from ); Mon, 06 Jan 2025 09:13:43 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 875C1A0887; Mon, 6 Jan 2025 10:13:43 +0100 (CET) Date: Mon, 6 Jan 2025 10:13:43 +0100 From: Jan Kara To: Maninder Singh Cc: viro@zeniv.linux.org.uk, elver@google.com, brauner@kernel.org, jack@suse.cz, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, r.thapliyal@samsung.com Subject: Re: [PATCH 1/1] lib/list_debug.c: add object information in case of invalid object Message-ID: <4vvrz4fqhtxb4l6yfapxaj37cxmcgywqwzg2c3rhswjsleq54a@glu62exwujrh> References: <20241230101043.53773-1-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241230101043.53773-1-maninder1.s@samsung.com> X-Rspamd-Queue-Id: B61E41C0004 X-Stat-Signature: 17p454fnnprxozbwzsd3a16oh8315kjq X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736154825-48817 X-HE-Meta: U2FsdGVkX18O8EwojWCsGLHyWAyouQoxyseVTA0QQVIrKQ9RkJuvMBzVq2dRWtVa34D6vZbHzAhzk2iSw9yYRLZK+GHYofJ/ZxCt3w71u1Zfpl/IoM4PGgowzwH52OsA3lqDya4+OGl89EC14tA7dwRxqbwWyoE85ue/KKgFgvv22+J5lGsyANMPzULUqgY1Qo2ZBBR6ORostVS69GpY6Xh2lgUxEkKnLZWRyjieRoO8kVIWuvWERbYH6qUtACeDBy/LjmHv9wAELfKJMWYThCZ7PPMKGYr44u1x0nsJy1Kl7mxgkf7meInadZPk+ps3HI0rgg1OJwEYCdbQEN+s5/iZU7tXRnbubSPgkT7LNvcHvYTzul4G3Qy1yywlpcdqJemjjA6iC7WlE8xc4V7NEJAdNLeVOj7kPB0UEPP5JQdsNuB3d7LN3JzpHPkZAscRNeAGzG2fBZwt6p8DkJhkNBSgms0c/ThTBM3iSZlSMQGx0Xm1vvPd5n//d6BctVjC6/gHzGqqwrlvOHCG5Ozw5R4vDB31XCU3CwYSm4Gsh3nchQYhNvPgAVY5c01dzTcdoJsaRNOlKfBAikzBVYag8pye4eGGMKx4h/yZZ610yFCTzGSTA3vnCrHXqqN3odr8ilyfY06PU5McvdeTxOat36keDEPkpP0enirD5MhW+nQGKBEmbg4XrvLJPBQ1jMlnVL1gMbk9wnwmviHzaLJabP2mC/nXZLJSWfdrOzD0GydZpoyZ9KJ3RZdiiZsaVkLK+hijKI+Z2pw5sPFVEkx2KhatxOXEeBs6Sn/XJAZm/bFfEhneQvB25VXvM5OmbnUVIjfrJD0lmDq01dYej/PNPDBpOFKpPwBKKlr3WpAeJBDjnIX6FfXNHf2pTOQjVZulo05xi7yWMkm52R2QzdKIfkl92KpjjA+timlWNit3sEp5CXhyk7YuV/xmxI5KnS9CHT0yDIuQWwGIQSPQQam KtT9YCfT tTsaheeVRKRH4TVP5iMTfkkijzUieam0MYEQCVxEbP8IuRteGlfq/j7cUdvEwpc2bMrIe4VH6CwxA3y20LDVcXvYoi8Tf0bVik9Nd5BKtXgdqIs7SemK6+Xf8bjjd5ENtDK7lFXaYVvidbmRSGlhnAbCGBIho4JQLlmn2Q+L55o0TQPjJ+g1HimNL3S61h/JfO+q3SU/Ux78G6/kJ8abtMMia5rnylVJY+97rHxf/H8nalHY2BrH26FQIwp6l5X+RsWly+ZfLnHx0rU6Hd3wH3OtcUhaAJ5PA9hke0WqMJ9sA9s8iIHPTvlY8+rHrcOZ5I/mHrOZl7LUUa05zE2I1ONSm9c3T/r8ZJL5PvQP9e9UmFVyzKsRFv57oHLg/uqYooBvzfLU4oxm/1mnXzcsKfOzjG4WaPbJjCiL1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 30-12-24 15:40:43, Maninder Singh wrote: > As of now during link list corruption it prints about cluprit address > and its wrong value, but sometime it is not enough to catch the actual > issue point. > > If it prints allocation and free path of that corrupted node, > it will be a lot easier to find and fix the issues. > > Adding the same information when data mismatch is found in link list > debug data: > > [ 14.243055] slab kmalloc-32 start ffff0000cda19320 data offset 32 pointer offset 8 size 32 allocated at add_to_list+0x28/0xb0 > [ 14.245259] __kmalloc_cache_noprof+0x1c4/0x358 > [ 14.245572] add_to_list+0x28/0xb0 > ... > [ 14.248632] do_el0_svc_compat+0x1c/0x34 > [ 14.249018] el0_svc_compat+0x2c/0x80 > [ 14.249244] Free path: > [ 14.249410] kfree+0x24c/0x2f0 > [ 14.249724] do_force_corruption+0xbc/0x100 > ... > [ 14.252266] el0_svc_common.constprop.0+0x40/0xe0 > [ 14.252540] do_el0_svc_compat+0x1c/0x34 > [ 14.252763] el0_svc_compat+0x2c/0x80 > [ 14.253071] ------------[ cut here ]------------ > [ 14.253303] list_del corruption. next->prev should be ffff0000cda192a8, but was 6b6b6b6b6b6b6b6b. (next=ffff0000cda19348) > [ 14.254255] WARNING: CPU: 3 PID: 84 at lib/list_debug.c:65 __list_del_entry_valid_or_report+0x158/0x164 > > moved prototype of mem_dump_obj() to bug.h, as mm.h can not be included > in bug.h. > > Signed-off-by: Maninder Singh Looks like this could be useful. The changes look good to me. Feel free to add: Acked-by: Jan Kara Honza > --- > Comment: I am not sure about moving of prototype, we can make a new wrapper also, > so please suggest what is best option. because name mem_dump_obj does > not go with bug.h > > fs/open.c | 2 +- > fs/super.c | 2 +- > include/linux/bug.h | 10 +++++++++- > include/linux/mm.h | 6 ------ > lib/list_debug.c | 22 +++++++++++----------- > 5 files changed, 22 insertions(+), 20 deletions(-) > > diff --git a/fs/open.c b/fs/open.c > index 0a5d2f6061c6..932e5a6de63b 100644 > --- a/fs/open.c > +++ b/fs/open.c > @@ -1529,7 +1529,7 @@ static int filp_flush(struct file *filp, fl_owner_t id) > { > int retval = 0; > > - if (CHECK_DATA_CORRUPTION(file_count(filp) == 0, > + if (CHECK_DATA_CORRUPTION(file_count(filp) == 0, filp, > "VFS: Close: file count is 0 (f_op=%ps)", > filp->f_op)) { > return 0; > diff --git a/fs/super.c b/fs/super.c > index c9c7223bc2a2..5a7db4a556e3 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -647,7 +647,7 @@ void generic_shutdown_super(struct super_block *sb) > */ > fscrypt_destroy_keyring(sb); > > - if (CHECK_DATA_CORRUPTION(!list_empty(&sb->s_inodes), > + if (CHECK_DATA_CORRUPTION(!list_empty(&sb->s_inodes), NULL, > "VFS: Busy inodes after unmount of %s (%s)", > sb->s_id, sb->s_type->name)) { > /* > diff --git a/include/linux/bug.h b/include/linux/bug.h > index 348acf2558f3..a9948a9f1093 100644 > --- a/include/linux/bug.h > +++ b/include/linux/bug.h > @@ -73,15 +73,23 @@ static inline void generic_bug_clear_once(void) {} > > #endif /* CONFIG_GENERIC_BUG */ > > +#ifdef CONFIG_PRINTK > +void mem_dump_obj(void *object); > +#else > +static inline void mem_dump_obj(void *object) {} > +#endif > + > /* > * Since detected data corruption should stop operation on the affected > * structures. Return value must be checked and sanely acted on by caller. > */ > static inline __must_check bool check_data_corruption(bool v) { return v; } > -#define CHECK_DATA_CORRUPTION(condition, fmt, ...) \ > +#define CHECK_DATA_CORRUPTION(condition, addr, fmt, ...) \ > check_data_corruption(({ \ > bool corruption = unlikely(condition); \ > if (corruption) { \ > + if (addr) \ > + mem_dump_obj(addr); \ > if (IS_ENABLED(CONFIG_BUG_ON_DATA_CORRUPTION)) { \ > pr_err(fmt, ##__VA_ARGS__); \ > BUG(); \ > diff --git a/include/linux/mm.h b/include/linux/mm.h > index d61b9c7a3a7b..9cabab47a23e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -4097,12 +4097,6 @@ unsigned long wp_shared_mapping_range(struct address_space *mapping, > > extern int sysctl_nr_trim_pages; > > -#ifdef CONFIG_PRINTK > -void mem_dump_obj(void *object); > -#else > -static inline void mem_dump_obj(void *object) {} > -#endif > - > #ifdef CONFIG_ANON_VMA_NAME > int madvise_set_anon_name(struct mm_struct *mm, unsigned long start, > unsigned long len_in, > diff --git a/lib/list_debug.c b/lib/list_debug.c > index db602417febf..ee7eeeb8f92c 100644 > --- a/lib/list_debug.c > +++ b/lib/list_debug.c > @@ -22,17 +22,17 @@ __list_valid_slowpath > bool __list_add_valid_or_report(struct list_head *new, struct list_head *prev, > struct list_head *next) > { > - if (CHECK_DATA_CORRUPTION(prev == NULL, > + if (CHECK_DATA_CORRUPTION(prev == NULL, NULL, > "list_add corruption. prev is NULL.\n") || > - CHECK_DATA_CORRUPTION(next == NULL, > + CHECK_DATA_CORRUPTION(next == NULL, NULL, > "list_add corruption. next is NULL.\n") || > - CHECK_DATA_CORRUPTION(next->prev != prev, > + CHECK_DATA_CORRUPTION(next->prev != prev, next, > "list_add corruption. next->prev should be prev (%px), but was %px. (next=%px).\n", > prev, next->prev, next) || > - CHECK_DATA_CORRUPTION(prev->next != next, > + CHECK_DATA_CORRUPTION(prev->next != next, prev, > "list_add corruption. prev->next should be next (%px), but was %px. (prev=%px).\n", > next, prev->next, prev) || > - CHECK_DATA_CORRUPTION(new == prev || new == next, > + CHECK_DATA_CORRUPTION(new == prev || new == next, NULL, > "list_add double add: new=%px, prev=%px, next=%px.\n", > new, prev, next)) > return false; > @@ -49,20 +49,20 @@ bool __list_del_entry_valid_or_report(struct list_head *entry) > prev = entry->prev; > next = entry->next; > > - if (CHECK_DATA_CORRUPTION(next == NULL, > + if (CHECK_DATA_CORRUPTION(next == NULL, NULL, > "list_del corruption, %px->next is NULL\n", entry) || > - CHECK_DATA_CORRUPTION(prev == NULL, > + CHECK_DATA_CORRUPTION(prev == NULL, NULL, > "list_del corruption, %px->prev is NULL\n", entry) || > - CHECK_DATA_CORRUPTION(next == LIST_POISON1, > + CHECK_DATA_CORRUPTION(next == LIST_POISON1, next, > "list_del corruption, %px->next is LIST_POISON1 (%px)\n", > entry, LIST_POISON1) || > - CHECK_DATA_CORRUPTION(prev == LIST_POISON2, > + CHECK_DATA_CORRUPTION(prev == LIST_POISON2, prev, > "list_del corruption, %px->prev is LIST_POISON2 (%px)\n", > entry, LIST_POISON2) || > - CHECK_DATA_CORRUPTION(prev->next != entry, > + CHECK_DATA_CORRUPTION(prev->next != entry, prev, > "list_del corruption. prev->next should be %px, but was %px. (prev=%px)\n", > entry, prev->next, prev) || > - CHECK_DATA_CORRUPTION(next->prev != entry, > + CHECK_DATA_CORRUPTION(next->prev != entry, next, > "list_del corruption. next->prev should be %px, but was %px. (next=%px)\n", > entry, next->prev, next)) > return false; > -- > 2.25.1 > -- Jan Kara SUSE Labs, CR