From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009E7C5478C for ; Mon, 26 Feb 2024 20:50:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CB246B02B4; Mon, 26 Feb 2024 15:50:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 554B86B02B5; Mon, 26 Feb 2024 15:50:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CE2D6B02B6; Mon, 26 Feb 2024 15:50:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 258E76B02B4 for ; Mon, 26 Feb 2024 15:50:41 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B6C6980A2C for ; Mon, 26 Feb 2024 20:50:40 +0000 (UTC) X-FDA: 81835148640.18.F486CE8 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf01.hostedemail.com (Postfix) with ESMTP id F343340016 for ; Mon, 26 Feb 2024 20:50:37 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HcSqhizu; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708980638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mIdkIRtnrOSnd32neZalGi5cjdozYTT6FIEdWcWsU6U=; b=qq0ft0yIlr59d4CLVOLiNv9B7xK5lLQfmidAe6q+WE0u7WsIO5iW+riugdpLACYa+AccNU 6tKPZ8EoE2IF1KUdYshmf/dSTghHAImbOWgfehGy7d/XKN4wOE7mgqTxE9/HY2VdBO2ep5 tWX9j3STKyvg9Yo/LM6LPHiYlrH8a5s= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HcSqhizu; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708980638; a=rsa-sha256; cv=none; b=EjQ0RVIOY5fMQg3G8nq0rouMwmFYzfRa3dpFWJNKGL85ZQ74FYxGHkpPGU4XCvYn4oUuKw cDjc6s8wrMrnmgoKQ7YXcNbR2Otern9NyinKg5VAhsMa5/io7miofBCbswwmS7nZfYkFpB bfgLwhA2K1cUWIxYU8vWliWlzVMcdvs= Date: Mon, 26 Feb 2024 15:50:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708980635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mIdkIRtnrOSnd32neZalGi5cjdozYTT6FIEdWcWsU6U=; b=HcSqhizuRpNge/p4Z96mL1vYf4HBThYX/JtRwapRQvIQkUUrCJFkJbw2jiZlCrr1G01OY6 VEdKjsiolBcD3vnVkbSepoV1u7spOFQRwGmtRyPJ2rPlH/FFfryTukpBmQxkHJUVCq9K/U bro4rJOJCyg9F/1Fe1ZUZ2cOW9BM2KM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Vlastimil Babka Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Alexander Viro Subject: Re: [PATCH v4 05/36] fs: Convert alloc_inode_sb() to a macro Message-ID: <4uhmoltnaywbhhecnj53g5a6ye3x5acf4upbutgraxn2eg2pe2@6ab667edrl2z> References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-6-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: F343340016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ejuorfz7r4a6rh699qi3jr63wkhoksuu X-HE-Tag: 1708980637-512965 X-HE-Meta: U2FsdGVkX19ASKtErIs+lhqdClGBPKTwb6m7FtsJ1rrc8vDDevvKZeJCtuUXRFVfuyym1ckEyUtNsoLBXf3poeN4AGwW6cHTAsdccOoSApOF5iA0oA4RwtZpGtVnBD+F9GUEbeoWfTwiSNhUz3BcbcjM1Y8+4GTANV7Zo91wuYRbCEOBEmdgQ4Wn7gRqiiFzhYEpuoijCxrXaZ91msKZ+T9RORnzJPTZw1Jm3IW4N0YdBwBKyiDPlUq+tvX+155cbfb9NA5XYBEOnqQ1e4H8uYtxXzpgt/L8itVLzo3MvrQRIcCKavdMYKqMSd+g4aThPO+Va/2xmhCL10fCVyjtTkIBnnNBRGohpz3OpcJzr7LzP1ALqxqpZ4SVEAyKiv1VfOXzCvKUFVCBUmcD2dAA/Z1mRWZHQNR9rcOdTZL9NtTUS5Sz1NAgWB9MV1zWWZH751JAQI+xi6Dz+q8Z+T4UT12syBvoRYTBfQrYkjNLHWdNb+S50hupCrIhjvCDbj1VJmRpOIIkqxQuXNPOJIT6Gzj7JJqc5gHhVfxgYGK8A5e/Q2phSphlzHr5Q1nZHNvb4w/x4Bp3LaZ+ZltEoKHh7jEJwQuO5ybktE7XJW7aEgUsCVM5l3Glj+3oXBvu+blpfs5Rvt6pc6p6tzdiPuBgdW0JCcqc102tRKu7auYcYjR5aRby41UsHVkmK3W57TMOt4Zs7rUFcmt4TA7KGcP6xaFnQI/Iey4Ip+jkU70mfX8rUxt5ZWk+OhRrkzUEgq0HANZt2I2siwy5RvQBbvYCsdVNfi0n+ng+XBd0nXbPiXl5Kcz/83mGlTlcsOhEghVfVMGthUEVeiajb6gyjaXHuCBIGBNIjT9C6tLf2+By626iNYG8QuzainQOQLK5u0x0t51h06YksbEdT/DlbpE+T1DzwcMq23XF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 04:44:51PM +0100, Vlastimil Babka wrote: > On 2/21/24 20:40, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > We're introducing alloc tagging, which tracks memory allocations by > > callsite. Converting alloc_inode_sb() to a macro means allocations will > > be tracked by its caller, which is a bit more useful. > > > > Signed-off-by: Kent Overstreet > > Signed-off-by: Suren Baghdasaryan > > Cc: Alexander Viro > > Reviewed-by: Kees Cook > > --- > > include/linux/fs.h | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index 023f37c60709..08d8246399c3 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -3010,11 +3010,7 @@ int setattr_should_drop_sgid(struct mnt_idmap *idmap, > > * This must be used for allocating filesystems specific inodes to set > > * up the inode reclaim context correctly. > > */ > > -static inline void * > > -alloc_inode_sb(struct super_block *sb, struct kmem_cache *cache, gfp_t gfp) > > A __always_inline wouldn't have the same effect? Just wondering. nope, macro expansion within an inline happens once, and will show __func__ and __line__ of the helper, we want it expanded in the caller