From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC1CCD1288 for ; Wed, 3 Apr 2024 21:42:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52D596B008C; Wed, 3 Apr 2024 17:42:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DE306B0092; Wed, 3 Apr 2024 17:42:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A57C6B0093; Wed, 3 Apr 2024 17:42:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1BCAF6B008C for ; Wed, 3 Apr 2024 17:42:14 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 994691606D0 for ; Wed, 3 Apr 2024 21:42:13 +0000 (UTC) X-FDA: 81969544146.14.78EB6C8 Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by imf30.hostedemail.com (Postfix) with ESMTP id A12E28001A for ; Wed, 3 Apr 2024 21:42:10 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lGMlDuct; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712180531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I8oAok5It38shVDkwL940Pa8qX3ifwx6XR6MQgkhnY4=; b=sDmytfFA7vXBvrXsGXv/viHwZR2fRq8IOLFzk6jfNkW44mve5NOWx/UWOOiL1BcZqhwSM9 Cr8KdFj93io0VV6IwJ6pwpWa1KcmQGJQbMUvyb1rQ8B16ZS3CCa5FbCioSWbCVOnn0e9E3 G6iZXj0XayXCsxOC4hRGHMUVleiJOUQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lGMlDuct; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712180531; a=rsa-sha256; cv=none; b=5+pWpAvOdB+NIS7pUrJAKR6EKEG4eZtWaYFJrhE8UgoKit1WARg+cy8upm0cb0LItkulCQ yUDwP1xLGU9cB4beQ5+7XeHn4Erw7xG3Goyax+odr6E0/H9netR9iXmKobO7nW6AhWMhPy 9cQH5qOHx8Z7VM8kDaPQU1TcZrikHts= Date: Wed, 3 Apr 2024 17:41:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712180527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I8oAok5It38shVDkwL940Pa8qX3ifwx6XR6MQgkhnY4=; b=lGMlDuctByVDszORVgYlbk2emZzNfH18lVbOM3PP8QqASVaLVaaVhE4vLYrvnQGixqKQn+ JoBwih61WSwFWMdg5hVCAoj/8hdJcJ9cfeJ6GbrYKLCxCnMqAOBy1GlT1ZzritCAT4+N6a jWAURONL2YqX3Zp+MfY4wq5MmwF4PmI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Nathan Chancellor Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v6 01/37] fix missing vmalloc.h includes Message-ID: <4qk7f3ra5lrqhtvmipmacgzo5qwnugrfxn5dd3j4wubzwqvmv4@vzdhpalbmob3> References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-2-surenb@google.com> <20240403211240.GA307137@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403211240.GA307137@dev-arch.thelio-3990X> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: A12E28001A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ctqz7yeh1kt8io7p5wqrhkzdshqop6fi X-HE-Tag: 1712180530-260588 X-HE-Meta: U2FsdGVkX1/2fFOLdPhGyQcPQJ9ROLXgnSoyumoIE2RHkbuc1/Q5Vz8DQEVc4wzHl5/xlxaDOn3yIowpeb/QxcN8MKddHgkjKJiYHCv+0U0dPIVP2QjwvHzSiGbS98o9HBylHeVYvifslO6InkR/86JQOsime8sMU7pk/Qi3S4YLraOIZzdIwK1sul5+wAuieAt7c4P93LsM82o5jxW8jf0v117CaBYUBW8MbqWZxI1e7PD6gjGHzy7UUQsvHUIn/euSY00bVCwGgnJqxTP1DX7pJFMGD3HUDF4cnciaZwvL90SfE/iMFJ5sFb2KJ90R6ZLrkJmApCwNOhPAq5+K1IW1KrzcS7mQIcwmwkqLQG2/vjtUyMZqdA+EwA/Bg57cbrPazdbxyIGp8EF99z1m/Bub4/eVRsKyXPqbV8s+LqWdreREjdiFNsmVdPDrMRIU+zc8nbfDT/kXANrSs5Qrt3nEiC6vL+13DtHo6zfTL+88EOILR2WNvnas/I6uB6mML18w3OX2a45szyJU/cL1hjo2jAQBDznzPMAyMtQ2QHE2PCoKNvuRoXhdWQdbCMhrvyxtSK+iSj0mVc/0THDefCneBe3BCG2zBI84Zoauf2xRj3DMLam+LAm6ez/3CwJaeS8cVawLylD1Q5HndbG/yUTKj40mh5j2/NRSRqFutdoZtkZWzqSsXhutTpCyzab77s9em0t/1EKlTVwNASmnFX2qyDe1mj+54Fz+1fH+mkoeBTF1ZLGOAeGle42isIdGWLhrRBoqri3tW7gp9baTdHJCQ1F5zxIMrbSluKFh3435FowscrJE107QFSoPtNXIjjL/YXC6SCwfju/VtRsTGT4WcrpFdzNHX6JkvBHdOXr358kUQnX6+RU3kTdLbed80EfNCO2+vm2aWX+BekWpWVMajfTqiz4T1pv3imwv9axnaYifUg4OwyWSgL9LLsJzIkqAgaMdTIqmdgvNqY1 Oic7VVgs Q81Hrc8X8CuxAEfOCN9bjlyNTz2o2Uju7TRHaxRN6MN5exZhwydLBzokp9AZE90lIWnGbColEdLQMpqMsrRC7q/XwPCxNoPnTHAxkca6Zu/zyCBSnpLfqSlPsz9TqSe3XudEgJ1nXwH7mtwo3iM8V16ha5inozIJYPFBvD6K0EHFhMcxSClNlUa7IpBqcSVD+zFPfXPfEztoFTf6+TFnvu2cpJXDLGi4rBLGxitGxw4S3e2ZLCurz+eSVNrwNyOj5PP9DQndFu3XQzyEcKqz6PkxS0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 02:12:40PM -0700, Nathan Chancellor wrote: > On Thu, Mar 21, 2024 at 09:36:23AM -0700, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > The next patch drops vmalloc.h from a system header in order to fix > > a circular dependency; this adds it to all the files that were pulling > > it in implicitly. > > > > Signed-off-by: Kent Overstreet > > Signed-off-by: Suren Baghdasaryan > > Reviewed-by: Pasha Tatashin > > I bisected an error that I see when building ARCH=loongarch allmodconfig > to commit 302519d9e80a ("asm-generic/io.h: kill vmalloc.h dependency") > in -next, which tells me that this patch likely needs to contain > something along the following lines, as LoongArch was getting > include/linux/sizes.h transitively through the vmalloc.h include in > include/asm-generic/io.h. gcc doesn't appear to be packaged for loongarch for debian (most other cross compilers are), so that's going to make it hard for me to test anything... > > Cheers, > Nathan > > In file included from arch/loongarch/include/asm/io.h:11, > from include/linux/io.h:13, > from arch/loongarch/mm/mmap.c:6: > include/asm-generic/io.h: In function 'ioport_map': > arch/loongarch/include/asm/addrspace.h:124:25: error: 'SZ_32M' undeclared (first use in this function); did you mean 'PS_32M'? > 124 | #define PCI_IOSIZE SZ_32M > | ^~~~~~ > arch/loongarch/include/asm/addrspace.h:126:26: note: in expansion of macro 'PCI_IOSIZE' > 126 | #define IO_SPACE_LIMIT (PCI_IOSIZE - 1) > | ^~~~~~~~~~ > include/asm-generic/io.h:1113:17: note: in expansion of macro 'IO_SPACE_LIMIT' > 1113 | port &= IO_SPACE_LIMIT; > | ^~~~~~~~~~~~~~ > arch/loongarch/include/asm/addrspace.h:124:25: note: each undeclared identifier is reported only once for each function it appears in > 124 | #define PCI_IOSIZE SZ_32M > | ^~~~~~ > arch/loongarch/include/asm/addrspace.h:126:26: note: in expansion of macro 'PCI_IOSIZE' > 126 | #define IO_SPACE_LIMIT (PCI_IOSIZE - 1) > | ^~~~~~~~~~ > include/asm-generic/io.h:1113:17: note: in expansion of macro 'IO_SPACE_LIMIT' > 1113 | port &= IO_SPACE_LIMIT; > | ^~~~~~~~~~~~~~ > > diff --git a/arch/loongarch/include/asm/addrspace.h b/arch/loongarch/include/asm/addrspace.h > index b24437e28c6e..7bd47d65bf7a 100644 > --- a/arch/loongarch/include/asm/addrspace.h > +++ b/arch/loongarch/include/asm/addrspace.h > @@ -11,6 +11,7 @@ > #define _ASM_ADDRSPACE_H > > #include > +#include > > #include >