From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 842ABC54798 for ; Tue, 27 Feb 2024 08:53:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F11C36B0158; Tue, 27 Feb 2024 03:53:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A4B6B0159; Tue, 27 Feb 2024 03:53:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D39CF6B015B; Tue, 27 Feb 2024 03:53:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BDECD6B0158 for ; Tue, 27 Feb 2024 03:53:42 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5CC17140B11 for ; Tue, 27 Feb 2024 08:53:42 +0000 (UTC) X-FDA: 81836970684.26.41D5F98 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by imf30.hostedemail.com (Postfix) with ESMTP id 9BA0980003 for ; Tue, 27 Feb 2024 08:53:39 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=bwkd6Fsd; dmarc=none; spf=pass (imf30.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709024021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xG7fSz4uiTp34cw0D1g4RsXUHnXCjcPMxUY/Xls6pRo=; b=rEWWRXWiJXzPxCSghtRvuYQMnjddvXmplER1TqVVl4R4YaziC3HZRCWfP1Me1IUFWDOM2U 8mLj/49/4mxiQNvvXvVrcRayKKXIXHk7nYTfbWgwiPavkdCh2lG4GgLqQG/ed6T38nlvaY LMXnUYtf5hsZGYGBJc0w0eDbMAFMDJ4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=bwkd6Fsd; dmarc=none; spf=pass (imf30.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709024021; a=rsa-sha256; cv=none; b=751TqhaPI1kdPs5TecQCXEyliGEtbHZz1IwWdqxiQYk0YQ+C28STBhIRPQprkrNfVXP++y heFjVroDGTg2b+0Dqllo32xCHpZN0xBGFsWsfY9xCQBLNPi89YGQVRXdPZSxqQv2vQvykP 9e+Pnp306WHzSBE0cJxKF3NZMw/32zE= Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4TkWVR1BWbz9sq8; Tue, 27 Feb 2024 09:53:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1709024015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xG7fSz4uiTp34cw0D1g4RsXUHnXCjcPMxUY/Xls6pRo=; b=bwkd6Fsd51NLXnw7/z4WN4Vs9Rq95oo0ECbijUAdGiZjRV8oRKfHkJ+OlRoEwAYUgii4pS MJ6N8K30jVn6Q2b2nLufYhRyspVwGc571+3xnbsWTGqyQylWKNt3/WAB4+3jj22X+uXNGp er7tF/crJ2UnX2wo0x2jAtNDMop+kVMFZZoocmy0PIlDCVAHiGHsq6Xj4hsygm0AemiHN5 81IoGf4NY68rYwbeGrdPcrCypTL6kXf9Aq/uHW/fN7QnjwTfj2ooIhy0VjwxMNpP0fLB15 6sEDSjk7gxfDiRshE2FVkzv1AJ6fy03HKMgo+Ks7Ky8MNax3pJbMCjpHC+WUYw== Date: Tue, 27 Feb 2024 09:53:31 +0100 From: "Pankaj Raghav (Samsung)" To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, chandan.babu@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, ziy@nvidia.com, hare@suse.de, djwong@kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, willy@infradead.org, Dave Chinner Subject: Re: [PATCH 11/13] xfs: expose block size in stat Message-ID: <4ojxfvnqw6d5dytkcw55olpbdcbwy2pgs7d6mchg6nmgt3icbi@rvzrifqb5x3k> References: <20240226094936.2677493-1-kernel@pankajraghav.com> <20240226094936.2677493-12-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9BA0980003 X-Stat-Signature: id55mgqosway3kw8atdwafjamhti7kro X-HE-Tag: 1709024019-15583 X-HE-Meta: U2FsdGVkX1+DRLl3ivqnbSsWOgF2wruJ9u5IHVXNcVpiM7x4gE8xB2HscSIu6yQOh0xeIDc0C+UDwKZqLazBI+jqm1k+W7yKFs2AxMFqoAj8A7Pqe32IY3HT//tfkhPJSE7Pb4Bd8jeCy3jRaTrEzouehuz4LDFTwuBjZgdqmYaSUDN6WnfQc6l+i09kr1vppFzUsmk8gLbwKCEGDm0qIk5UWrB6EGUs+OPl39sWePEkcXOtqcl1qz4hqo5oErh0UWxybH916gnxnS66WKwpQ+F7tRb7qXE18M9cNA4OR+IFnfhugoF0aEtjaiNYcGTm7YAJqjVqXID5Eu8hNAgVXc9OY8UYM9Lp/xbdXgm8DQv7E81ar+25IIRFCPK8l6DtcnkIz4gUs4Iro5ms7l7/Q+HPHbRVWH2aEv+CL+dn3RxwUlCrwJlj5Ef9HPk78rVdhdLi0c551Xr0SWdPxtDelnTUGwKMgrC09ZCcLCorirlrQMHaYh/GTYiXYqFs8W0ZxoMPCmkaakaQnXX2E0LjnVkERNm6jvwSmVo/eS0fS6FQnbDa5tb+VHnnEAboknQaSj5WvIlZzZ2/JgBHRr6/azJ5YPFkY37dsN3+Vu6IZEbzxDyo1yU2+Vp7bL48W3Li5Pv1pKvdCqJ2RBB6RdzNmFpq4IVPqXQV5XRNIbKsiRjyyjffntG6+b0wciqbZJ4NCuhE3l1d54Ps+68z7BjPo80QxadWrrXPHZyiCDrUJkeTz/12iFnAQR+H3dZgW55M3TpFxni/6F1owhjZktdkNgcfPukiwcKc644z+peYeFi7E/kBcTVS1V643Raa7ACX3Ck51vhOaBjBW087QSq3IDAtn6CcNBUP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 11:44:16PM +1100, Dave Chinner wrote: > On Mon, Feb 26, 2024 at 10:49:34AM +0100, Pankaj Raghav (Samsung) wrote: > > From: Dave Chinner > > > > For block size larger than page size, the unit of efficient IO is > > the block size, not the page size. Leaving stat() to report > > PAGE_SIZE as the block size causes test programs like fsx to issue > > illegal ranges for operations that require block size alignment > > (e.g. fallocate() insert range). Hence update the preferred IO size > > to reflect the block size in this case. > > > > Signed-off-by: Dave Chinner > > dd2d535e3fb29d ("xfs: cleanup calculating the stat optimal I/O size")] > > Signed-off-by: Luis Chamberlain > > Something screwed up there, and you haven't put your own SOB on > this. Oops. I will add it. > > > --- > > fs/xfs/xfs_iops.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > > index a0d77f5f512e..1b4edfad464f 100644 > > --- a/fs/xfs/xfs_iops.c > > +++ b/fs/xfs/xfs_iops.c > > @@ -543,7 +543,7 @@ xfs_stat_blksize( > > return 1U << mp->m_allocsize_log; > > } > > > > - return PAGE_SIZE; > > + return max_t(unsigned long, PAGE_SIZE, mp->m_sb.sb_blocksize); > > } > > This function returns a uint32_t, same type as > mp->m_sb.sb_blocksize. The comparision should use uint32_t casts, > not unsigned long. > Yeah. Something like this instead of using unsigned long: return max_t(uint32_t, PAGE_SIZE, mp->m_sb.sb_blocksize); > ALso, this bears no resemblence to the original patch I wrote back in > 2018. Please remove my SOB from it - you can state that "this change > is based on a patch originally from Dave Chinner" to credit the > history of it, but it's certainly not the patch I wrote 6 years ago > and so my SOB does not belong on it. Ok. > > -Dave. > -- > Dave Chinner > david@fromorbit.com