From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E87BC4345F for ; Thu, 2 May 2024 19:44:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5D7A6B0089; Thu, 2 May 2024 15:44:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0CC16B008A; Thu, 2 May 2024 15:44:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FB126B008C; Thu, 2 May 2024 15:44:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 87EA16B0089 for ; Thu, 2 May 2024 15:44:50 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2B42E120F6B for ; Thu, 2 May 2024 19:44:50 +0000 (UTC) X-FDA: 82074483540.05.3FD7A59 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf24.hostedemail.com (Postfix) with ESMTP id 358BB180014 for ; Thu, 2 May 2024 19:44:47 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=RKj2j8k0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714679088; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OXy8uEDsBicvdpHMXfN/I0ThXwxaeNcYWg8FzG7/WXE=; b=23rdqk6hGifZLYEo31l8umck5/z/vDPenQ6iRuVF0uWZDDJ2+WH00HX2pj85j5sH4e7vNX w/fV0RCTANABXZvvkIwS/qPvpBfWFCkEaBX1xeOtlitYP6LrtMo+uCVJrRSGBBj5EwaVQP TTiWLps5ZFs0HPPhXWUCCnMALf7hA6E= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=RKj2j8k0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714679088; a=rsa-sha256; cv=none; b=oy96XFCCpD9knmBLt2JCh9MMre8wc0YZD9ZJj6zRwu8cY62J0BGPtxZA2RLAWd6yZQ3oW7 h7mTqQN44kTgQzgG+FBxEnN1M59oLEogFqNoN4FpcW619oZZ/rKtnJLbMVNoE95SCIPi+o vz2VHM1CqWXTbKq0Sdv70J33yVo1OOM= Date: Thu, 2 May 2024 12:44:39 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714679085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OXy8uEDsBicvdpHMXfN/I0ThXwxaeNcYWg8FzG7/WXE=; b=RKj2j8k0Nh7DekmpDEeLn+xd6MtCVaQizS7d4i2gc5UoTjEk4TTzm6la9XVmXl8SAqJEO/ IUCWXfadEOzwKu0Czqg4iRTr0wf8Tuj9eth1nd0XqWggilEGL5ozRBIYkkgISdS9ahy8ct 8QvhMQCImAiKjCsNraNE2W8Bmy1FxOY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Jesper Dangaard Brouer Cc: Waiman Long , tj@kernel.org, hannes@cmpxchg.org, lizefan.x@bytedance.com, cgroups@vger.kernel.org, yosryahmed@google.com, netdev@vger.kernel.org, linux-mm@kvack.org, kernel-team@cloudflare.com, Arnaldo Carvalho de Melo , Sebastian Andrzej Siewior Subject: Re: [PATCH v1] cgroup/rstat: add cgroup_rstat_cpu_lock helpers and tracepoints Message-ID: <4m3x4rtztwxctwlq2pdorgbv2hblylnuc2haz7ni4ti52n57xi@utxkr5ripqp2> References: <171457225108.4159924.12821205549807669839.stgit@firesoul> <30d64e25-561a-41c6-ab95-f0820248e9b6@redhat.com> <4a680b80-b296-4466-895a-13239b982c85@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a680b80-b296-4466-895a-13239b982c85@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 358BB180014 X-Stat-Signature: uhgrehi9sneyrbmrsx7hb3uoofsifz7s X-Rspam-User: X-HE-Tag: 1714679087-790387 X-HE-Meta: U2FsdGVkX1+GsfrjGwYvWkkQoxAm6s0+ITPGymqJbSuOxDvPwZczevYzgItBdJarnr1L80lG0uBXmZahYF/Pl48UdYKBRasC57KuGaDtzfLZa3QnSWUqH996ps7LAML7WRwp2wNBK001IbFzdibHcIDCcw+7XfCOnvLX746FD+NXHiyLmNxn5S2SdKUloImv68uTUuKes/QosEOWTY0msoChDBJ1x2F70SaXqhd8yk3dbNatoOFs+4PgRQ8FuACb1v1n8T9b3MCGcbrC79/+sZRDeOcnm2O8iHI9MxMEmiL76Oms4r6/yepBqyNBub3y02deDT9z4G7f+hGSlnWsSgsUgiyaPovKUiGNWDNHUs4BKj8htaFM/AZD3wFrSYXi13+yk8JOObAuVa9r/Gd7xUC/xvm8gd75Pa9LZSGHhjc7yJ2IlgVOfDqvGx5h86lmUO/JzSd9AIKHR0tx62dsSVfBeMameEt3W2jQrjqJhSlbI1n7EOEHXXuEBqk4vJkyuTNAkffEIS+nvwKNRKLF4XccSClpHLqFxEkpqGAks3BJa4iOGAnqhit8VAXkkZmpVZ9N5+WO148bW4zh0U20vmi0dbMxWCEMwMJgkncJQms1LLxNVPZqGLfJaYVeONpqR7iJPyRc68P54Q/IrFH2/s7VHAV2zsgVXbXcDekDdUcN01pS0dxoN3TEs/NDv/3ejIL9IXyusRPD7LYrnlTCWn5Ztg3VriwzGvp8ZS1zPLWyoEqD+aV9/iswKvWONFd2JPj842oDOcxoGtBM2xRvjsP+DmDZWGWsestkXxwKTVwAosnYEG/CiAfB0yPxQipMJc4qgaS5JmmLRpIAo6nRGR6Hms5nt5ut1ZNRvUdm6diCLjmw9UqM+oLSZfwOKA6q1DulsHPivW+YlBmwy5fVqKRxmeErLI5PJx8drEXZW+bOWSmdODeWFPr3RCww9IJbj5nOiegqyaKEkg+8USb cITxrbWu HbjimGzQLo5XCwpZMH3qVlXboTDlNfUbOSR1RlodEVac4X2f7uLRFAlFyXHWH0ueHQJfOIYkxDBPlE0PtO1LVTWNgWk7UaPEomlg2biFoUUXnQrSobukNm5J/j70q9Fd9u0Mx X-Bogosity: Ham, tests=bogofilter, spamicity=0.117213, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 01, 2024 at 07:22:26PM +0200, Jesper Dangaard Brouer wrote: > [...] > > More data, the histogram of time spend under the lock have some strange > variation issues with a group in 4ms to 65ms area. Investigating what > can be causeing this... which next step depend in these tracepoints. > > @lock_cnt: 759146 > > @locked_ns: > [1K, 2K) 499 | | > [2K, 4K) 206928 > |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@| > [4K, 8K) 147904 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ | > [8K, 16K) 64453 |@@@@@@@@@@@@@@@@ | > [16K, 32K) 135467 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ | > [32K, 64K) 75943 |@@@@@@@@@@@@@@@@@@@ | > [64K, 128K) 38359 |@@@@@@@@@ | > [128K, 256K) 46597 |@@@@@@@@@@@ | > [256K, 512K) 32466 |@@@@@@@@ | > [512K, 1M) 3945 | | > [1M, 2M) 642 | | > [2M, 4M) 750 | | > [4M, 8M) 1932 | | > [8M, 16M) 2114 | | > [16M, 32M) 1039 | | > [32M, 64M) 108 | | > Am I understanding correctly that 1K is 1 microsecond and 1M is 1 millisecond? Is it possible to further divide this table into update side and flush side?