From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04C27C4332F for ; Wed, 1 Nov 2023 16:16:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85EFA8D004C; Wed, 1 Nov 2023 12:16:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80F9E8D0001; Wed, 1 Nov 2023 12:16:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D6918D004C; Wed, 1 Nov 2023 12:16:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5B9F68D0001 for ; Wed, 1 Nov 2023 12:16:23 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1D412120C41 for ; Wed, 1 Nov 2023 16:16:23 +0000 (UTC) X-FDA: 81409887846.10.A9296FF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf21.hostedemail.com (Postfix) with ESMTP id 2B2F41C0020 for ; Wed, 1 Nov 2023 16:16:20 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="UFpQPg/+"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698855381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pQH+TPyLxgkTJq7ImZfFmxTqdkd4TqoKAvM6ipQOUUo=; b=b0FNPwvJkPpYziLpLwvRn3vEuhYydv9hlMheUc43Zpn5khJhoB6ixow+KWu3o23TwCbPOJ 88k6LYbAd6M+pucVGZbqKPNwbkafOZM/TCoX5yOYNItR/jRzMxg9ureZlDybRV0f7BcWi1 HLfY3SljWL1p1EEaduQPsB+oWKQxBxA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="UFpQPg/+"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698855381; a=rsa-sha256; cv=none; b=RtVb2Y4OrCBCtU9RsWGm3xCPMsdblW1M28VrT5q38Y8nFiRch7DSGdzP+rABR2sIJkUQ+f TVYIsIVlneVqB70In3Q27YRhqa+YO8Z0t/wXoifI9+eNK6+UHGcje7ntiK+hk7hK/acdrR pFK8qliYKiHzAeK75exN6zyxm8+Opi4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8552221845; Wed, 1 Nov 2023 16:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1698855379; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pQH+TPyLxgkTJq7ImZfFmxTqdkd4TqoKAvM6ipQOUUo=; b=UFpQPg/+YgTqTPck4IAwJD/a5ddICXUdHcnvPqAJS3iWL/QPW0OXZgc2QJ1WKFFRZYEghX W5LgqtvSS69Xvtu9m6Sp4e4LFs8fT/3ss6IfF9yMdAid5g7oCu7QOI7a9sALWqLVlkcEAe PSlSnjPY3FAqIEEXlPLScpSR1f5iAuc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C62813460; Wed, 1 Nov 2023 16:16:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id q1aUFdN5QmUqPAAAMHmgww (envelope-from ); Wed, 01 Nov 2023 16:16:19 +0000 Date: Wed, 1 Nov 2023 17:16:18 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Ruifeng Su Cc: akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, mhocko@kernel.org, roman.gushchin@linux.dev, hannes@cmpxchg.org, linmiaohe@huawei.com Subject: Re: [PATCH] mm, memcg: avoid recycling when there is no more recyclable memory Message-ID: <4ljrvuomfzrh3bypphkp5wbdzbkguts2icwoonykwttg2axwtv@oqnwohi52nmc> References: <20231027093004.681270-1-suruifeng1@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rh2j2t53ntltg333" Content-Disposition: inline In-Reply-To: <20231027093004.681270-1-suruifeng1@huawei.com> X-Rspamd-Queue-Id: 2B2F41C0020 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: yyst36w88xp45xr7ko8tb83j9ykj9gfd X-HE-Tag: 1698855380-417794 X-HE-Meta: U2FsdGVkX1+nMIDcZdCdHTOsSE9BCfz1mMFodYwsRKailZqRAK0e2RhTgvYgoD515XSUmth04IeJZE9A+6mnEZVJMk1n57SLfBN9NBAhbNqxdISipyQ0xkwSSQuC93zx+QDbm5LZvg3XpECGQPlbgZvBNJQBpzoyGamIv0MSESUVhL8mEf30bArE8byQNSZlB2dB5xZwuIPd++hGmw2afRDthiTt/26N/cGfjuW2Z6CfW1q/SzUBcrq+T2unF+jFVzDG+S3yOPIpJMfXgAtHgQFCxXphaYcwFiKoqjlMHpDaTawN0gTdivI5X3OwfIAeDBv2ZKC63Xbde+zi+Vejnsae7juW8Kfmc85FTOt2y+5mF/xp0uh0TxXlmbH6Y9shlvqoOrwbZAUvuyy8yBvn2JTAprdO7V8O/2Ff/H6nwZExc7oahtl2dOzyTkjbe5TZx/0UcKc14tvKvM1CEFqrT2JJPloMwuyT5URyy+H9ACZkLAWz/FTJ3ZKShNshaicNlIG/XuR7gTRNnhfwES8+OMooApaKzUPFc5GK77blF+C25wME4SwvOiWSUTmyK5wFmp2tfrxM3aUFaiUGbJf/se13Hq8WvyQ7JKb+MPxspwZwUuMb/oFOxzHqkbqGGiteFJdpx2T728rnngVGWrdgg02Kxi3ng5uQw7WxMbvHdl9e9GB8VytrwzYZYWY5ZUKpxnOP3gAJ/qhFshhVD+sGoBmYZOxfMmDXmJncIZ+UA0CbbD9cGyWrl/syraZbJsLmHL0xT0oRU3jfD77EKW5fbiuz0vLPmN3PQ2qZAp4CXY710JnH+eQSS/eW/wRgAU7aljWior9Z2R0+vINwpAnTOY3VYlJ4j4WqN7gIowVNWhUH+RfW2vMhHFro/WiP0VI7JakvDKQIZhSZdvKLs+rP5ig//RWrT0mZtbpOEhHNJDzMdE4MhEPhKj4b+feNhUlvV2jQy1bK7w0aGbgvOQO YP8NFwDg f+uorG3lk7H5VDy3veWJh8q2JTmmxzikOxqblX6wQz0dHCOWoTpifQBi/VhjvGBnjzZ3pJvh3zGRegwNcaSVmgG5FR6ZHdBt30+e7o0HG2S1VlcU1WS+SpAXlTSJvcbvQfk6645lJl/WAUJQ1pkhez6Nw+Wu5mwMWrt20eaouo1o6hn8PCHtMh4Ydhbb8bFv6zYHRwp4ZYsMQTxJYfuUizC5Y8EWBvHZD7kfzlPO9rTihymP0rscptEZE2Pl+z3MWnDhgAbTptBPyavHa6ZtXHZziJm+zpMsh1a27ibCxQM+En3oKhY1o2xUE9Bk0flp48FGveEDWOwi/LUU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --rh2j2t53ntltg333 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello. On Fri, Oct 27, 2023 at 05:30:04PM +0800, Ruifeng Su wrote: > The test result shows that the program frequently sync iCache & dcache. > As a result,=20 > the number of anon pages requested by the program cannot increase. memory.high can be a tar-pit (instead of OOM). > This patch changes the behavior of retry recycling. What is behavior of your program after the change? And what behavior do you expect? > @@ -2616,7 +2615,7 @@ void mem_cgroup_handle_over_high(gfp_t gfp_mask) > * memory.high, we want to encourage that rather than doing allocator > * throttling. > */ > - if (nr_reclaimed || nr_retries--) { > + if (nr_reclaimed >=3D (in_retry ? SWAP_CLUSTER_MAX : nr_pages)) { So this reads better as if (nr_reclaimed >=3D to_reclaim) > in_retry =3D true; > goto retry_reclaim; > } So it would unnecessarily overreclaim in some cases. Regards, Michal --rh2j2t53ntltg333 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZUJ50AAKCRAGvrMr/1gc jgyGAQCRDYc9FCwcEqEIuYJxggE6SB9RVoQJEJTkIxpo0dB0bAD7BFaOvnsp11sR 1KRFe7l9x++XPZP3HOq1dyUu3hrUXAA= =0+N8 -----END PGP SIGNATURE----- --rh2j2t53ntltg333--