From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D16EC83F1A for ; Mon, 14 Jul 2025 15:23:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 112AE8D000C; Mon, 14 Jul 2025 11:23:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C3B18D0001; Mon, 14 Jul 2025 11:23:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECD3B8D000C; Mon, 14 Jul 2025 11:23:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D707A8D0001 for ; Mon, 14 Jul 2025 11:23:45 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 31742C01D6 for ; Mon, 14 Jul 2025 15:23:45 +0000 (UTC) X-FDA: 83663240010.22.96CA0F2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf27.hostedemail.com (Postfix) with ESMTP id CF9FA40005 for ; Mon, 14 Jul 2025 15:23:42 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=nxdXJQJj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/9owpvsE"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="UEp/JhV3"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8ymYQLTy; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752506623; a=rsa-sha256; cv=none; b=GNfkdg7QEfbSTK2X0i1kVDr4KTpSVVzX93GEtg0db+2oi4IWuI2WXXpZ7cCEItzNydrh2Q eU/ilR+CRY2jsGxNO89hvYRshxLYB8fmT+Xq7fUsxHJPf0Hd7YaNiZTvdNoOrbLcYvASgR Y0KllQsTDddzabb7DPm5xXodwloils4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=nxdXJQJj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/9owpvsE"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="UEp/JhV3"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8ymYQLTy; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752506623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=igW3S1j6dab1xsXokYHODMX9e/lWyaqpQ1rt1YYZsQk=; b=r0MzeBaer+gjsrC0m8itpLNbf5UuMcfEdji3t5SVNipTVan0eN6kmhxAE+XJxk4OcYvjRy QKjhWZgAZ8G/ssubch0fDvXB8gm887eC63bCyg/HjNaGbYkV8jdi7ZyGZ1zk96WKsFFsAw R71ZnUfHcOHJJ1uxqoP8i9zPuAh7H+M= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2E4E021182; Mon, 14 Jul 2025 15:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752506621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=igW3S1j6dab1xsXokYHODMX9e/lWyaqpQ1rt1YYZsQk=; b=nxdXJQJj8Svbg2QZsy1dTnKhb/DemJqit491tiWHBzb6kpWeazsPMS9fw0m/2di9JVWTjW TEzTj0KlZkNB7oRX8VLDDJUhEn3jtuix4cPMBkJmSjyMhlLvcXWX+YdNRLAdgBlrmd/lIe b6su+3H37obswteLZGEqWeDZQRNUxR4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752506621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=igW3S1j6dab1xsXokYHODMX9e/lWyaqpQ1rt1YYZsQk=; b=/9owpvsEpEfkgHwgoBpGw+3Ou7+7kZPs9As4UHtQ5aTM8zfbWr05SnV6V8Xx1zHfOJ4C0A UqSJqr4gfwHGmQDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752506620; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=igW3S1j6dab1xsXokYHODMX9e/lWyaqpQ1rt1YYZsQk=; b=UEp/JhV3Eo6fnkYJquT2iPie8qpvSctmvBTHlFK5kQTd3JWh+uOLX+dhZp3ArCvtptxCZF uRg1MfwG7XLIrXDomaAmd9ub4OvZZDOJjThOULOv5hENmKePYAlP3x4DgLMwboBMaQ3xdt iNkKp8xMJZLeuztWaF6VHQUOo6SshKo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752506620; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=igW3S1j6dab1xsXokYHODMX9e/lWyaqpQ1rt1YYZsQk=; b=8ymYQLTy+zVlB1aU9tSWWE/GbkyceqEVEfsH2itBKo6eNfdl/5+nskJwQJFOPf/Tx9S8Ml VtYsU5Osi1exAPCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 775F9138A1; Mon, 14 Jul 2025 15:23:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uwDeGPsgdWiKNAAAD6G6ig (envelope-from ); Mon, 14 Jul 2025 15:23:39 +0000 Date: Mon, 14 Jul 2025 16:23:37 +0100 From: Pedro Falcato To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , David Hildenbrand , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeff Xu Subject: Re: [PATCH 3/5] mm/mseal: small cleanups Message-ID: <4ivcbimxvtojuvawrxnasgnhbepeohpix6owvm5y5scpyq45ui@3dutrp66wsgz> References: <4df6b55c407b5e6890429d4d7cc39e8f28948975.1752497324.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4df6b55c407b5e6890429d4d7cc39e8f28948975.1752497324.git.lorenzo.stoakes@oracle.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CF9FA40005 X-Stat-Signature: xekp8y81194h9ddjemyxehejhfnexfhx X-Rspam-User: X-HE-Tag: 1752506622-726568 X-HE-Meta: U2FsdGVkX18nLZahCVT5ArEIZDqRbVSNtZfypmUM6sECaCZyofiiGCgoEOs4+Rl++oYuEysVCNhvRVKHHdMMoJUPL7a/xTpoqbUkBD/JBUHPKSxkUAJVw1AtI95jrBgqidqXMeuDyFaFTjBLOlj1VRSaWWO0RD8BCcOYH4wrvQ3weJLQY5RBAbgd5JCKu5Zv2l+VctvwOH/Y/cMv2qo33EhqyziXxSPDq4pubUEd5xO5ewz2/UBB2FCHuMsV39JoaqS3kRiZhRmJxfpMYA4RhjVRVAG+lB3yvRQlqvVEu2GvFGh833uoKcZ+sYFa/46i9MUNpQsQoExDNTil2sYjS04fgbyn7PRQU8yzwhDUK8cnIbLYs05bjkfgBrlJR9HR5UOWEFDQ2YwetmxJu21qCglUrlSPHS8a+St2e8rd17Gu34pPnaEMlhI8+O28Q02YGBaxAoGcaOBlux6gxD2rsTd0xBsuC2UKnERt8Toi8E/cMJU/FPxrKAt2BIzxdfCGeSHbDwJGYdW6kiiiQTnqn9hzXiaF9K511WZrNUPst+GYPbc5/YDXBSsFyEZnG9Mff3anmAk0kyvyp4MYR+PAMTdaSwCE0CvrBTjuhvy0NJD107fM8SxjSFdb/WCoS1O/LAfiKAUM6QAjeGSwhmulFYnku6Zlk4Fcs8LsbAdwCEeO+DshmshFgbZHEU4NBFOB46Npu+ojVxhWpMFp6WrCOj2a2z+jZMTLydtBkE6jlmrcujXR+2ER0XqXq11mge8i3HI1p/mjEX5uZljVXYLu6Ueq3WORFyccqGe8gyx6i++ksJQTih2Ov2TuqcL9a5nPDn5j2iYqfZiMnnQG0cWwuqSUBinjptBocKyz6ztw/VWGUSXf6dylaSQNVhlOERUfA0xunefJqKNe85arcRcYVPpV2W1yCrs8Ymq89n3P3y0T9LCJMNQzP+Yygj+wrvckNeI1EI0b4/MYZ4ylLFV M9881cU4 nl1Tc62mJUVGqzD/qLEa3OjdtVP5Es9yvaFIp/lnT0CUa0c1M1/hNuqG0ZrKor5QjW1mUuufiwGrRtUprOCvBGsBxdb8arxaxra+km/dMz6N95NKkxa9buYY5/k95xxPTNWVkMp1HE4rv63J9MROzSpjSQkD7kxlIEHnUGIGt3DzXArl2zyhYYo+S7q7MaCxjiemWJayJTg4E9Wz/Oyk1kITvRbXzoAkIk3cgQJX/yVTtoGj+qmQZNph+tW1v/Qrt1MNaKF0JsMpY/oRR3NMQOouIR/RNT/vXKiYhhnsuF1FHobVPeE5b5A6dRHysdwEz0SjIRLFOwv7lZcH4qklyAt4J4d2qEHrVOIto X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 14, 2025 at 02:00:38PM +0100, Lorenzo Stoakes wrote: > Drop the wholly unnecessary set_vma_sealed() and vma_is_sealed() helpers > which are used only once, and place VMA_ITERATOR() declarations in the > correct place. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes > --- > mm/mseal.c | 9 +-------- > mm/vma.h | 16 ++-------------- > 2 files changed, 3 insertions(+), 22 deletions(-) > > diff --git a/mm/mseal.c b/mm/mseal.c > index 1308e88ab184..adbcc65e9660 100644 > --- a/mm/mseal.c > +++ b/mm/mseal.c > @@ -15,11 +15,6 @@ > #include > #include "internal.h" > > -static inline void set_vma_sealed(struct vm_area_struct *vma) > -{ > - vm_flags_set(vma, VM_SEALED); > -} > - > static int mseal_fixup(struct vma_iterator *vmi, struct vm_area_struct *vma, > struct vm_area_struct **prev, unsigned long start, > unsigned long end, vm_flags_t newflags) > @@ -36,7 +31,7 @@ static int mseal_fixup(struct vma_iterator *vmi, struct vm_area_struct *vma, > goto out; > } > > - set_vma_sealed(vma); > + vm_flags_set(vma, VM_SEALED); > out: > *prev = vma; > return ret; > @@ -53,7 +48,6 @@ static int check_mm_seal(unsigned long start, unsigned long end) > { > struct vm_area_struct *vma; > unsigned long nstart = start; > - > VMA_ITERATOR(vmi, current->mm, start); > > /* going through each vma to check. */ > @@ -78,7 +72,6 @@ static int apply_mm_seal(unsigned long start, unsigned long end) > { > unsigned long nstart; > struct vm_area_struct *vma, *prev; > - > VMA_ITERATOR(vmi, current->mm, start); > > vma = vma_iter_load(&vmi); > diff --git a/mm/vma.h b/mm/vma.h > index 6515045ba342..d17f560cf53d 100644 > --- a/mm/vma.h > +++ b/mm/vma.h > @@ -560,31 +560,19 @@ struct vm_area_struct *vma_iter_next_rewind(struct vma_iterator *vmi, > } > > #ifdef CONFIG_64BIT > - > -static inline bool vma_is_sealed(struct vm_area_struct *vma) > -{ > - return (vma->vm_flags & VM_SEALED); > -} I actually don't hate this helper... > - > -/* > - * check if a vma is sealed for modification. > - * return true, if modification is allowed. > - */ > +/* Check if a vma is sealed for modification. */ > static inline bool can_modify_vma(struct vm_area_struct *vma) As you're in the area, vma_can_modify() maybe? In any case, LGTM. Reviewed-by: Pedro Falcato -- Pedro