From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B952C021B5 for ; Fri, 21 Feb 2025 22:09:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 923BB6B0082; Fri, 21 Feb 2025 17:09:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AB8B6B0083; Fri, 21 Feb 2025 17:09:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74C156B0085; Fri, 21 Feb 2025 17:09:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 557166B0082 for ; Fri, 21 Feb 2025 17:09:29 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C4C9F1204C5 for ; Fri, 21 Feb 2025 22:09:28 +0000 (UTC) X-FDA: 83145344016.03.223DED1 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf21.hostedemail.com (Postfix) with ESMTP id D5D0F1C0013 for ; Fri, 21 Feb 2025 22:09:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vmI1CpxK; spf=pass (imf21.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740175767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ff7GplsJETsFRnID6bxEAoUm0JuKYcn12o3QxaY57WA=; b=FDd/i2+bHxwUeNclcuUpvs4GOwRZg+i2gvWq2uUKX5T0CGXKbMTDIWDuqeGBfsAylrLfzw 2IW1LLd/W8CscqfWsHz8fQv68JQ+xNu0I+sVXQEDW51iWjl35m6P+08P2kQoL0LqGkT+Wr PjtnU2cEMVh3ObOTTGwDTKI9cHIIXMs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740175767; a=rsa-sha256; cv=none; b=ADWpB/gJRa9IHY002jWZeWhpOqDEO6wONkG+4RaFqLam25w4/3UvfVtWTJTHMNgfMFxGpu 6BANriAY7TrMtcOLCiwLN4GZON51Lb54g4hgCrzlbjl1AcabAdMkUbdz5++vfvJ3JnbTc5 yOqttBJxV0r8Z0pLvRilGwcGhWnqSR4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vmI1CpxK; spf=pass (imf21.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Fri, 21 Feb 2025 14:09:13 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740175764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ff7GplsJETsFRnID6bxEAoUm0JuKYcn12o3QxaY57WA=; b=vmI1CpxKKIjW0NmqLL4Q8ctTxh52z+BUxmjW6O3AyYgd2MNSBZW3rOZ765lrXQLJCF8QJp vRmmOx6jBnk8FEWqRj3zl2cKx7LylktpP/YLpd3pXY4BPGNVa944gi/ed1EhGRhpwxERLO sN8e9H1rLCM1L3gzO/cH1MfuxKZ3ycM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: JP Kobryn Cc: tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 06/11] cgroup: rstat lock indirection Message-ID: <4ifdcruyhsszzpurygsijrlsaea4zmc4g5crgsk4ekevsh7ygs@yqwc6iw2aoyi> References: <20250218031448.46951-1-inwardvessel@gmail.com> <20250218031448.46951-7-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218031448.46951-7-inwardvessel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: D5D0F1C0013 X-Rspamd-Server: rspam07 X-Stat-Signature: m5xciqbt3x5besif9zz4rznw4rr77smw X-HE-Tag: 1740175766-927313 X-HE-Meta: U2FsdGVkX18GHGRpaPn2/IBInYxlnIXwCEi+TSHDGNbEPaMr+vuCfr++Dvj+PUbB6nf5K6OGoHpTuuk9ZeLLa2SHu01uEHLVL3Gxp5Rg/OXAkNzrFTL13CpNYtkbNA7sQUkHOfRlk5Jss3FmX9yhELWzaTpHkrKNI6kCekDx+hbNv4OgCD0NTIJQC77QseJSgDd6veW9+F6u2UIyiNilyjh49qjRgIbDEZvEVXmXzq8vMzltJuMZIXqWUzcDiDBZSS0gsTGN6mOp8uIk4VBWyvbEz5s3Yyo1LW3rhbvUrqWwcqqU/+XxDR5C2FmEeWae4u67Z1YXoZ+SNmn9tnCzU2lSfTXf8a7D/JQaMJPHmvTe65ymGobjrVV6lNJbgpft7KQ/GCdZ2akFItuogoCG88ppv4jOZwe56B10/9tTApsCb0lVwJMu5eLeyUYyNskLL4hIM27NMnJib/xtr1RxjdI8YXPPMxMVnPrDtjYfpLFUV0kBRCQsHMQEm9GC9pwPKCJv+9roqkNkYe1Y3lsuMhdoHCOO4NZcKUeLxwTRFzVMIduviRBbwmfc5b4FiMJ8umRMVhj5tLPbrY7aEVCSUxlT4wSvMILB1wTPl8OaTLWbmaMDCKToJvigmHKihUYxXJtmOf8+hatABeIsZdqmQRXr97Wi099yaORXz88kcTb9uPWRvSCodEwPGRZ1ndqIXj1o0qE1j0CziFfGbP7+lhLgE3tgdpDm7wAPFLMoVKtwxmfjAcESKCI9Yf95GOI48pXuG+ZPqjgh6tmYpEnSrUGjvWf+UJ0/KXy7pW8DXvW/SubpCok2JDSYAj1WNYotZDPfPQ03kPG3V5d2RiGale8Bw0EH4cC/xk9hL6NoVeG8C8yxCR33p5cZdQ6edPgRvPlz6ZTLNLUV2EUz3dTnuwy9hJfyu6pRKZnhFqPSuXtbiagCbIFWS+Sg9N786MUy/jicyZRqy1i+ZJvH49w FnEA7uD/ C6T6vAleiuPu97l0IqqASPXsY/m0Jjah46XZ2MpaS/HO/mO98+3LigF9PeK17kbwdHSeJadrDxhendtFipQSa76BcS7OZ4vLOixckjCGQuHkumD7423u5qbZGs+r0eeQ27qKQgBgMRgV1wkt7V5xvgrlNqLHn1D5mBZ4ai7qK4C+0umbi9ekNERElonZu6RhwADcjyvrpDQ9n3vx4JPW0X+r8wq0NrSvLMVk5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 07:14:43PM -0800, JP Kobryn wrote: > Instead of accessing the target lock directly via global var, access it > indirectly in the form of a new parameter. Also change the ordering of > the parameters to be consistent with the related per-cpu locking > function _cgroup_rstat_cpu_lock(). > > Signed-off-by: JP Kobryn Reviewed-by: Shakeel Butt