From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A14DFE7717F for ; Thu, 12 Dec 2024 12:32:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7A706B0089; Thu, 12 Dec 2024 07:32:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2A9D6B0092; Thu, 12 Dec 2024 07:32:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF1916B0095; Thu, 12 Dec 2024 07:32:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A13226B0089 for ; Thu, 12 Dec 2024 07:32:28 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5730F8196E for ; Thu, 12 Dec 2024 12:32:28 +0000 (UTC) X-FDA: 82886244882.02.683EBD0 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf09.hostedemail.com (Postfix) with ESMTP id DDB0E14000C for ; Thu, 12 Dec 2024 12:32:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734006734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gsBO5WxKdsslM16lsablKAeP36LGbpvDV14FdKQ7d0k=; b=msuhk9qGOs/1goqVtmPISH3KyLtvUXJn9Jd6Uey5b0wZ+mQ4U6+9JcWKCfHESC3tyR28n6 NazaZ+f+K1+PexP483z81LNK5a37pJJHKKUrdH8gFVCPPm97+bUzEkOnoR8UjhBHoTdvII Utb+RVbauKhNBftfucsJfDaidYsmUvY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734006734; a=rsa-sha256; cv=none; b=iox03g/w8MwoxpeR/ypGmHvr9aMO7Aj8Fy8tLFBhKy+NcqSaiqY7N2RxMfkqhMeeTbWqGp 7P5I5W9Uk2dY3POe7a8StIMl9N4/+8e+30Dw30hmLIalMROQZFptOGH4112XnuYJpQSyar 3nq+Da0dYcW006cHYF4hKU2h2ZDAvko= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Y8Bg65WDsz4f3jjx for ; Thu, 12 Dec 2024 20:32:02 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 161241A0196 for ; Thu, 12 Dec 2024 20:32:17 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP1 (Coremail) with SMTP id cCh0CgB3ILLP11pn2HUgEQ--.44978S2; Thu, 12 Dec 2024 20:32:17 +0800 (CST) Subject: Re: [PATCH v2] mm/page-writeback: Raise wb_thresh to prevent write blocking with strictlimit To: Jim Zhao Cc: jack@suse.cz, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org References: <5584d4d5-73c8-2a12-f11e-6f19c216656b@huaweicloud.com> <20241121080531.567995-1-jimzhao.ai@gmail.com> From: Kemeng Shi Message-ID: <4ff421cd-fffd-550c-4598-b79c633621eb@huaweicloud.com> Date: Thu, 12 Dec 2024 20:32:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20241121080531.567995-1-jimzhao.ai@gmail.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:cCh0CgB3ILLP11pn2HUgEQ--.44978S2 X-Coremail-Antispam: 1UD129KBjvJXoWxAFy5CFy3Ar4Dtr18ur1fCrg_yoW5tFy7p3 y7JanFyw4UA3s2yrsI9as7XrWqv340q345XFWkA34Uur9a9r15Arn5KryrAF1DXFZI9ry8 XFs0934xXr1qyaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkKb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCY1x0262kKe7AK xVWUAVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1l IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j 6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1veHD UUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DDB0E14000C X-Stat-Signature: 6fdqgo4fd4ihdheur83c771tasfu83aj X-Rspam-User: X-HE-Tag: 1734006726-234595 X-HE-Meta: U2FsdGVkX18iKSxQrBo+q6P8T0G6uznVT4XinZgiDu3BG2x4B9eJ+XJ3kxkpV63W9mnESxz/uugAtRskYXU0gUBT1WlUrjJVx3RhtNoaYqTfdIuEn1mqCNFZCR3wX/9o9U/PImzWshTvOa3tAEqianvbHEt0K+axCYAWoZS4ifQvRoI0PEcZnYwSsuW4+Of7a2Csq4aGu09vKHQFbOrHoBtcxgxUOwsW1Ym/JXx4Puj4WG9sFuEsVDhlkHez/3ktDSVZJ7WQZco8lHpPZMKe5Xwuz8t0DJ47yJBwDLDJYcjcWKR1gXELxE4k/gTEkK/kMt4GbsL6hmh3YsHkjvtsCa7pjjIv+yBypKnagSrIEwcziA5FQCBTY+l7f5Jhtp2+uTMVJG88jD5OaRPVgDJO1nsPTU0EnuRA9LhYUS3HI3vGDdFtGu88MoOV419CRACFv2kS92g9t6bUIZ8bJdbmjnTYSmq17M6I268HZau+ry/ElN0LZFnyoV1iHPyjZvwjgz2WMJoUfoor/Oe7ih2OqE4nETlHNW8goQaoY72DmYgLh9K0eGSCBY7VmsUYow3syoEiUyLuq/r0PnOLD0fLxGMAPgys8QQTddiFQekckbqtA/ddx4P5jZ2SHrUIA0pNiarSg8Npxgv8nij5EHuLleUGv97JvqDtHyyZDf4utR7hBJJ6k/Vkjy6eVDCfYIIZlLeDC7OGkrfqEHKA/DauBSkebO1X6WqZmNV/xV4gytVVVVziLpC0yqlzvtNnZjaMqCooG96LsXFnQx7/BA8dOYteyTrNV8CZ4U+taxtUhwNBv+spUEwKWjWRcmv4h/PlsSkohjWBXnmvtv9HHxY3LtEJyjSPnHnr1ZN15ed+zyyzJmzWPnpR18q1Uu3QG96Pf44G3wjKjAbpM9i0U6NGgOxsPwOX41M6wAanlqdIQxuHRvAxMZo5FPWfbNOZNCS9lOuL5htvGnC3QH7nVpB +rErn93e aDYjq1RKv/Z2OVvyfotT08Z/GtnritFIirLfgSfAIh0DZROfxGVdVIQd3A86FVfW1B9KSfcnXzTS+T+0mdAssXmzqXOt+7cuNcDVjHJUBI4ToCKKor7Nf/QhzGtM9IWUQ/aIxjolbcwX8oPDY7n1eO0gR/U/bNaf4t2GVLsuyCQRA8oGzGJhIswWqV2yli5TfqCF4Z6ebVXYw647H5OiLEB7088+r+D7FCMJBjcJsfhManMhOse1zicTdAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001510, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 11/21/2024 4:05 PM, Jim Zhao wrote: >> on 11/19/2024 8:29 PM, Jim Zhao wrote: >>> Thanks, Jan, I just sent patch v2, could you please review it ? >>> >>> And I found the debug info in the bdi stats. >>> The BdiDirtyThresh value may be greater than DirtyThresh, and after applying this patch, the value of BdiDirtyThresh could become even larger. >>> >>> without patch: >>> --- >>> root@ubuntu:/sys/kernel/debug/bdi/8:0# cat stats >>> BdiWriteback: 0 kB >>> BdiReclaimable: 96 kB >>> BdiDirtyThresh: 1346824 kB >>> DirtyThresh: 673412 kB >>> BackgroundThresh: 336292 kB >>> BdiDirtied: 19872 kB >>> BdiWritten: 19776 kB >>> BdiWriteBandwidth: 0 kBps >>> b_dirty: 0 >>> b_io: 0 >>> b_more_io: 0 >>> b_dirty_time: 0 >>> bdi_list: 1 >>> state: 1 >>> >>> with patch: >>> --- >>> root@ubuntu:/sys/kernel/debug/bdi/8:0# cat stats >>> BdiWriteback: 96 kB >>> BdiReclaimable: 192 kB >>> BdiDirtyThresh: 3090736 kB >>> DirtyThresh: 650716 kB >>> BackgroundThresh: 324960 kB >>> BdiDirtied: 472512 kB >>> BdiWritten: 470592 kB >>> BdiWriteBandwidth: 106268 kBps >>> b_dirty: 2 >>> b_io: 0 >>> b_more_io: 0 >>> b_dirty_time: 0 >>> bdi_list: 1 >>> state: 1 >>> >>> >>> @kemeng, is this a normal behavior or an issue ? >> Hello, this is not a normal behavior, could you aslo send the content in >> wb_stats and configuired bdi_min_ratio. >> I think the improper use of bdi_min_ratio may cause the issue. > > the min_ratio is 0 > --- > root@ubuntu:/sys/class/bdi/8:0# cat min_bytes > 0 > root@ubuntu:/sys/class/bdi/8:0# cat min_ratio > 0 > root@ubuntu:/sys/class/bdi/8:0# cat min_ratio_fine > 0 > > wb_stats: > --- > > root@ubuntu:/sys/kernel/debug/bdi/8:0# cat stats > BdiWriteback: 0 kB > BdiReclaimable: 480 kB > BdiDirtyThresh: 1664700 kB > DirtyThresh: 554900 kB > BackgroundThresh: 277108 kB > BdiDirtied: 82752 kB > BdiWritten: 82752 kB > BdiWriteBandwidth: 205116 kBps > b_dirty: 6 > b_io: 0 > b_more_io: 0 > b_dirty_time: 0 > bdi_list: 1 > state: 1 > root@ubuntu:/sys/kernel/debug/bdi/8:0# cat wb_stats ... > > WbCgIno: 416 > WbWriteback: 0 kB > WbReclaimable: 288 kB > WbDirtyThresh: 554836 kB > WbDirtied: 47616 kB > WbWritten: 47424 kB > WbWriteBandwidth: 168 kBps > b_dirty: 1 > b_io: 0 > b_more_io: 0 > b_dirty_time: 0 > state: 5 > ... > WbCgIno: 3186 > WbWriteback: 0 kB > WbReclaimable: 96 kB > WbDirtyThresh: 554788 kB > WbDirtied: 1056 kB > WbWritten: 1152 kB > WbWriteBandwidth: 152 kBps > b_dirty: 1 > b_io: 0 > b_more_io: 0 > b_dirty_time: 0 > state: 5 ... > WbCgIno: 72 > WbWriteback: 0 kB > WbReclaimable: 0 kB > WbDirtyThresh: 554836 kB > WbDirtied: 96 kB > WbWritten: 192 kB > WbWriteBandwidth: 4 kBps > b_dirty: 1 > b_io: 0 > b_more_io: 0 > b_dirty_time: 0 > state: 5 Hi Jim, Sorry for late reply. The dirty thresh of these three groups is as high as dirty thresh of whole bdi which is unusual. In __wb_calc_thresh, we calculate dirty thresh of group by (numerator / denominator) * (thresh of whole bdi) roughly, so (numerator / denominator) of these three groups is 1. However, the sum of (numerator / denominator) of all groups is suppose to be 1. In fprop_fraction_percpu, we know numerator and denominator are retrieved from percpu_counter, I think it's because of percpu counter errors make this happen. Do we cat wb_stats and stats when writeback load is low. If so, it's likely caused by percpu counter errors . > ubuntu24.04 desktop + kernel 6.12.0 > default cgroups, not configured manually. > > --- > Thanks > Jim Zhao >