From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EDFCC388F9 for ; Wed, 11 Nov 2020 12:07:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FA85206C0 for ; Wed, 11 Nov 2020 12:07:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XIRHYBrV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FA85206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 992C16B005D; Wed, 11 Nov 2020 07:07:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 943596B0070; Wed, 11 Nov 2020 07:07:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 832036B0071; Wed, 11 Nov 2020 07:07:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 582196B005D for ; Wed, 11 Nov 2020 07:07:55 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 03F451EE6 for ; Wed, 11 Nov 2020 12:07:55 +0000 (UTC) X-FDA: 77472013710.09.mouth61_5303b84272fd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id D9FDA180AD801 for ; Wed, 11 Nov 2020 12:07:54 +0000 (UTC) X-HE-Tag: mouth61_5303b84272fd X-Filterd-Recvd-Size: 3924 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 12:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605096473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g28Vcy6bkD9hVBLAqs39T3DMq7VTyzZfkpQarBjwdtM=; b=XIRHYBrVkKGI310FC8jOyRDyzfsXFhY2R3mTiRQacCkgtPNccoEtMZHyOCV80zzuSnsgQV YfJQh/K6sW5tPO0rezBe49FFQM+bB03y8VEO7rHFkPhD8Ul3Ww8vF1aUI4452GnROWUOKg qh8TlA7Et6UMUYA+GQ9cwMUNOQwOmXE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-38-QKWvvqh9Nw6dyn1L5bqNgQ-1; Wed, 11 Nov 2020 07:07:51 -0500 X-MC-Unique: QKWvvqh9Nw6dyn1L5bqNgQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 73BE6809DE6; Wed, 11 Nov 2020 12:07:49 +0000 (UTC) Received: from [10.36.114.151] (ovpn-114-151.ams2.redhat.com [10.36.114.151]) by smtp.corp.redhat.com (Postfix) with ESMTP id 767745C1C4; Wed, 11 Nov 2020 12:07:45 +0000 (UTC) Subject: Re: [PATCH v1 3/4] powerpc/mm: remove linear mapping if __add_pages() fails in arch_add_memory() To: Oscar Salvador , Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rashmica Gupta , Andrew Morton , Michal Hocko , Wei Yang References: <20201029162718.29910-1-david@redhat.com> <20201029162718.29910-4-david@redhat.com> <20201104095007.GB4981@localhost.localdomain> <20201104120651.GQ4879@kernel.org> <20201104121109.GA5126@localhost.localdomain> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <4fd8b15c-3cbf-0016-69a8-235883c0bc46@redhat.com> Date: Wed, 11 Nov 2020 13:07:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201104121109.GA5126@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.11.20 13:11, Oscar Salvador wrote: > On Wed, Nov 04, 2020 at 02:06:51PM +0200, Mike Rapoport wrote: >> On Wed, Nov 04, 2020 at 10:50:07AM +0100, osalvador wrote: >>> On Thu, Oct 29, 2020 at 05:27:17PM +0100, David Hildenbrand wrote: >>>> Let's revert what we did in case seomthing goes wrong and we return an >>>> error. >>> >>> Dumb question, but should not we do this for other arches as well? >> >> It seems arm64 and s390 already do that. >> x86 could have its arch_add_memory() improved though :) > > Right, I only stared at x86 and see it did not have it. > I guess we want to have all arches aligned with this. The ultimate goal would be to get rid of arch-specific arch_add_memory() implementations completely, providing arch_create_linear_mapping() / arch_remove_linear_mapping() instead (as indicated in patch #1). The x86 variant certainly needs love, but I'll keep this patch set powerpc specific, so it can go via the powerpc tree in one piece. I'll add unifying these implementations onto my todo list. Thanks! -- Thanks, David / dhildenb