Re: [PATCH man-pages v3 4/4] madvise.2: add documentation for MADV_COLLAPSE

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1517 bytes --]

Hey Branden!

On 11/1/22 02:51, G. Branden Robinson wrote:
> At 2022-10-31T22:15:09+0100, Alejandro Colomar wrote:
>> The issue was in line 474, and the issue is that it uses a weird single
>> quote. Please use the foillowing ASCII character for the single quote (see
>> ascii(7)):
>> 047   39    27    '
> [...]
>> I'll report a bug to groff(1) about the issue with the line count.
> 
> Thanks, Alex.  There appear to be some very old bugs around input line
> number tracking in GNU eqn, possibly going back 30+ years.

Heh!  It feels good finding 30-yr-old bugs :)

> 
> I've committed a regression test[1] and fix.[2]  The fix can be expected
> (along with literally hundreds of others) in groff 1.23.

Yeah, I'm waiting[1] for that release to have 'make lint' be usable by 
contributors.  But it's been already proved in this patch set that it can be 
useful to catch things that I miss, even if I have to run it.

[1]: <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/INSTALL#n98>

> 
> And now I see I managed to sneak a cosmetic indentation error into the
> commit message for the second (but not the ChangeLog), where I'm stuck
> with it forever.  Oh well.

:)

Cheers,
Alex

> 
> Regards,
> Branden
> 
> [1] https://git.savannah.gnu.org/cgit/groff.git/commit/?id=7e23e1342077a6d7c0b02c3d666f131d95f2b510
> [2] https://git.savannah.gnu.org/cgit/groff.git/commit/?id=dc98a8b09e7f3dcfe968b978eb210f468db78cc9

-- 
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]