From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BBDED5CC8A for ; Wed, 30 Oct 2024 10:27:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 891406B00AA; Wed, 30 Oct 2024 06:27:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8424E6B00C6; Wed, 30 Oct 2024 06:27:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E3656B00C9; Wed, 30 Oct 2024 06:27:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4DEF36B00AA for ; Wed, 30 Oct 2024 06:27:00 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EDE701A0A7B for ; Wed, 30 Oct 2024 10:26:59 +0000 (UTC) X-FDA: 82729890054.16.64AD5B5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 049D6180013 for ; Wed, 30 Oct 2024 10:26:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MciYac+2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730283887; a=rsa-sha256; cv=none; b=5W0lQOjQSDKoqa9T+eoXg3gL3V5ERbwxBjntS914f8vzWNBJ+k3+GogfA9PoWoiXITUKV+ ubEZe6xdOp6ZHkCAh11oCbzZlWXIrMh9iEck8eJQCIa+n2hogUsZ8YM7o+HxGIsp6JFjPu ClDj42RrWl+6C9wAmfemX1NjF3hf/Zs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MciYac+2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730283887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UAn5PtOTVly2a1DSq3FAj2+pYreXlzFZTwZTDVZFw+Y=; b=b+v28U0Vi8JVrOBvNyeEP5UBe/vUaCGrgz5tBU1PtdkFoJjOe4K8gEWdgvtv9wuZi+Aj/t hodizpyU+gTJb1btEwdBlGGKtjfeC9J+8UHb+hvIr1mN5BFV2M88jzEFowaC7Zny5gRdnX Ex0VqtuBfQHc+SbcB+g4Jbgrk7bt9yM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730284017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UAn5PtOTVly2a1DSq3FAj2+pYreXlzFZTwZTDVZFw+Y=; b=MciYac+28K/jL3Wgw0hlyvdXn0QjRmhCWwOX7eauZVaQWXZvIVdRgmi5Eu5gV03P2GJqCB NkUbh5a/1+zVJzi7F0o7t4ZvzBqjrgUzkbudV/iBLvnqztKJSqWNx5+GDiz8zb6aIsv9+C ezpwx5of3S+CP4DcWMWzHYW5gk0QaaI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-43-oKymyUePMEiThZAHgA3bnQ-1; Wed, 30 Oct 2024 06:26:55 -0400 X-MC-Unique: oKymyUePMEiThZAHgA3bnQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37d432f9f5eso3483287f8f.0 for ; Wed, 30 Oct 2024 03:26:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730284014; x=1730888814; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UAn5PtOTVly2a1DSq3FAj2+pYreXlzFZTwZTDVZFw+Y=; b=iG7l/Ui+3dKksDCCKUklZddwy2nsgGDmY/2L87vDm0Fgk9Rm0hezKTJu5ih7+9y0zB 1bPtwD2agIWinxKViNBYY2vWlfG1H6AgCmr8dn1LiorUQrSj8FYEvcWiU2nSiGq+76SN L477PPZJT69wpOP857bUF+GkZdO0btHdWNpLAwUkPyfAmxM6ZoDRAxocSS85uJIoxKrX Up2e57mFc6z42Zp8jCkM/MNVK2W3ZYwBWEfmqZwGXfb21Kmnl9AreD9lr/KEJlvOM6M7 r71ZuAeu9B1lbhoBVeFcRPcRvROjFQwTXmHAAqe9+6Qgj0TwDXUkLj5GonM+A8sQRYHy N0zQ== X-Forwarded-Encrypted: i=1; AJvYcCWIgoWuyemJtwFZsXvavzuleFffJxKtazZ+/88EkAWQdJlUNgkeLOWCI1wDgtxglN8bKLR29hBbCg==@kvack.org X-Gm-Message-State: AOJu0YxjZIQK9po/CNLU96o8sz34SUlE8niI14Cth+TOlJzoLweLFOac BPz88y82dIUbUHqK84nOoFuZ8HPHuGC1cP47crZWdcsI/1smkqNyl1O2iQRm0oIHEoUH3H17135 DqRgZ/SuFuuORSb1T9aIG/aZz+U/7CHsubynySX9HBO11WbkQ X-Received: by 2002:a5d:48c4:0:b0:374:b71f:72c9 with SMTP id ffacd0b85a97d-381b70762e8mr2234164f8f.16.1730284014543; Wed, 30 Oct 2024 03:26:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhT/7VLXcmPTmel+O5szvYG/3aiGbWANU4AxCfbzCuMCvUvYX6/ZhW7mmaRxnmxOVhlaDgLQ== X-Received: by 2002:a5d:48c4:0:b0:374:b71f:72c9 with SMTP id ffacd0b85a97d-381b70762e8mr2234137f8f.16.1730284014109; Wed, 30 Oct 2024 03:26:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c733:7c00:d067:e327:4f99:7546? (p200300cbc7337c00d067e3274f997546.dip0.t-ipconnect.de. [2003:cb:c733:7c00:d067:e327:4f99:7546]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b92f11sm14925113f8f.101.2024.10.30.03.26.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Oct 2024 03:26:53 -0700 (PDT) Message-ID: <4fae9fa2-dc43-4a1a-af18-ec1c9c82fbf7@redhat.com> Date: Wed, 30 Oct 2024 11:26:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] x86: probe memory block size advisement value during mm init To: Gregory Price , x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org Cc: linux-cxl@vger.kernel.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org References: <20241029202041.25334-1-gourry@gourry.net> <20241029202041.25334-3-gourry@gourry.net> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241029202041.25334-3-gourry@gourry.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 049D6180013 X-Stat-Signature: th1nh4eue6zmaz6k1o6hpx1zp1u8yhdq X-Rspam-User: X-HE-Tag: 1730284013-944083 X-HE-Meta: U2FsdGVkX19PbH2EEL+gH2Uvp3vodLl86/NbNQn+0SFT8leUVeQ945VIXSUyDGt/a7eBtjcyybp3CdmCoqvym9etWUyruTT9+SwNKuxaczWOkV3wHjYTHI8n5x+Bg4gE2Z0X+dTzddUumodSl83axXCfHd0cKVX/Ynsgyz/C9k6o4bxrxwyY3oPvc5Plk/RBTzJETWxFYTUYT2hLPQBzyEuqXMeRcyfp0oZGb3cgNplxWtCFk41xx6Miz+iIKr+8nVkYKkr3KrJZPiiN2ROOdhBjNtzF4PzY6CZW39wS/aMGaQyuqIkwAhUrmRej5SepnSfSHXG/RfpB1ZxfMzunQShxgweK4PHvREWW1oS3A2m3YzaMASdTC5dNKxIVO6ef3CkI1bID9I6HlGe6kMx79fsU4HtOlA3JnO+DU/7Jz55oL42FDw6+ZHbYJkWaWvY+5Uvcx9P9duFifqufMkb+kNzqQPU2WK/xnmgK5cNIpcu0aEH7blDkhQEdViRmqmNWGXXdcQOZCt/69H3ofCG7367LCaV425qZuwY6o15p22PmGpu7M9n5WvbvCaBmB47gSXHWLq8PmM4vO9iODfyLHwJ/3xa4Gp3YxuNzAYawxDCeawxyfvlitODZa39f+U+m/HTI4SEeZpM3nxDNN//DXd61ij8GQt+Qgbb0RH1MIrvaJmsLmjYzKorGCwKw6m7ibCVCMjsRjFWDQRwYPHv96tIe0BPYn+8iaOWVM0DOui70zJ/uZN2XzVpD+oUtk0dAgq2biJxWLvI37npHsVpHvNGTuvk5pp7qXXpU5U+Z+1QSm6gfvq3ZgUEd3Ibtosky5oWzynINMB6rz7dmJumFmcFMDm5yH8YnBvqbs6aeSA1kmBJgQz4KF7IVW7GhCDJMFpdBwnAuWL4twkyFF0d378oOTh2i8/dprdev5icq+iWjR3okJZzIp6AyxBNcMexJef52CkQn0PFrMF+ARyb skWbV85g aO3ZuXfWxa8UWF/Uo0t1YZIs26zwIT5EKdIRAGprTYdb0H7bhxJV6i7ORFRe5qDnRnRrrLqqfPa9RXVjUpKstE5O2lHximfCB5hyWyJZWedsELyLlnhCQcOu4Rb1utNa1Ck3J0o1tkxp0sHoonFFmeEFE47KiJ6+vPWFu0Nmn9ta+ruZNKQ7TndaEoP2qrIM6FkJ3y8AyRoz9nGEN2XJYmZh1X1++lVwtwDLpZpe7zVbEH94k09CwzofOmz9TxVeyB8EAd7SBLIFxBG7rggZluOHUp9jWKAXg5fGUkYMDbi8s7pI+YleiaZcSyK2vqwQPD2FFqLDv0i3IJGlwyvh+RcxWC56Lw/sgnyIIY+lVnJcWzU8n8x4qwki75lSz021Ws6uNDpOPaGqD4+gDJ/Zm60l4RRm93UmBZEYsVu6WUMSHtioLNF3ZfnvlIkDQowqregdj40AUAwJ91lFWrXAr5BKSmrQZ+MrV/K0T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.10.24 21:20, Gregory Price wrote: > Systems with hotplug may provide an advisement value on what the > memblock size should be. Probe this value when the rest of the > configuration values are considered. > > The new heuristic is as follows > > 1) set_memory_block_size_order value if already set (cmdline param) > 2) minimum block size if memory is less than large block limit > 3) if no hotplug advice: Max block size if system is bare-metal, > otherwise use end of memory alignment. > 4) if hotplug advice: lesser of advice and end of memory alignment. > > Suggested-by: David Hildenbrand > Signed-off-by: Gregory Price > Acked-by: David Hildenbrand > --- > arch/x86/mm/init_64.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index ff253648706f..01876629f21f 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -1452,16 +1452,20 @@ static unsigned long probe_memory_block_size(void) > } > > /* > - * Use max block size to minimize overhead on bare metal, where > - * alignment for memory hotplug isn't a concern. > + * When hotplug alignment is not a concern, maximize blocksize > + * to minimize overhead. Otherwise, align to the lesser of advice > + * alignment and end of memory alignment. > */ > - if (!boot_cpu_has(X86_FEATURE_HYPERVISOR)) { > + bz = memory_block_advised_max_size(); > + if (!bz) { > bz = MAX_BLOCK_SIZE; > - goto done; > - } > + if (!boot_cpu_has(X86_FEATURE_HYPERVISOR)) > + goto done; > + } else > + bz = max(min(bz, MAX_BLOCK_SIZE), MIN_MEMORY_BLOCK_SIZE); Nit: coding style want you to use if () { } else { } -- Cheers, David / dhildenb