From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Anshuman Khandual <anshuman.khandual@arm.com>, linux-mm@kvack.org
Cc: steven.price@arm.com, Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Marc Zyngier <maz@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE
Date: Thu, 13 Feb 2025 08:38:39 +0100 [thread overview]
Message-ID: <4fa83d76-117f-41bc-9137-676fb0c204dd@csgroup.eu> (raw)
In-Reply-To: <20250213040934.3245750-5-anshuman.khandual@arm.com>
Le 13/02/2025 à 05:09, Anshuman Khandual a écrit :
> Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP.
> But generic ptdump gets enabled via PTDUMP_CORE. These configs combination
> is confusing as they sound very similar and does not differentiate between
> platform's feature subscription and feature enablement for ptdump. Rename
> the configs as ARCH_HAS_PTDUMP and PTDUMP making it more clear and improve
> readability.
For me GENERIC_PTDUMP is more explicit and similar to GENERIC_IOMAP or
GENERIC_IOREMAP or GENERIC_GETTIMEOFDAY: The arch provides the necessary
helpers to use the generic implementation.
For me ARCH_HAS_PTDUMP just mean't that an architecture implements
PTDUMP, it doesn't mean it does it by using the generic infrastructure.
For instance, arm32 implements PTDUMP but without using the generic one
so I would say that arm32 has PTDUMP and expect it to select ARCH_HAS_PTDUMP
next prev parent reply other threads:[~2025-02-13 7:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 4:09 [PATCH 0/4] mm: Rework generic PTDUMP configs Anshuman Khandual
2025-02-13 4:09 ` [PATCH 1/4] configs: Drop GENERIC_PTDUMP from debug.config Anshuman Khandual
2025-02-13 11:23 ` Steven Price
2025-02-13 4:09 ` [PATCH 2/4] mm: Make DEBUG_WX depdendent on GENERIC_PTDUMP Anshuman Khandual
2025-02-13 11:23 ` Steven Price
2025-02-13 4:09 ` [PATCH 3/4] mm: Make GENERIC_PTDUMP dependent on MMU Anshuman Khandual
2025-02-13 7:30 ` Christophe Leroy
2025-02-13 11:23 ` Steven Price
2025-02-14 6:49 ` Anshuman Khandual
2025-02-13 4:09 ` [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE Anshuman Khandual
2025-02-13 7:38 ` Christophe Leroy [this message]
2025-02-14 7:17 ` Anshuman Khandual
2025-02-24 11:12 ` Christophe Leroy
2025-02-13 11:23 ` Steven Price
2025-02-13 11:49 ` Christophe Leroy
2025-02-14 7:26 ` Anshuman Khandual
2025-02-24 11:13 ` Christophe Leroy
2025-02-14 7:19 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fa83d76-117f-41bc-9137-676fb0c204dd@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=steven.price@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox