From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1142DE7716D for ; Thu, 5 Dec 2024 15:24:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E564F6B0107; Thu, 5 Dec 2024 10:19:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C4586B00D9; Thu, 5 Dec 2024 10:19:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB64C6B00F2; Thu, 5 Dec 2024 10:19:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 19C2A6B00B7 for ; Fri, 15 Nov 2024 23:59:50 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 785EEC11DF for ; Sat, 16 Nov 2024 04:59:49 +0000 (UTC) X-FDA: 82790753598.08.DA8CA44 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf13.hostedemail.com (Postfix) with ESMTP id EA52020007 for ; Sat, 16 Nov 2024 04:58:59 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HVUkc3kD; spf=pass (imf13.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.210.193 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731733010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RgrsO90Q/kQR5moYmJrLgREwrffHDZ1CRD5mltXd304=; b=xDAVTaWGV006YjHXpzswEb35/abeHIy4UEjNtSjUifSqKHt9+Gd+RpKVbvgWfcq9Rz57/X XPOzy7qt4NnXEwomLQl5bjUOAfwpinw2/Tq3cs1dRe73PhxC9zAHY1tUA4HDHpxBQ1tc12 vqfq2jH6WcNLxiU/tbaMYBTBaRxCnP4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HVUkc3kD; spf=pass (imf13.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.210.193 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731733010; a=rsa-sha256; cv=none; b=O3QOqQCzB408CBbIQqwhZpj7LsjTQieF9qpDGU0YJIjm/ogLegOCUSFLHjqG9CTIfajq3p 2hLqFe33QBCt9zuyDZ5bWPAIgz5gnbcNNRpc1CDmRx/ioU7LskQ/f6KkrYIRisYL5uDfgD WMT9V3k3ChpilD00eFNzQf8QRL9Yq7w= Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-71e52582cf8so207166b3a.2 for ; Fri, 15 Nov 2024 20:59:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731733186; x=1732337986; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RgrsO90Q/kQR5moYmJrLgREwrffHDZ1CRD5mltXd304=; b=HVUkc3kDdYH69nzjwo11g45LbpOVpa1J7c7zuBMqHEhcmfaiz1t+3PDD1Ptb7HBCWl Qy0jjRW9d14HccvdP+aB92c7IIjLc0ywjJ6sFOC0gXWc/lqWq2jNmYD3eIPQG3iytFcr TAn3W0lSnxt1QnUKSG+lLHhX0eoIgf8JAhkpIdmhvdoP+oBazqNcY6VGCFK0eLixzDag gIJ6josPjztpAVu9uq6KR3FCYB9N/ihqAkbMfFjwCMF02e0C4thx+ohfoaIDDrPKMek1 Gf+TS6rVoxQbn6X40tV3Y2tZtfySygWRgggtrvEzYHKmHAntpWA0O1GE9Kx5ZsMsaX0R UyUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731733186; x=1732337986; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RgrsO90Q/kQR5moYmJrLgREwrffHDZ1CRD5mltXd304=; b=rlpAVENtO/uIWdozR8vZuUWscheX/ix9I2CgSll2rJK7te+RNef+CRW3rKVtWZvFjM Q+3WLJOvDjU5CQ2q96OijhfkcpwK6JVrcrwKsrR3EB0Sw5mKBKzvxuDJaHqPohz96hFG rPvrjz37eKkTBMnL8co7M1BDrmo1K/aSdNaxUUqdsH19XdGliPwsAFurSu3jGnKpcbn+ Ugx4y1tdJ/R2Cw28tnM4dcFCETjtzbX/Zs9PSDqz9CqrHJW3HvvFUWlw0R10ebfP3iC8 2j7rOiuHR3L5GmzXvICJwYzqjHdByOfyn06S1RRtw5Wt8n9tF4wZT+rnRAmRLXbL28o+ p1vQ== X-Forwarded-Encrypted: i=1; AJvYcCXMmtd9JhHVLM12oitKHMIkLK3y9rNGVdG9CCsPInbb5lOPrM/GJq895xVvJijg0RvpHhmeaMSuNA==@kvack.org X-Gm-Message-State: AOJu0YwyOqfj2HPN9QpmXfDKUiDFCMPykTQYI9wG5hF7+hhIv0zVe0mp q25WT++ulp8MyPBHqjhzdtx3ODBi/Ol/dSyYMQlkCMwg+JFMR3hc X-Google-Smtp-Source: AGHT+IE5OsztyYS/i0shTpCRiXJrtm/VlhUWHJatf18eVJCCA1Zt4i7TUBq8iVpmMCYTd74EAitrVg== X-Received: by 2002:a05:6a00:18a2:b0:71e:2a0:b0b8 with SMTP id d2e1a72fcca58-72476b728e7mr6452195b3a.1.1731733186166; Fri, 15 Nov 2024 20:59:46 -0800 (PST) Received: from ?IPV6:2409:8a55:301b:e120:1128:c4a9:977c:8412? ([2409:8a55:301b:e120:1128:c4a9:977c:8412]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72477139130sm2219678b3a.85.2024.11.15.20.59.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Nov 2024 20:59:45 -0800 (PST) Message-ID: <4f9de1ec-8679-408e-a2d6-5baeac1618d6@gmail.com> Date: Sat, 16 Nov 2024 12:59:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v23 1/7] mm: page_frag: add a test module for page_frag To: Mark Brown , Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Alexander Duyck , Linux-MM , Alexander Duyck , Shuah Khan , linux-kselftest@vger.kernel.org, Aishwarya.TCV@arm.com References: <20241028115343.3405838-1-linyunsheng@huawei.com> <20241028115343.3405838-2-linyunsheng@huawei.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: EA52020007 X-Stat-Signature: rco1fgs9731kfx4s8b8gzubuw8ybbqjw X-Rspam-User: X-HE-Tag: 1731733139-105570 X-HE-Meta: U2FsdGVkX18ZDj1+uradmwc8aK5O+Os5x79XFzkvSF3yIhUaUsBJ9g7vB+4AgPyeVcJGmzu+jPzrV5JXzR2TWQVLNfS8ZldWHxcf3AOIILOuTny+zlbJOiE2rUy6SKrP5SxHCteqoc3laWPE1NZ0nic0eXGq4/TV03M3hboT3FGzhI3A2CgEmbfRGtF7Sglxec/lS/Qi3AOCw4BG/E7i8snjtU09lqPGiCfgQu3scykRwXnnvDkO7WIX7DfGMnn97iwc4/6oo0a+tx0uJNsGNyTgFZvmd2DdWCqucdmozkowUmFWm/r3qyzHuoIV3/YSua+JxE8t+T+c3dqXmqOkyt8qS4ABCroeQbHhZY3OrtY+jNO4tUmWbRRYIQkkAu5Dy1y03DRHqHrRPLEi0wPI5L9rNm29Kybyh9k+8YuDWJ5hDF61ZZmVSR1Xb8uyVPoKXjO03zq+fd4oaBGF0K/JOmZHZvtxNTuhyLKT7zUCkqHoyn2iDYo+0dFM0shG4LdTJpMDszFHjYlMosTrdA9ZxpTsWqAucCxf+s7/K7a2nMsFp7L8rK930v2StE8AvnKk0P8pxWXbeARM0au6DKlTbdO5qpHRrJOqfOtx0u8PqLpn+w+reVmwp7CFBsxtGISMJVvmQ19qzYNsLUkR653QkFdhO0kbk3WrZgPbcdEuXZj78uyVXE57ulZqaJOkJqhP3exG2zNTgjTc0EzXzJypC3ZAwQykPCKCAWPIEBENuNfj/vTKtRpH1jlySwzYtxXWhxPDQLIQcmYAs8Xw9ZxZNkDxPLJIqajgCuRjSWnVNCID4CBkbjbtBuF1VvtmOYwIvYs0UqIeKgC8J04Mj1dNLu9ZyL0q05ekRz4ucUsqH1mPjcaMauTUSbbZACTFgfmXhAptyZC2v+K7y9wXfV3cU+93KcqBwbda2VMaXbp8dBrqAKTNEGD5v4JKGhXYG+rXiYUx3owt2Ulc7SvMYmj F44dhU11 Eq2RYZKzWgx45wbu/FvlEA/u/lyYI0MJJ9s2AGzDStBVxP+lXn3jlSRobZTCW/ScfI7MZ2igCaxN/hsKH95S7GIL/LFnokSj2CV94XyUE9aHH/aRFXHTpN4OWMEaAmzzTdX9ZtFy2KZZfM8s3vFRbUU8iOR7PqPxP5iFpIOz3uSeP+i4hTYk8e/ErGcD8yB6KZShxZDcEHYftNy8EkY8Z3aSjeg9t3GGwytGs6JkoS9XEJC0jh7c8l7bkhkO+V2rf0vVFrb8wyH/GFA5LQ+Tl2cEb0o6jIJ6UI3z5JPkyFlLFY/niJKiD5N+J106j/jRGPUdTg950v5lOu/JlY0RYVdn56x4HVDlQkeicdZRK52fOWUekxDgWpC3671GSOrzh6FtIE8sLrfUmqFcH7uzB7lptqFxA2Ktxie6xp7jb1KQob7jgtdwBo+G2X0pzlPP+h8OnkZ083zgILc/qCnOJHdNlnrvbU2lKlGjpSoJLTVspYqBq4Uhcc76fIBPSgDfpkktH/zNJLx6fTjlw21cSKBHKz5w4+y/Xf7QRNuoEDvckpq7dn7/47iAztBgPmZtmmHHp8Z0Bz/WT3pWNlmNAZGMdzMZW6ivxpWNWVz8Qhqus/5MP6+YKGhBtRhU4Xq/+VK943eKb7EBpKjIoxEFZO3V4Q61h9vyAKjFPrASW4D48Jtmqte25Jh6e4Q3oI/j6XBDA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/15/2024 10:12 PM, Mark Brown wrote: ... > >> make -C tools/testing/selftests/livepatch/test_modules/ > > Ah, this one is actually using some framework support for building > modules - it's putting the modules in a separate directory and using > TEST_GEN_MODS_DIR. Crucially, though, it has guards which ensure that > we don't try to build the modules if KDIR doesn't exist - you should > follow that pattern. Will add a checking whether to build the test modules around the TEST_GEN_MODS_DIR setup to avoid rsync copy error when the test module compiling need to be skipped. > >>> in the main kernel tree and enabled by the config file for the mm tests. > >> As discussed in [1], this module is not really a vaild kernel module by >> returning '-EAGAIN', which is the main reason that it is setup in the >> selftests instead of the main kernel tree. > > Sure, we have other test stuff in the main kernel. > >> As above, I am not sure if there is some elegant way to avoid the above error >> in the selftest core, one possible way to avoid the above error is to skip >> compiling like below as tools/testing/selftests/mm/test_page_frag.sh already >> skip the testing for page_frag if the test module is not compiled: > > Since the tests currently don't build the test systems are by and by > large not getting as far as trying to run anything, the entire mm suite > is just getting skipped. I just sent a fix for above, it would be good if you can test it if it fixes the above problem. I tested it with both latest net-next main kernel and older host kernel, it seems to work. 1. https://lore.kernel.org/lkml/20241116042314.100400-1-yunshenglin0825@gmail.com/