From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 531A3C61DA4 for ; Thu, 16 Feb 2023 09:05:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF9966B0071; Thu, 16 Feb 2023 04:05:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A82B86B0072; Thu, 16 Feb 2023 04:05:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D50F6B0073; Thu, 16 Feb 2023 04:05:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7BAC26B0071 for ; Thu, 16 Feb 2023 04:05:37 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4E5CF1C6B09 for ; Thu, 16 Feb 2023 09:05:37 +0000 (UTC) X-FDA: 80472571914.15.17D5329 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf02.hostedemail.com (Postfix) with ESMTP id D9E1980027 for ; Thu, 16 Feb 2023 09:05:34 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=tQkEnewX; spf=pass (imf02.hostedemail.com: domain of schnelle@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=schnelle@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676538335; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bxNkA3ggBvcUfThISmViaKYT+iTgOdvYOa+mzjEjusc=; b=4zA4RbIgfk+693b7MyQfhJUxRdKtok43L/ZcSBkPHsRSUbQqI2HeGgyy1GB4yqV8U/zJO6 t06O4aTGBd5eZcZ1EaeVq74kXi9X3DmkLJkep4PYCOt1uF5j4k/HwzQtJkaND9RJsnMApX mJDF7fhf11zMmauLkK2liRCXvlpX4Fg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=tQkEnewX; spf=pass (imf02.hostedemail.com: domain of schnelle@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=schnelle@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676538335; a=rsa-sha256; cv=none; b=r98yFY+B2oiXR1R/0RrLdv/4gnwDFxoadzsUJHvJlfABKNczbYkMgic5E2zOvnzA8IHprA Wpoj1zfyp9M0dU4X4fUSk6J1X15E2jIkiQ7MqM7ro6OqsIVbgOsiiKSsL1hy9vUTUtmI2D tVngx7u03ySKxWYqPgk7n+9LTgh9NLs= Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31G80oHF023410; Thu, 16 Feb 2023 09:05:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=bxNkA3ggBvcUfThISmViaKYT+iTgOdvYOa+mzjEjusc=; b=tQkEnewXmy4rlU2m1yZ0q5/L9rgjdzXx3Wp9oMP+64jMA5XpgLjYgckdphD3XOLjraZG k1VQESWluUvdbia4Djq+jOV4AsKdB/G3w+ZcG66CU39251HR1XMaeNTKQs5AkToWuJjd cbde/9r3mQF4AmM7d+YzU+T1V37BMThvIeqp8Oa2O7qdVe4wA1qW9/AZrrBOnEbHRmWB 5b5Tt1RtFQ8rs1KuChUi6X9uaRi8rnbY4Hp12bWM03tc52o5FnggUNPq2VTGzlnMGB6g gWPUq2r3PyYcSFO28/RcMOTmsIi9Fm70Sl0wIr+tjAgFqNRh1U8rTOHeAy2/PXwYevj1 qw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3nsg20j7bv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Feb 2023 09:05:20 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31G8mJNw015743; Thu, 16 Feb 2023 09:05:20 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3nsg20j7b8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Feb 2023 09:05:20 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31G62fbW011341; Thu, 16 Feb 2023 09:05:18 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3np2n6xe3j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Feb 2023 09:05:18 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31G95Gw423855446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Feb 2023 09:05:16 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 04E3E2004D; Thu, 16 Feb 2023 09:05:16 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D6A320043; Thu, 16 Feb 2023 09:05:15 +0000 (GMT) Received: from [9.179.9.244] (unknown [9.179.9.244]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 16 Feb 2023 09:05:15 +0000 (GMT) Message-ID: <4f98164406cfd6da084f9ef617a6668dc4e8d44b.camel@linux.ibm.com> Subject: Re: [PATCH 1/2] pcmcia : make PCMCIA depend on HAS_IOMEM From: Niklas Schnelle To: Baoquan He , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-s390@vger.kernel.org, Dominik Brodowski , Arnd Bergmann , Jonathan Cameron , Linus Walleij , Thomas Bogendoerfer Date: Thu, 16 Feb 2023 10:05:15 +0100 In-Reply-To: <20230216073403.451455-1-bhe@redhat.com> References: <20230216073403.451455-1-bhe@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) X-TM-AS-GCONF: 00 X-Proofpoint-GUID: zhEkrqVDtqoRkhJPFlbizQg060DzzFf6 X-Proofpoint-ORIG-GUID: 3rSsY-_OSPADG3bu-7TtAPa3U2UmSgrI Content-Transfer-Encoding: quoted-printable X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-16_06,2023-02-15_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 suspectscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 clxscore=1011 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302160075 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D9E1980027 X-Stat-Signature: 93hqujcbikrz9iokhq7p75fh44c8qzsm X-HE-Tag: 1676538334-254627 X-HE-Meta: U2FsdGVkX18+MGY2nP6aKlsImJLEhhe15VxyWYMdx5qoox4qdbAiMwuMUix3cz+eOJHkk4IjWVeKdkz8UVca03iwxIH7dLWKFSs0+qqTfoKJ3IurXzACj3bEMCHQrL3CIlEHlVxlpUsNqRMOMNfITQz9+QgDEbZWz08l8umbtQTpEu+57vdC2MNWEP7XwILHqHSjwRe1+C6Za3MtrBJXQKnLceurqwnU6Fz8PZpEbiSkv148hbpHWCtxeQYRte9AIRN2pz+5UiOdbHmqlw+yLPZGKzMHxeSLd3KyflPcpmIrXPPo3RQffFlkCh5xoPozRCeSSQke9aiVJdCnhnb+9XAfoA2iqeo51ZrdUvR/vgffxp9sp+R+TyZ20yQawd1pMlZRaHh+jzr9ecDU8J1ywaYbhiB7R6TBnc9cT+uzwTaFd7ol5iV2PBh9d35dKCkozEkkkjovKP+VRzYWtx9VDn7fIfaCafB9k6VIv63wMaSDrPFgVz1zsSdAMR8oIqm0rLeeJWLy5vkDUZo5V3P1bEZYw8GDURaMAeGsFm0RRnTwgTZJGE4daix0LOwawCWUXl8KDRjNHYfNK9WYULmqBZgPQ8287PfZtjzVHcQ42c3TVWSo9+n7dHNRkipNfqGQ74NyG5tJ39DYD+9iZfr3Wm7GWRaavqDIBqPeugsO0iDUucnUqL1tiPht3bBF1eTw2dfmoKpjI75uvxNKV2J1SwR62dU01W0jKezqEedkH3+RZiuv72rq0tSs+YaqTRu4NI5Itoa0IRgnN34hJu5U5VSNS68Dm54YiP0BeHOVe7FhfYF8h1ZN4i9OY2Qy3ggQmPEpZuX417VGjhYAcSN2YC91Oq9CrAQN6gWTCxJ9tbPptPLotMyVBMz6E6OW7NtDde0V3WfBqYdLn2zVCLj/kWWkA+Mdq18Dn4eh5IGOHpKtpNH551IsbVtQ3Kr6C0ihMIw8KesuxKbSiRRSy9G N9E1xOR/ Lws0mgnIEmNEScoYaVu+gBB9zOLE5SS8ryH3vxIziC6dIlJHd4rdy13rOb75X2Dpr+tiGcPWX82H2Rth9GQt+uXgySKODOLdeaGYlq+g8hjOCRYvUntkLxhGYW9Ugol52u0JAdiwST30vRZ1Q6vlVEK/djtGcPsfgVY0ruTmles1FNxOKiCPouB7fTzgW87SHF1nFr/40SWQK6WhACHhtWXJX1s/NF/Ff4DjQTtOoxXGJhDPT5+CUdQs52MTvrzs+9SwYx0hrPag4TEBKdZJBiOLTEGEhDc3MVeSMm0BH77eTA6w0fljxUJM0kEDrtP8vcZXLa0OYqOGh7ZieqloUNycP7S+wIG+ApT4JUH5HOIy+AfOXFZVlEeT9RB00WTupWwWou9opDN2ST2QC32yhz2DIeWxD+o/BUZBE/v2xLSE37e8UjFzuJsjE2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2023-02-16 at 15:34 +0800, Baoquan He wrote: > On s390 systems (aka mainframes), it has classic channel devices for > networking and permanent storage that are currently even more common > than PCI devices. Hence it could have a fully functional s390 kernel > with CONFIG_PCI=3Dn, then the relevant iomem mapping functions > [including ioremap(), devm_ioremap(), etc.] are not available. >=20 > Here let depend PCMCIA on HAS_IOMEM so that it won't be built to > cause below compiling error if PCI is unset. >=20 > ------------------------------------------------------- > ld: drivers/pcmcia/cistpl.o: in function `set_cis_map': > cistpl.c:(.text+0x1202): undefined reference to `ioremap' > ld: cistpl.c:(.text+0x13b0): undefined reference to `iounmap' > ld: cistpl.c:(.text+0x14a6): undefined reference to `iounmap' > ld: cistpl.c:(.text+0x1544): undefined reference to `ioremap' > ld: drivers/pcmcia/cistpl.o: in function `release_cis_mem': > cistpl.c:(.text+0x3f14): undefined reference to `iounmap' >=20 > Link: https://lore.kernel.org/all/Y0TcaZD4nB1w+mAQ@MiWiFi-R3L-srv/T/#u > Signed-off-by: Baoquan He > Cc: Dominik Brodowski > Cc: Arnd Bergmann > Cc: Jonathan Cameron > Cc: Linus Walleij > Cc: Thomas Bogendoerfer > --- > drivers/pcmcia/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig > index 1525023e49b6..7c412bbe8bbe 100644 > --- a/drivers/pcmcia/Kconfig > +++ b/drivers/pcmcia/Kconfig > @@ -20,6 +20,7 @@ if PCCARD >=20=20 > config PCMCIA > tristate "16-bit PCMCIA support" > + depends on HAS_IOMEM > select CRC32 > default y > help Not sure how many PCMCIA drivers only use I/O memory but not I/O ports the latter of which are badly stubbed out on s390, though at leat they compile. I have a series on that part that I intend to send a new version for soon=E2=84=A2. That said yes this does solve the compilation is= sue and there could be drivers which rely only on I/O memory and are not broken in principle. Reviewed-by: Niklas Schnelle