From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C571C25B75 for ; Thu, 6 Jun 2024 10:39:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76C386B009F; Thu, 6 Jun 2024 06:39:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71C7E6B00A0; Thu, 6 Jun 2024 06:39:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E43E6B00A1; Thu, 6 Jun 2024 06:39:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 39C4C6B009F for ; Thu, 6 Jun 2024 06:39:37 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B8D5FA1CD9 for ; Thu, 6 Jun 2024 10:39:36 +0000 (UTC) X-FDA: 82200117552.15.386ABB1 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf21.hostedemail.com (Postfix) with ESMTP id 8B3521C001E for ; Thu, 6 Jun 2024 10:39:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=LZ8Nor8T; spf=pass (imf21.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717670373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=83HuCPYuInbWx+Tx2DSeqli79HhatsS7dXTsSOuX/yA=; b=htmToaq3d1O4hPdZid2mY+du6O+EtymZ2bPkDqWOkNUyzApV5zZSoFfKqUTjyrGZ5Wu+eR K+gJT3CmTdbkYhsdJObL8lVVIX3DvDLzL8ZedDp/i5y3GoFtadSJmCiQ4ck/rHfLmNKNGz +n4QMamQCBEis0lYcIWQQVIYfOVNRIg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=LZ8Nor8T; spf=pass (imf21.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717670373; a=rsa-sha256; cv=none; b=vuFg7hf5OSpgKUYRUw0TDsbnyPWolSEaHLHfMKdRDJqnj419UmWmfyttB7RZyQ6xwR3QvT Jx0ZNhfpv92Dp2FKmzQjT3Fz8iPTqD+B/dYEc5+3+6X6CLf7tHIFkuoCK4v2993oevDcaL xW6tkXRTaHq0WxFRrbYgw4LRWYjEdgM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1717670371; bh=D0uunvsoqzLWPDiha1RwJom/MhZWK4E2NrSHDqVy/Ck=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=LZ8Nor8TvPK+ZdBUExhw0FqgdlmpE2nc5iWn4+ZbaJKbQf5ejCTkOR0lqbPQrdrfz zVbRSMty8z/GVB0lioNFVDSwJQE6AeO1zMcU4F7VXUEOXXh9QwvYadV/1UlApEl6vQ vw19Lx7Kbi61E48WXpgqsBJkXETyjZHbFfwv0IHtMtfGTUz0YPZOY4BuCBABM2BGFn coisQyjDD4KkLEcpqTWBxAU1+BB+KEe6rnzyIKIdYpCROrAjWx3Q5mVZMJSfiAoNkg XQZ0nKf9B8Gztk9OnxXD7JDMYJKTmkzoy30HxEq36xCOvW+fcNVL8z22BE08KNddcI 7Qg3iqFjkUMAQ== Received: from [100.113.15.66] (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 82C303780627; Thu, 6 Jun 2024 10:39:28 +0000 (UTC) Message-ID: <4f7e6f1b-bce1-41ec-b26f-f4fb53c3b276@collabora.com> Date: Thu, 6 Jun 2024 15:38:55 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , Ryan Roberts , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: mm: Make map_fixed_noreplace test names stable To: Mark Brown , Andrew Morton , Shuah Khan References: <20240605-kselftest-mm-fixed-noreplace-v1-1-a235db8b9be9@kernel.org> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240605-kselftest-mm-fixed-noreplace-v1-1-a235db8b9be9@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8B3521C001E X-Stat-Signature: qc7siwkab9u1819meggghbkqcg7p9enx X-HE-Tag: 1717670373-461823 X-HE-Meta: U2FsdGVkX19rg8zFZHVp2T0R60M3vKd9RCW5qCK2YuOtvyrz3jPdpJHxwTdJZvzrVO3f46DfPRC0UqZAb5mkjROVjdhFtSAt7jSs2o+ajjTJKx06+w638FaYe7wg0vpEwUF+iYygEK/Y2LNNarRLsy3r2xuFHIzTaE54tRFu+tRuwr7ehTMvjsP5vMiejFDv9nZ4axAYKXgcg2XVwWiN4mwMRwJjIRDwhY54qH5159a+5KTb5lmgibfG081tA/HEkct63yJUMTSzxiYYff3U1V/75z6uU1i9w96dkGqqOviffJ3W9jqBsb/Qa0PTCqXIIcFfgJndLqEDHql1OP/sBjFbEHH5cuaUugAv8j0PZhqy9wi5PAxUnBSeeHqnj7j5Nh32lsW9YV8suf8jmmSzjsYzvovtRcPMDTRDgdI3CyCZGcLUfdfsLeiVpG/dmsKQ6qWwIBhzMar7C6325vP0oMraVcN+u667KztFLQqbD6MHZVQ13hiJBjZe2VP4lw18t3djv5tvSZnKO9X8tt7rbI02TYZToMTaohJ2DlfTFkyNy1uTP2xBMdx+xd4zPAgjwimXHRSzZq0YNVh+6QuQj+VFaqpjP3tJCmlcVnhfG0lNGYw8NELAsJhK8AK90tmNguU5oB7DDRyLlujPBUbr7tfLzgo6lrq01mkHMnyfF2YxPcEFu6yN49L4KGGhlk3AClSNtqfp5mhWkAAmLdWx8Yt3pnywSksBezZ+UrWkAEjXqM+nwiOFMDrgkjf86orZNyTO3A3rs4bjAqKHHwvBydS3zPOdWhKC/8HDEDJvH1yy0P8DJRVhEg4Tnyx2/0SPYeM42GCrq9mwlMdedvFL6pugNHRahLiBYtAkLIWFWYVPEYso+vIiUKNMRnlaH3hDHuh9d/Sv6f4vVbugdzd7U/JYbkLMvmSvKwNI2cbJEHRoEDiU3lj8K8RvZQQQ1eFAX0HnRFRXHtJbYcEmwFL c7dJo1hw waMUjyoGEmmewQrSwWSDbSr6zFNoE8/3WtOMqk4+JFEhinQcC/K4t6zCGJb6u1mZkNqMvB60HHXTbxffsNNJvKrNa78qMqnALtE9Cybk4OEB4DyB5eYNKoAT4faVy8HIz5b6RvNYTxo0Pa3Bp/RW2PhxKfqzlEop8+e+VMP/dAe/6XfvaLoOqx0qhgXmGmkbZQxwyEXoy/BaE5pEQCw+Gq+Kyg8uP8jUPCRx0LL+kwikS8y5Ym6vGgLG9ec3i8d/n3AEgTs7ZlckhfWHdDHSb9GtmSjreMclndCQ5DJ8lhhkMxzxgNYatCv9c1BfQWaASLxJtRLxhiutaypiB5tYDTFIIPFxCm1QHEjftWKHyrTS+rSmg4mO5cDZayHwyQQ1DCptD0OutKVjj7GNLvCypri6F12wovpF61/N5pL+dxXuGKR4BMgJJ6pyDwabk1LnF4l8abywFlAp44Oi3eVazDVr33k6EdgUIJdTlIetWLF02SGKFo/pNUn518w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/6/24 3:36 AM, Mark Brown wrote: > KTAP parsers interpret the output of ksft_test_result_*() as being the > name of the test. The map_fixed_noreplace test uses a dynamically > allocated base address for the mmap()s that it tests and currently > includes this in the test names that it logs so the test names that are > logged are not stable between runs. It also uses multiples of PAGE_SIZE > which mean that runs for kernels with different PAGE_SIZE configurations > can't be directly compared. Both these factors cause issues for CI > systems when interpreting and displaying results. > > Fix this by replacing the current test names with fixed strings > describing the intent of the mappings that are logged, the existing > messages with the actual addresses and sizes are retained as diagnostic > prints to aid in debugging. > > Fixes: 4838cf70e539 ("selftests/mm: map_fixed_noreplace: conform test to TAP format output") > Signed-off-by: Mark Brown Reviewed-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/map_fixed_noreplace.c | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/tools/testing/selftests/mm/map_fixed_noreplace.c b/tools/testing/selftests/mm/map_fixed_noreplace.c > index b74813fdc951..d53de2486080 100644 > --- a/tools/testing/selftests/mm/map_fixed_noreplace.c > +++ b/tools/testing/selftests/mm/map_fixed_noreplace.c > @@ -67,7 +67,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error: munmap failed!?\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 5*PAGE_SIZE at base\n"); > > addr = base_addr + page_size; > size = 3 * page_size; > @@ -76,7 +77,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error: first mmap() failed unexpectedly\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 3*PAGE_SIZE at base+PAGE_SIZE\n"); > > /* > * Exact same mapping again: > @@ -93,7 +95,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:1: mmap() succeeded when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 5*PAGE_SIZE at base\n"); > > /* > * Second mapping contained within first: > @@ -111,7 +114,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:2: mmap() succeeded when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 2*PAGE_SIZE at base+PAGE_SIZE\n"); > > /* > * Overlap end of existing mapping: > @@ -128,7 +132,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:3: mmap() succeeded when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 2*PAGE_SIZE at base+(3*PAGE_SIZE)\n"); > > /* > * Overlap start of existing mapping: > @@ -145,7 +150,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:4: mmap() succeeded when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 2*PAGE_SIZE bytes at base\n"); > > /* > * Adjacent to start of existing mapping: > @@ -162,7 +168,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:5: mmap() failed when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() PAGE_SIZE at base\n"); > > /* > * Adjacent to end of existing mapping: > @@ -179,7 +186,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:6: mmap() failed when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() PAGE_SIZE at base+(4*PAGE_SIZE)\n"); > > addr = base_addr; > size = 5 * page_size; > > --- > base-commit: c3f38fa61af77b49866b006939479069cd451173 > change-id: 20240605-kselftest-mm-fixed-noreplace-44e7e55c861a > > Best regards, -- BR, Muhammad Usama Anjum