From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22BDDC25B78 for ; Tue, 28 May 2024 06:55:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82C6B6B0083; Tue, 28 May 2024 02:55:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B6D36B0088; Tue, 28 May 2024 02:55:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65A1D6B0089; Tue, 28 May 2024 02:55:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 473336B0083 for ; Tue, 28 May 2024 02:55:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7E1BA141684 for ; Tue, 28 May 2024 06:55:22 +0000 (UTC) X-FDA: 82166893284.09.E30344A Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 752F840002 for ; Tue, 28 May 2024 06:55:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of amitdaniel.kachhap@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=amitdaniel.kachhap@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716879320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PgFg/5LlqFWG1VTyPN9RT/nkOD+Doi5vqwsMC6K211c=; b=axEaYYlFiGBFXQkER86PyJKjLQ56Pb01h7+8kgwT4gPMgDxEEk/cWZkrwOx/yoNDzGg0OB ahAAuEOojcEJNVRV4SzZULOthap3kkinBUf+++wwXVXtdgoOjFaSxQaitUZ+uFpzrKPLlv x3ERsxUoxITpDalvTXcpwgNE62sdwv8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716879320; a=rsa-sha256; cv=none; b=MP9nqranjB2ajbS4qtFN2f4zyhE9qmqjTteJvcAd12z4YFoGtHlF8UeVV+7W1+qJdCSQAJ 2GC2QjecAkLHRkiqsBgx1x+aTlWWWKTDK/1TjdLRi09Cs5qkClMcTRPs0bih/9ZBNuLiRN GZGLpWoc99FWbH0JwCgcaYmCQSlYgik= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of amitdaniel.kachhap@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=amitdaniel.kachhap@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88109339; Mon, 27 May 2024 23:55:43 -0700 (PDT) Received: from [10.162.40.16] (a077841.arm.com [10.162.40.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 77D173F792; Mon, 27 May 2024 23:55:11 -0700 (PDT) Message-ID: <4f7d8691-fe19-4e8a-95e5-9f7680c82021@arm.com> Date: Tue, 28 May 2024 12:24:57 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Amit Daniel Kachhap Subject: Re: [PATCH v4 13/29] arm64: convert protection key into vm_flags and pgprot values To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-14-joey.gouly@arm.com> Content-Language: en-US In-Reply-To: <20240503130147.1154804-14-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 752F840002 X-Rspam-User: X-Stat-Signature: cn3k5enituudesmp7tyest6iap4hfhf6 X-HE-Tag: 1716879320-195847 X-HE-Meta: U2FsdGVkX194XstSWrrWLnLrFz8a05gcXcKJbHw5+kmwSNyZwjYFuCCiy/Y9+PaeNed9Qx1BPRM+2FGsn7j/NMzFEeFVGeS8AiI5La+3XLoi/v/8ltKyGiPN8vfqk0BDNSpRHz7u4mQ40S4RQA+b49yHHgoME1byJNKGfOsOUl3ZlWNRxYicALXgz0fj5h97zSmVenw6ls6hCPzgGuyGU8+u2dO6RZth5Cgkwb1EQFgII1ma3Inz7C6z5oZHJTpN8n3TBKDZNg1WjfUbOsY/K4ArMPL+FH9B0A1+86LKVfIGmOy97XXTgTe4S/N7ldxTr3/o3UppqUJ78J2t7YCKxLIiRwPKHq5gp0I/+SzTnrTm3OY2eDq8iZwf6XImAuotbmNRWV1wZfrsS1MZqGUMpS9M3kTfA4cz8h/kTW3zWy/WMfUkunZoApX+6YKLkwccfIenf2dGPzlbBBtgXpHVXOY2ZZwvOM3LBdwXhclx4zCis/4awR2gS6dOhiVWN/aQEQzkoBLXgCmZqZIoBte6nnwy+5qWG4YWcRjFp++BwoT4+aM+yuFfsX8IZtT1FwwZZ4om6K03Lt69F1Ek+1U83BDlIBSrHqxES/RsE8kgXWD1NDro1hfhWkKqBagGd0IAozV2itLkkygVjDcvgLoV4CBhIfqi9Zk0Swci5Fy33ENZ5hZo92icreNVcMXBa/BnRbKRradH8m/YnkprNfqNbZpobGTJMM5sl/D6IrsEjO7GSCFcc2zeEbapScmCK093k2LlfeJUtY3TZwouGqtFl+Y5+Amko/hkRvPDtJ2eY1HdyRuqQ4myVXS1vKFVaJv9xfXKYNsNv6A8ymo44BGDIZ78sZzC84UAeeR383tCIJshEQ7zrFx4xueJyHIowagxGB2A3hz2R18AqaFotak1RKG4VilWWPlUdCQgjX4iBpzu7Bby4gWOiYFgd+z2QdDMrj59xaEpbnB5OSAAcob HhEHLLB6 Lu0L3Cft8xG0KVxCUQYhA46rJVaPi0CsXQbGnyq3LIFw8m6l1E1nAxEZ987G3kWawRGVpF5+nNbWLHgU7tLSVzY2NO+Bz1B85CgJ5n7ZrOo6fxTSVTLIiGfFUmpyP6GHD0FfyTW4gL0D5Kv5dhp+qn++n+ExzoGRD08ox8Ef1Yb/u8PIVtoIl83JR3Pf2vaHnVvzqUJVLSxJsyj8/QC0SKuBqd/JF0tGX6r0Pf/phHtIH1FDYDm0PxPcERGG8kFVId3tWHfg6SwxUkYj7iuB5rYHqqxZlwIAgnS8wlkLKFr4L4RVzphYZocaUonQJ+pNLjcVp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/3/24 18:31, Joey Gouly wrote: > Modify arch_calc_vm_prot_bits() and vm_get_page_prot() such that the pkey > value is set in the vm_flags and then into the pgprot value. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/include/asm/mman.h | 8 +++++++- > arch/arm64/mm/mmap.c | 9 +++++++++ > 2 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/mman.h b/arch/arm64/include/asm/mman.h > index 5966ee4a6154..ecb2d18dc4d7 100644 > --- a/arch/arm64/include/asm/mman.h > +++ b/arch/arm64/include/asm/mman.h > @@ -7,7 +7,7 @@ > #include > > static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot, > - unsigned long pkey __always_unused) > + unsigned long pkey) > { > unsigned long ret = 0; > > @@ -17,6 +17,12 @@ static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot, > if (system_supports_mte() && (prot & PROT_MTE)) > ret |= VM_MTE; > > +#if defined(CONFIG_ARCH_HAS_PKEYS) Should there be system_supports_poe() check like above? Thanks, Amit > + ret |= pkey & 0x1 ? VM_PKEY_BIT0 : 0; > + ret |= pkey & 0x2 ? VM_PKEY_BIT1 : 0; > + ret |= pkey & 0x4 ? VM_PKEY_BIT2 : 0; > +#endif > + > return ret; > } > #define arch_calc_vm_prot_bits(prot, pkey) arch_calc_vm_prot_bits(prot, pkey) > diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c > index 642bdf908b22..86eda6bc7893 100644 > --- a/arch/arm64/mm/mmap.c > +++ b/arch/arm64/mm/mmap.c > @@ -102,6 +102,15 @@ pgprot_t vm_get_page_prot(unsigned long vm_flags) > if (vm_flags & VM_MTE) > prot |= PTE_ATTRINDX(MT_NORMAL_TAGGED); > > +#ifdef CONFIG_ARCH_HAS_PKEYS > + if (vm_flags & VM_PKEY_BIT0) > + prot |= PTE_PO_IDX_0; > + if (vm_flags & VM_PKEY_BIT1) > + prot |= PTE_PO_IDX_1; > + if (vm_flags & VM_PKEY_BIT2) > + prot |= PTE_PO_IDX_2; > +#endif > + > return __pgprot(prot); > } > EXPORT_SYMBOL(vm_get_page_prot);