From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48CD7ECAAD8 for ; Fri, 23 Sep 2022 10:58:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C489680009; Fri, 23 Sep 2022 06:58:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD16E80007; Fri, 23 Sep 2022 06:58:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A259180009; Fri, 23 Sep 2022 06:58:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8C50E80007 for ; Fri, 23 Sep 2022 06:58:32 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 68183A0198 for ; Fri, 23 Sep 2022 10:58:32 +0000 (UTC) X-FDA: 79943051664.18.863DB99 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 2080C80006 for ; Fri, 23 Sep 2022 10:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663930711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pq+nqOhkpxfLUyiqEq4MNg6ulDavWi2pU/tSeIb7Oc0=; b=BYzbUNCXOeCS/YO58N031GhFD5jlKWUNlsjQrdmsDFGL7r87sZZApRo2ah10wWrUlaKHWr /m6wVpjRvdrwRQmAkXizfUlUsAUbQXhpKUmuNg1IzXXm+sA6l9VW/wDp4Lo5xiIXXkqMlQ 5UhbHfOkS1EYGnfCwKnSYAV1vEiVd3Y= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-595-Ows-kd-oMSOa_A3WSEbl5w-1; Fri, 23 Sep 2022 06:58:30 -0400 X-MC-Unique: Ows-kd-oMSOa_A3WSEbl5w-1 Received: by mail-wm1-f69.google.com with SMTP id n32-20020a05600c3ba000b003b5054c71faso2087775wms.9 for ; Fri, 23 Sep 2022 03:58:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=pq+nqOhkpxfLUyiqEq4MNg6ulDavWi2pU/tSeIb7Oc0=; b=8Acy86l4/NebLO6Av21EVbhOS4OjVeoAaqbXy5bSUJEWzi1iXtEwzOWjfjNfn8SwvV E0Cmnt8oU6cALcAvRL9nq5H2KXsyxBjxy52E4TMKqFVF4Pqj3hlojvwnnPSibaRgWRvh m/KA7jzsOkOk4RTjt1Uv2mJkN+G9gGo1Nh0ya2avJR96NQmcxzCf1OpUvk+U2K/kIg4H iGPeBqTmx80Te3yufilRXPtIVFYiV8CaWhW8nPTdw/jSFYOWVSJFSm7xFVsmNIc617Zg tV0wMzhnfuVWTh4gbclcst8r9ft/x/FWq0o3+IE5Og+0CtkI+SQFfXrtAVJ484eHElEf Ibnw== X-Gm-Message-State: ACrzQf0Sjv19SeG3PgBPdiUhhFKN6Uxo/wB/7ovnbKsJyOQH2NmnvhRt 4ndiM1JuWOkcvQ22ipsVITqn7M3DR0UYsFak2hG5EqF1W/Lb/EB3EiUvj0M8Geidhn3nf6QPBA6 cuMIfrdqwA4I= X-Received: by 2002:a05:6000:794:b0:22b:311:afe9 with SMTP id bu20-20020a056000079400b0022b0311afe9mr4596518wrb.509.1663930709601; Fri, 23 Sep 2022 03:58:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM692HEan4sa48+pnUlqFXSHn8xzHJwtwuzQCIVFVG2mftuoGFZX1M6CyfbTNUt+KIc+bI3WYg== X-Received: by 2002:a05:6000:794:b0:22b:311:afe9 with SMTP id bu20-20020a056000079400b0022b0311afe9mr4596495wrb.509.1663930709283; Fri, 23 Sep 2022 03:58:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:cc00:4585:a83b:64f2:ad21? (p200300cbc704cc004585a83b64f2ad21.dip0.t-ipconnect.de. [2003:cb:c704:cc00:4585:a83b:64f2:ad21]) by smtp.gmail.com with ESMTPSA id i66-20020a1c3b45000000b003b2878b9e0dsm2158664wma.20.2022.09.23.03.58.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Sep 2022 03:58:28 -0700 (PDT) Message-ID: <4f7ae306-7894-8baa-f920-441ce8c472a0@redhat.com> Date: Fri, 23 Sep 2022 12:58:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 3/3] checkpatch: warn on usage of VM_BUG_ON() and other BUG variants To: John Hubbard , Joe Perches , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Linus Torvalds , Andrew Morton , Ingo Molnar , David Laight , Jonathan Corbet , Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn , Baoquan He , Vivek Goyal , Dave Young , Jani Nikula , Michael Ellerman , Nicholas Piggin , Christophe Leroy References: <20220920122302.99195-1-david@redhat.com> <20220920122302.99195-4-david@redhat.com> <3179f4545d3f71358da3e6c6ee18085af601b2eb.camel@perches.com> <60fa5b16-021e-1e54-7e06-39bbb871eaef@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <60fa5b16-021e-1e54-7e06-39bbb871eaef@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BYzbUNCX; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663930712; a=rsa-sha256; cv=none; b=C0sAfQOoRanhd8ecC2dcKQewiBFAnYaRzh2G5Ye/7T1X7Y29tUSmw5SurVhmmp/Wd16Z48 qLWhV4/fm0RwouIdUDZS2WgjkEYUq1AtCUFOHiz1HY486s0mqM/YIoGf0k58YypRqdP5Jr x9jd6/Aux/yxeiU0kt+VWHOotLrzFBs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663930712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pq+nqOhkpxfLUyiqEq4MNg6ulDavWi2pU/tSeIb7Oc0=; b=TA26PsZZ5lh+RKo5sX0QEDLU8ZJJwO9IHUWHXoceHRvwhKrYvWnayqKhAo9htcBwmPv3jg LO1nfSh73Wg6Djdsz8av6yW6520XpGO2gmmu68rWfs3xx2ZVInN4ke8tNzmP+YOV+TLQ5L 8tCNwcslBf75aMn4xRiNgk31b8Ulq4M= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BYzbUNCX; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Stat-Signature: mjy6xn6pez9868ihhp9csyw38nrcc5sz X-Rspamd-Queue-Id: 2080C80006 X-Rspamd-Server: rspam09 X-HE-Tag: 1663930711-119246 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> And I think that "Do not crash" is a stronger statement than "Avoid crashing" >> so I prefer the original suggestion but it's not a big deal either way. > > Yes, stronger wording is better. So how about this: > > "Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants\n" . $herecurr); Okay, let's use that. Thanks! -- Thanks, David / dhildenb