From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC75C04A6A for ; Tue, 15 Aug 2023 09:15:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D8C78D0007; Tue, 15 Aug 2023 05:15:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5876F8D0001; Tue, 15 Aug 2023 05:15:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 450618D0007; Tue, 15 Aug 2023 05:15:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 34ACF8D0001 for ; Tue, 15 Aug 2023 05:15:06 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 04D68A0D4B for ; Tue, 15 Aug 2023 09:15:05 +0000 (UTC) X-FDA: 81125779812.30.91F4282 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf25.hostedemail.com (Postfix) with ESMTP id 1F7CDA0010 for ; Tue, 15 Aug 2023 09:15:02 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=B4NWnukF; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf25.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692090904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N6UPah3rxy6GE+IW6hhaEXFukV19/RQgo9PDGSDaxjc=; b=zs004mtxmHefhM9WpfGnYhV+t02iTRDsPh6y2ht8A4fNpV8yvxiV2+MzZSuTYIco3USmYM KNODUgJUQTr7V1rLvmYBjgkosSxZdmmaowmcX3nNitFsmEKSAE8DqRx9fWrcl5FRwMHVLa korRHu8JhaCa+kVnAiNY2UIl7mGtHyE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=B4NWnukF; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf25.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692090904; a=rsa-sha256; cv=none; b=UnAGxB5UI0LfIJI4+CMVjkKbGMvCVSRkt4bKBipROtog2XMU2Eu/1KJc/8SluSNd6GWNQS T0B3TLL0EYxfMVLyTUf0oH7KfTMw8/krF9hLYWvHWYPYJSDMimHVhUEt6JpFXA022POGBL J+c3z4EnnsLyLaPlL/aasqm0XlCdNng= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1bba9539a23so9041485ad.1 for ; Tue, 15 Aug 2023 02:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1692090901; x=1692695701; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N6UPah3rxy6GE+IW6hhaEXFukV19/RQgo9PDGSDaxjc=; b=B4NWnukFtWBpBFBooLjjX+4xRi6cYrfaI8iegReeVzLQWKPXXt1CxHdKL4/tZ0fNPM 0UExtQR6YZe58qkKHpbXtHQV0uPapic2RYOUTB+6Pi7LdOE1C7GEcaF7+zgpTtYtD/de UlP+/TDXrfMVghqI9OT3wDmB4f+60Ecld4ptmi3g4OGE44+/xTS+dFaCetp2KrysicqF +aYy3xTBT6yAIsFwZB/EdPqMFUGo82MatiM8ko8K8L/pW/bDYDRzwOeVlfM6AvdWPq+b HcGAAnq5GXzxPWbDmjMNdTVLUEtTfSjxZmvfFI4JrMMNezs7y6COdvHcs3klmaxHW6vC FHlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692090901; x=1692695701; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N6UPah3rxy6GE+IW6hhaEXFukV19/RQgo9PDGSDaxjc=; b=YFHiwNHWw97Y0C6ukVYrx+5dJZdJShqK393bpByJ6sejCihklZlJGzNo1SGyjhPpcP O16jioRM/JE1R45KkTyGR8HFmD5rnx9KQmex00f9oyHUTswcZLTYXjrO9eN2wEM4Avyr imiramtj1iGvmSC6jIUIFwluYhvxNa+yDvAcjJFSuarqHE6YTPM/sTLij/mrYTnNNlgG ktlB21bZdXq/quMSTaVg3BX4JZldBjwtaZSrE0YJIxw2q1604dcwmiKK5VbYe1USNSzp r//4ebG3WcTbyTadFzWYdfpgRo+aUWWHRMTZbNKQGdVgrCTrizKP/EYtB0/j2bJtXiZB v44w== X-Gm-Message-State: AOJu0YxklXBK6kzS8ouQJZhraZ7jtosbdVjP/2isrCq23sA2OmpCWxnk e7+Mc1G78OYca6rQcggYIUybNg== X-Google-Smtp-Source: AGHT+IGKaQyK0d17VyjHV7p/Fr8yAF+2JMAJsl65uoihXD9UcmAUSi1eF134pFnOBdZUKl9ThFMr5Q== X-Received: by 2002:a17:902:e5c8:b0:1bb:83ec:832 with SMTP id u8-20020a170902e5c800b001bb83ec0832mr13866844plf.2.1692090901535; Tue, 15 Aug 2023 02:15:01 -0700 (PDT) Received: from ?IPV6:fdbd:ff1:ce00:1c25:884:3ed:e1db:b610? ([240e:694:e21:b::2]) by smtp.gmail.com with ESMTPSA id io13-20020a17090312cd00b001b39ffff838sm10630843plb.25.2023.08.15.02.14.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 02:15:01 -0700 (PDT) Message-ID: <4f64cd2d-90e8-7902-7ef7-1ac58d51b2a8@bytedance.com> Date: Tue, 15 Aug 2023 17:14:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 01/48] mm: move some shrinker-related function declarations to mm/internal.h Content-Language: en-US To: Muchun Song Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, Greg KH , simon.horman@corigine.com, dlemoal@kernel.org, LKML , Linux-MM , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-2-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 1ygrdp35hj4mhdji1ie6am1buxz7iios X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1F7CDA0010 X-HE-Tag: 1692090902-825151 X-HE-Meta: U2FsdGVkX1/IYQOikil099tDndKqhx2zI7qpUH302e5rkKJ4jL+H9Or4jGtlPMQMk/YJStuTPWgRQAJ2x/a5htCYrIO4IY7g+BCpYZNzIb7eevmh/5bRXuZ5og+4VfTMRmHDsJEYyzJ58NxAR5kZGHEQowB+Wm6s4IHjF9xJOYE2QF6Bzosp92DyDu4+q53kuEPXcl+2zO/zZFwEQTgRdy5TZGhXkqZpde8Z0pDPo3ffwPkZ4k/gl9HMTrZg3f0QgIPWc3Yj/Xiw+gZfiGQ831TkA4G3DLexT5Q7zTqZlzS4T4XZoBR+BRYIBlvreyFq1yoWufesFo48Sw+Yh9Pmt1JkBu/CR2WRfXwuguumn39k9QFAjQloylVW52r3LkMuBrhcEjcKmFRjpl4zgHypxS2ArP9Q1a9+lXwBcOogt75qb0XYlciddXdJLYUqGIU5WA7td00slIeytcVsns7fl4liPn42on0lBvS2rxSXlesrbGOxEZf0fnZi/ihtztWwaASkgB68TygyVm/Kp0Bo+8uQgc8K2TMooKRewSdyUaKg3GFcTiEss9pVmZdrkW55ae3h3fl2DtsutzyOg8j9ymgb2loG8oTIItIxx0dbmS4JxLlyVVkHoYukFpygkfCBRq8ihDXS8nsglq4WO5Nl+zclZn6M/83lY28Qo2NFaiodZ8mMW6oPgyUEcnAHel2Z5NW1OgjykufV9L/j2Acih/Vj2V0ROQ7m1nWlYB3wVX8E6yB0pMKW+PZKq1ecz5ovDUFBlUUa/KSPjv5yfc+pQUMNkA/wWGKWBGXZDOZSWinidL7D7UOq0RwCwOVElSpxyfP6m9UxvHNr1LgmGIgIKsO16cBwl4sXzbyaIWZO/mhqJPcAALwLZpUGPLG5eLHUJeaMgHFSs6sbi5ayEEVJHqfYIFZLW3oL0epRfyMO/WTY0uwuq6LOvv1oYLbm+FeE/0QxA6fmh2gP9gRxBb+ Y2Ubdvkj DBuejZzWZgFhEiKUW0RP3i2M4P1vdObZdO+6gQarpdbtjZu06ZcGfRQvytMsBJkhq4rj9CZf6m39lXVOEjYNxSQJheXPg2sP/eGmWFm9hjthR/0dHIhHS6p36hiCdhxAe1Si94zFSn4V9IsltyhhbViZvyIdsSP5gfLQk/uduGQgMB2LgA6eaG+2dUtFXNZY+RiCtXaJrQfI+0BP8KoVdnqluRZ23/VdeD2G9WUOZR3pElO4j40NGSTgeEk8zpqGyJYt8FzitHvxy0MDc5n9KMBKLTDUPTKAR5W5XO83g6cq0IEoElLGFuYFwUwYOp618Q7Ol17YK/U5umCY1Uj0OsAXxcs1pUr9A4c6rRbCKfuZfKqz8tlkCVz7S7v9rwd1RpYHUC6dwIpLxS2Y+hpoYxeQoL6U3MXr4OZS+WnLVtT9ntJ0KfUuD74AriqnTrFh7e8IXHQ18jGh1eGAE45t2s2ZHAnWOm2jUwknX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/15 16:36, Muchun Song wrote: > > >> On Aug 7, 2023, at 19:08, Qi Zheng wrote: >> >> The following functions are only used inside the mm subsystem, so it's >> better to move their declarations to the mm/internal.h file. >> >> 1. shrinker_debugfs_add() >> 2. shrinker_debugfs_detach() >> 3. shrinker_debugfs_remove() >> >> Signed-off-by: Qi Zheng > > Reviewed-by: Muchun Song > > One nit bellow. > > [...] > >> + >> +/* >> + * shrinker related functions >> + */ > > This is a multi-comment format. "/* shrinker related functions. */" is > the right one-line format of comment. Will do. Thanks, Qi > >> + >> +#ifdef CONFIG_SHRINKER_DEBUG >> +extern int shrinker_debugfs_add(struct shrinker *shrinker); >> +extern struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, >> + int *debugfs_id); >> +extern void shrinker_debugfs_remove(struct dentry *debugfs_entry, >> + int debugfs_id); >> +#else /* CONFIG_SHRINKER_DEBUG */ >> +static inline int shrinker_debugfs_add(struct shrinker *shrinker) >> +{ >> + return 0; >> +} >> +static inline struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, >> + int *debugfs_id) >> +{ >> + *debugfs_id = -1; >> + return NULL; >> +} >> +static inline void shrinker_debugfs_remove(struct dentry *debugfs_entry, >> + int debugfs_id) >> +{ >> +} >> +#endif /* CONFIG_SHRINKER_DEBUG */ >> + >> #endif /* __MM_INTERNAL_H */ >> -- >> 2.30.2 >> >