From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0EE1C5AD49 for ; Fri, 6 Jun 2025 12:44:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DA836B007B; Fri, 6 Jun 2025 08:44:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28B1F6B0089; Fri, 6 Jun 2025 08:44:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17B866B008C; Fri, 6 Jun 2025 08:44:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EF9216B007B for ; Fri, 6 Jun 2025 08:44:08 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 485FEBF248 for ; Fri, 6 Jun 2025 12:44:08 +0000 (UTC) X-FDA: 83524943376.18.4B7236D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id E32F01C0007 for ; Fri, 6 Jun 2025 12:44:05 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TjXepJih; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749213846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ar6SpSKanTLEMwpjfI2VMVmh2BTyW0PkU6fFk/apfzs=; b=vl1HdQNT6ykXc8DDslNuiDfHvkCZdQE7pulVvy+1uOlkcmRSqZpChCDMl7pVXmvgouMZfr lp2h3mJDGRWddMpGMd4hl4rkSY0pKlbTWxt+7lvSCccUkeV1IM/ZXt3mt23hIpW6ZfiwQd 3F3FGVYBtHQB+5uGHRLDUa+Y4h4QSRA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TjXepJih; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749213846; a=rsa-sha256; cv=none; b=7Lyhjk1TfO6RsB9luFyeXoqo0Uo0NhhfGxzzfwRuDlfwp9xy4pr0lQjZwi+WiChezZyhAb /gLIvfCASRUTIh4bCNYxcF6yZG2c92yxaLg/eYjLeYt+QitgWw18H21O5R9RpLN81liPrB VPWEv7/LXzXXEIOG8ZroeXG/Wz8TPWY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749213845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ar6SpSKanTLEMwpjfI2VMVmh2BTyW0PkU6fFk/apfzs=; b=TjXepJihCMd+P1TfZ4mVtgFbb2RDCZz35xrVymyr988Ajwtm9wdmsFJGIlFK7FXVpGrgxg EdNXdBCqWkOMWJ6eTppuv8ksg0JkaLEyXirePLNzwZyFp/zsAqBIkpsNSN8lDzc2E/hsHh jwDUqxdc1CUNQkII4rQzC50r45zxXDc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-IObsKWuPNTy_pcByTqlosw-1; Fri, 06 Jun 2025 08:44:02 -0400 X-MC-Unique: IObsKWuPNTy_pcByTqlosw-1 X-Mimecast-MFC-AGG-ID: IObsKWuPNTy_pcByTqlosw_1749213841 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-442e0e6eb84so13873855e9.0 for ; Fri, 06 Jun 2025 05:44:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749213841; x=1749818641; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ar6SpSKanTLEMwpjfI2VMVmh2BTyW0PkU6fFk/apfzs=; b=nGg1Db6QBoKADxsiUB0jcWwPHYUS+DWxmpkAgg1xIT+SCJt0rwBOWsSKIc+wKeo5HM p/AfuDGPMpHgYhS25cbwyNP5e95wJUM/ZcxIbCiZvzfv01CBNXERJczUDK+96ix4p8Pu K25VE6jK00K7DKRJf7emIpHuMTtVRXoFLi8rkN5ALtjPbyRzmc56ZRZAGSCg6lycEkfD /n5phf/zwgCcNdS5q5yDLUKW4mD3NX3b0LGWFiZ1nKa0HJL5zfoVcR8OODpCXde/byCS Mmnd1iOLIRznkFiVfT6jeT8goX6L/8dLJc76JJnTMXJY9Rgp2i8EkMPw+OpEcIMKtDoy gXqQ== X-Gm-Message-State: AOJu0Yw/SMBp7mstKEwDHggUtoaqAhqOShG31uVUitVAtqSquwenvU5F MLUvsndWymImenDeJdFegnU84DQgTujx3ueNhrx/4JbpJGiSH97GGnUPGpijP25117IHoRF//BI M67w0t5ONwBlbD8bAF5PeoknWhgqQ2o5Jh+CE/9D4uYr1aaN0PxJz X-Gm-Gg: ASbGnctuaOE9Pg8jJokYPjewjqJN9BOHIq2G3VbcQA6gUjiyVPuIOrYl3NGi3qn/Ygr SNf9X82k856A7YmfN/PtU+9zmXOdUS1QcbvCMEOECv1sQji1LHSIhma0Ge+Z+lNG/2ohSOBa+gP sHss4qr4qWTE9scoOPIIBxaBe0CSf4VYeUFr+pOuRCtiHlpeDSB8gfq8U0bD8PbiuNaNVVzb0D/ wB0OL94mjhX1s21gFDINL8KNB6/lITDay93fmTAuPITEsHmwzjULtHdaAAGJYhzx7+WC6079Crg ytL6w1ORdA4ShzYbKxf+LojEWHQyPPKSyxolTzGYtYcGhTlar9yTb/7/UaqdldoATwYTYsOhexj RwHqO52hgUYE2M5qVGIMbgz8wazfuI2Y= X-Received: by 2002:a05:600c:1c83:b0:441:b5cb:4f94 with SMTP id 5b1f17b1804b1-4520136a9f3mr33012235e9.5.1749213840979; Fri, 06 Jun 2025 05:44:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHU8HkkhEPbHgrJMNZ4OfhFtq64ki74ST8iAN9Am0Inv9D8PpEDiwbPnzWb3zxKPDvGBs9jCA== X-Received: by 2002:a05:600c:1c83:b0:441:b5cb:4f94 with SMTP id 5b1f17b1804b1-4520136a9f3mr33011955e9.5.1749213840553; Fri, 06 Jun 2025 05:44:00 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4526e1595d4sm20040765e9.16.2025.06.06.05.43.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 05:44:00 -0700 (PDT) Message-ID: <4f4fab59-abc2-4700-8477-edcb68d633df@redhat.com> Date: Fri, 6 Jun 2025 14:43:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm: Close theoretical race where stale TLB entries could linger To: Ryan Roberts , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mel Gorman Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250606092809.4194056-1-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250606092809.4194056-1-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Zb-IW_oYvJ75IHM4c2ZqiSVc-VtPRc_qaU2DTqy3VjA_1749213841 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E32F01C0007 X-Stat-Signature: 11hqjdhiragrg4p9qseomfbmdyuh3kmq X-Rspam-User: X-HE-Tag: 1749213845-439487 X-HE-Meta: U2FsdGVkX1/wlzbAxMga73ZdUkwThRhvOEHryMitu9aqsiIaIqWHgmRcAD827JVMwNLX8y1lRj6giSGERnRENUKrc+hu1iSmDXj9KzCuQzu9jZDtj518ePHo1cvnmQEODduGqSdL2Tn7MnaKOzkE00kiWvsM/n249VtVf5EVjcPV9kWI2tb1VlEQMtxG204XW6G7Rt0QP6nrm/3v/5D89M370CDjtWzio9BhYeGly8pQDI0T++fg4eVpnaYynocOfUYYGVLBsdAbCQDHAmyJIKVTTHnWjxNMuhZRy92d65OYy2IEp2s77ateDR9FNMVM1xEyLy/zPjkubdiL/rasputTOaCzSw0MMwAdlB6krRFRm8kwXVUezr5FOmTxKI8Kt8deLtYujthmnhdmynNFnjl90Q0PlFFV4p7Bhrfs8+j/8ktX6Z/G6UgVKoOoX8cRIgslxSMp16hr2Rkkhi1O8ydMIHUh+oKUgdN+PR2oRkPAdNRjpKfRmEUnZgzFZDvSDzb7JlSgL7atmE7drF8fQ+tgmlr+gpGtBzrB7TzL537MCwA/oEa2btD385HijcZwvQ32zmuJy5IlDR222Z6NFFt/94OARVcY8zZIyDjEQA/QtBr1PIHYdYojhAZws5ERnykWnhHwl8PhjhFAkaPPe/9VQ0e/PCEt2afd1qCUTu1QLqzeZtDcmyXTm7MmPigoTAI9swkfiDizJDpv0FlNNmacoMA2BT8Op2xUxphv4Gub0hciQkRTiIo2HnBzb5HDFGjIPaerC84ZyYm2peVOaxdKGHErl13oi+BNZ9G1uLoIM1Ms5V81H5J3xA23XgRi5IT7NRHAIjLeFYipgSMSRBvHpVtRjGXPeyzuDW2kxt0OwhH3qHa80CS66PovOT1dUusi7UnThTgQLhc5gUo7hu06uGOv/6xbzeDg6CO3+ypr/E3MkKgOpc5xpjPXPN6KhLRi4/NfkGEw9O0Z2br wcbCzP/K mZhYG7SwofeOlbAc85dUK6HJDlgDTmqvTQXvVWoLidkmVPM3b7Bl3lsmNVlDnt2XyPXMFntK/9BpQ/K/nIhDVs6z2yPhwBxQZwfumy2SQShb88LIDFFufR4GFbmLToGHh6PAhmIBBOI6HtAHAkvITyugagf04XCBbzoxDOWiKjeBxTETTHMICq9bRj/6O9RI1Vr7bAFv5qcIxuRliwPv5t2WzGyNqjTDpWFlZMwNnTRRebTrmRYo6CfWhSbuqFIrIesa1zMubYeayOXWpfwYWWv9OGhjc7rghA1/eTD03M2VTN++rqBVk/9E2+ss8RjRglwNpB4Ar9k4fpasCx+8Ji0/kBQoX4qlkUCtl07Z8EGYK/isWnt48hTtwb2iDxrxMk6T0oSNIlVGlHp+/UWKvPfKLwC+wiU2x+nAITyYRimHg9sRKJ8Fs/hXbFYHvYTq0nqpqmE293YdmKfVRbxezyx+jYVr5A3Ph5c92uNDk1U/EcyrcRAKxsvQNjSPoKidzqzJi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.25 11:28, Ryan Roberts wrote: > Commit 3ea277194daa ("mm, mprotect: flush TLB if potentially racing with > a parallel reclaim leaving stale TLB entries") described a theoretical > race as such: > > """ > Nadav Amit identified a theoritical race between page reclaim and > mprotect due to TLB flushes being batched outside of the PTL being held. > > He described the race as follows: > > CPU0 CPU1 > ---- ---- > user accesses memory using RW PTE > [PTE now cached in TLB] > try_to_unmap_one() > ==> ptep_get_and_clear() > ==> set_tlb_ubc_flush_pending() > mprotect(addr, PROT_READ) > ==> change_pte_range() > ==> [ PTE non-present - no flush ] > > user writes using cached RW PTE > ... > > try_to_unmap_flush() > > The same type of race exists for reads when protecting for PROT_NONE and > also exists for operations that can leave an old TLB entry behind such > as munmap, mremap and madvise. > """ > > The solution was to introduce flush_tlb_batched_pending() and call it > under the PTL from mprotect/madvise/munmap/mremap to complete any > pending tlb flushes. > > However, while madvise_free_pte_range() and > madvise_cold_or_pageout_pte_range() were both retro-fitted to call > flush_tlb_batched_pending() immediately after initially acquiring the > PTL, they both temporarily release the PTL to split a large folio if > they stumble upon one. In this case, where re-acquiring the PTL > flush_tlb_batched_pending() must be called again, but it previously was > not. Let's fix that. > > There are 2 Fixes: tags here: the first is the commit that fixed > madvise_free_pte_range(). The second is the commit that added > madvise_cold_or_pageout_pte_range(), which looks like it copy/pasted the > faulty pattern from madvise_free_pte_range(). > > This is a theoretical bug discovered during code review. > > Cc: stable@vger.kernel.org > Fixes: 3ea277194daa ("mm, mprotect: flush TLB if potentially racing with a parallel reclaim leaving stale TLB entries") > Fixes: 9c276cc65a58 ("mm: introduce MADV_COLD") > Signed-off-by: Ryan Roberts > --- > > Applies on today's mm-unstable (3f676fe5c7a0). All mm selftests continue to > pass. > > Thanks, > Ryan LGTM Acked-by: David Hildenbrand -- Cheers, David / dhildenb