From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D51C001DE for ; Thu, 10 Aug 2023 18:54:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A3906B0071; Thu, 10 Aug 2023 14:54:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92CAA6B0072; Thu, 10 Aug 2023 14:54:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CD056B0075; Thu, 10 Aug 2023 14:54:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 652EB6B0071 for ; Thu, 10 Aug 2023 14:54:27 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 20561C024C for ; Thu, 10 Aug 2023 18:54:27 +0000 (UTC) X-FDA: 81109095774.18.272CBF8 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id DB4B24001F for ; Thu, 10 Aug 2023 18:54:24 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691693665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GU4tUvFWSTml11ClJwsgBgwqd67/DGFAe72FjDDC69o=; b=1RldzdH1c6+5DcXNAAibp2XYM4cig9iaBwGuTq+yUgr3YoikSXEHZpF9X7Wsfsx14G+KFi /f5kZMizOF9+Q2kFc3GWjr3lowoUi3QZF1zdL4EXCWZtWTA4nis/Kk05kxF5h/mOJBNPYl T6HZGvsVVOomwuxgErHsUb4f+XnHDRU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691693665; a=rsa-sha256; cv=none; b=dGpaPr+ebq/FQSQnT648KH2LsLFe79/0tBchQ3+UgxaaU/1cXdJl6djM4nLXcqRLs2N/iS T2l+TmrpL5+N9484sFhnhNXtn/7510WGP3jmbckATzwAajez6Ru9aujR0IiouZTlGlN9pJ uTL5wqnKFSIEPzpob+oq1ICM4mMV9lE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 219BED75; Thu, 10 Aug 2023 11:55:06 -0700 (PDT) Received: from [192.168.0.23] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23A153F6C4; Thu, 10 Aug 2023 11:54:21 -0700 (PDT) Message-ID: <4f4d0cc0-6e56-4608-bed0-4bad3adc3c7b@arm.com> Date: Thu, 10 Aug 2023 19:54:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/4] mm/mmu_gather: Remove encoded_page infrastructure Content-Language: en-GB To: Linus Torvalds , Yu Zhao Cc: Hugh Dickins , Johannes Weiner , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Kirill A. Shutemov" , Yin Fengwei , Yang Shi , "Huang, Ying" , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230810103332.3062143-1-ryan.roberts@arm.com> <20230810103332.3062143-4-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DB4B24001F X-Rspam-User: X-Stat-Signature: nnqt1mcycwfe5zinygwybpnpj43sc9u3 X-Rspamd-Server: rspam01 X-HE-Tag: 1691693664-49822 X-HE-Meta: U2FsdGVkX19wBneqZ2hC96TEpAUo3JWSTYY6kQYfZ2wXvfZ38QvUxuM1WTjmWkt1N8MyOnL5bCPem7QRjuRStO3JyVuIZWOvrYYcVQz+dv+MhKVPPjb9E8l0gON9Xumb0+ANGamYnMmO9g2OmngCSyDIcfSO3JhIQwJy6QNYBHJedS66aT8n9squSQgDWt2hCiAr4iljTE3awfze4ahiCrMtxpD4/ZMtb/82mjKYKz7gAAfa2/cBPd3kE6b5ZFrs/4DE8WWKS1EPTuBah02qB2yQ/XRWgBBFC1/bICnJRxXSmJGfWny/emWW3viqntKYZynH9y2/LfFzISs3ezbPnqABo8mjca1TISAJ5zroDNY45QdWJ7CLhTIlm2FcM/jv3E2ycHAik53YBl6IwLfUQ5vfuYuHBE+dfc5tWbNshgk/qgYEDxXOy0lNKbhPAn+G5M6knZK0Nz3u98Mb9z64MH+2VooGxmKC34rt7JsgU9cCaKH1DxNn6UJA1MFUgOyKmBMTqk/fe+5nqxyQDbw9rRKd4AFA8Wi+r//BbTlm/imfWrCjhu2npVnxN4jdgDgQnuWzpvdfJnnVUuiGSoFP1MukaZIr8KSv5R63KfqfopRsoaSp4m0ZO6OpXVYQ7DdNhG5yp5sPYF6RqZoOgk5Ek3dOrrYbdq0ngwg09ugz4xd8YyNyiXWMPpuF4B55otTCRD9h/jVXFtxnuyRdOBRv8hMGdz+BgPqUx6p7QyoRW6/B/N4TzfhA7wJi0hor+n+OW8f9sDJX/UZNMRYniL4vR7z+wEd8/+frrK1/YR6jxMpT8Cut50M27d1PIeDy0o7IOrN1Z/U1cKZaMIJo88EIYPnjy8K+oYriNVTYjAi2B0uOlfa2/ZKAMK09+iY8oEiyydr4j3PkOWmzLOXQlJ8KOe0OKqaSy5YeAVW/LG8qT5fNuUXtqLL/5pnib/c0QCOA+pyCT3duCe8AltctGFn NYM7yNXn /qaLdzegEGAqTfWzJZmdDLtERtZ7jKVSlXg2Lk76sv7gYP2zLEfdUj1SuTUf3zLys5x63q3wkMI/e+3rC9ZhrizF9ANLmKgOUOuVQ1uHRausPvAe9TJS97ZOq0k3Au/kWYZEV7wDtbLcnj051zoYFWzvKtcxlyTJyTsw+SbiQ4cCNkSHniZqRr2Rzpb7ywlzxwa6CSdtm+UDgnicYv/tVgeqhww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/08/2023 19:31, Linus Torvalds wrote: > On Thu, 10 Aug 2023 at 10:35, Yu Zhao wrote: >> >> Adding the original author and reviewers... They might want (need) to >> take a look at this series. > > It looks fine to me. The important part is that the rmap removal has > to be done after the TLB flush, but before the page table lock is > released. Yes, we still abide by this rule for the !PageAnon(page) pages. > > That used to be a special thing for anonymous pages and thus needed > that special flag. But if it's done for *all* pages the need to flag > pages goes away. I think you misstyped - assuming you meant pagecache pages rather than anonymous pages? > > I see no issues with this, although obviously I might have missed something. Thanks for looking so quickly - really appreciate it. And sorry not to have included you initially. Thanks, Ryan > > Linus