linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ryan Roberts <ryan.roberts@arm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Yu Zhao <yuzhao@google.com>
Cc: Hugh Dickins <hughd@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Will Deacon <will@kernel.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nick Piggin <npiggin@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	David Hildenbrand <david@redhat.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Yin Fengwei <fengwei.yin@intel.com>,
	Yang Shi <shy828301@gmail.com>,
	"Huang, Ying" <ying.huang@intel.com>, Zi Yan <ziy@nvidia.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/4] mm/mmu_gather: Remove encoded_page infrastructure
Date: Thu, 10 Aug 2023 19:54:16 +0100	[thread overview]
Message-ID: <4f4d0cc0-6e56-4608-bed0-4bad3adc3c7b@arm.com> (raw)
In-Reply-To: <CAHk-=wiPp3DquE4A4FaWjgmS4wx7BT4MEFj5AOQie=tnK1N6yg@mail.gmail.com>

On 10/08/2023 19:31, Linus Torvalds wrote:
> On Thu, 10 Aug 2023 at 10:35, Yu Zhao <yuzhao@google.com> wrote:
>>
>> Adding the original author and reviewers... They might want (need) to
>> take a look at this series.
> 
> It looks fine to me. The important part is that the rmap removal has
> to be done after the TLB flush, but before the page table lock is
> released.

Yes, we still abide by this rule for the !PageAnon(page) pages.

> 
> That used to be a special thing for anonymous pages and thus needed
> that special flag. But if it's done for *all* pages the need to flag
> pages goes away.

I think you misstyped - assuming you meant pagecache pages rather than anonymous
pages?

> 
> I see no issues with this, although obviously I might have missed something.

Thanks for looking so quickly - really appreciate it. And sorry not to have
included you initially.

Thanks,
Ryan

> 
>                 Linus



  reply	other threads:[~2023-08-10 18:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 10:33 [PATCH v1 0/4] Optimize mmap_exit for large folios Ryan Roberts
2023-08-10 10:33 ` [PATCH v1 1/4] mm: Implement folio_remove_rmap_range() Ryan Roberts
2023-08-10 10:33 ` [PATCH v1 2/4] mm/mmu_gather: generalize mmu_gather rmap removal mechanism Ryan Roberts
2023-08-10 10:33 ` [PATCH v1 3/4] mm/mmu_gather: Remove encoded_page infrastructure Ryan Roberts
2023-08-10 17:34   ` Yu Zhao
2023-08-10 18:31     ` Linus Torvalds
2023-08-10 18:54       ` Ryan Roberts [this message]
2023-08-10 10:33 ` [PATCH v1 4/4] mm/mmu_gather: Store and process pages in contig ranges Ryan Roberts
2023-08-10 14:44   ` Zi Yan
2023-08-10 14:55     ` Ryan Roberts
2023-08-10 14:59       ` Zi Yan
2023-08-10 15:05         ` Ryan Roberts
2023-12-04 12:26         ` Ryan Roberts
2023-12-04 12:28           ` David Hildenbrand
2023-12-04 12:39             ` Ryan Roberts
2023-12-04 12:43               ` David Hildenbrand
2023-12-04 12:57                 ` Ryan Roberts
2023-08-25  4:09   ` Matthew Wilcox
2023-08-25  7:13     ` David Hildenbrand
2023-08-29 14:02     ` Ryan Roberts
2023-08-29 14:19       ` Matthew Wilcox
2023-08-29 14:24         ` Matthew Wilcox
2023-08-29 15:59           ` Ryan Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f4d0cc0-6e56-4608-bed0-4bad3adc3c7b@arm.com \
    --to=ryan.roberts@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=arnd@arndb.de \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=fengwei.yin@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@gmail.com \
    --cc=peterz@infradead.org \
    --cc=shy828301@gmail.com \
    --cc=svens@linux.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    --cc=ying.huang@intel.com \
    --cc=yuzhao@google.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox