From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C10EC36002 for ; Wed, 9 Apr 2025 15:09:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27594280068; Wed, 9 Apr 2025 11:09:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2253D280064; Wed, 9 Apr 2025 11:09:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C5D6280068; Wed, 9 Apr 2025 11:09:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E094E280064 for ; Wed, 9 Apr 2025 11:09:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0CB93160E83 for ; Wed, 9 Apr 2025 15:09:12 +0000 (UTC) X-FDA: 83314838544.28.E84EA30 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf25.hostedemail.com (Postfix) with ESMTP id 9ADF0A0023 for ; Wed, 9 Apr 2025 15:09:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lHeHIBXB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CL0zlLRp; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lHeHIBXB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CL0zlLRp; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744211350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GzjR4oQ2qzzHMq50duuwsOgZ3sY0afnl6ZVMYTeN7mQ=; b=luJuqGfkLF3MUrNP1JpVZnqP5Ahf0RyflexVVcXhiYKB2lRmZs/oOMoZ6Ph5FYLCFP97rz Y1a7KecKeQhNsMH2TMpIYMMUlLsyeMscXh8fiNq52FusOB2RELjvZ4A79gmGQQKhEoBUyV 2hmqb626E4fPebgcLvBSy9ZCrV/EZQY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744211350; a=rsa-sha256; cv=none; b=55il9ANE1bDFMsBbbKmthRHLKloJQtZo6O04i2lAs1LFvlClmzU6iPTJP8KobH3CFlUJiu /OQDxRRK5BUqJVLMRFs5P3mwK1V++9oJH3lnxGNyIBcmTbzbalFWOu94eIbmVeRVeeWaG8 fq6xt8bsVwIm6q3OTyScQuR3af+l0I0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lHeHIBXB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CL0zlLRp; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lHeHIBXB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CL0zlLRp; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B04151F445; Wed, 9 Apr 2025 15:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744211347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GzjR4oQ2qzzHMq50duuwsOgZ3sY0afnl6ZVMYTeN7mQ=; b=lHeHIBXB9K0yN22hxOlp/aqyN035ygY/uCteI0u4BeP5R/23NHblkxtNz1t4tB5o77tZNI qDImqWPRzPPT8H26XeMYXfrGOwWMuUEE5xg+oo2zFpoiUOENSa1VuqGnVBHLdv8mi6blJo SkqpYQed5XnESE7yfxX97Q58ATupaYM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744211347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GzjR4oQ2qzzHMq50duuwsOgZ3sY0afnl6ZVMYTeN7mQ=; b=CL0zlLRpfL/PdyHX/n/HeVuT/po0VWiPjAV/2Gaz4tOBc6Sp78vd1uEKMhyrTJYcTpjxxU gm12g6kK96UYLoAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744211347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GzjR4oQ2qzzHMq50duuwsOgZ3sY0afnl6ZVMYTeN7mQ=; b=lHeHIBXB9K0yN22hxOlp/aqyN035ygY/uCteI0u4BeP5R/23NHblkxtNz1t4tB5o77tZNI qDImqWPRzPPT8H26XeMYXfrGOwWMuUEE5xg+oo2zFpoiUOENSa1VuqGnVBHLdv8mi6blJo SkqpYQed5XnESE7yfxX97Q58ATupaYM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744211347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GzjR4oQ2qzzHMq50duuwsOgZ3sY0afnl6ZVMYTeN7mQ=; b=CL0zlLRpfL/PdyHX/n/HeVuT/po0VWiPjAV/2Gaz4tOBc6Sp78vd1uEKMhyrTJYcTpjxxU gm12g6kK96UYLoAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8D34B13691; Wed, 9 Apr 2025 15:09:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +D25IZON9mfPYAAAD6G6ig (envelope-from ); Wed, 09 Apr 2025 15:09:07 +0000 Message-ID: <4f4adc4c-72fd-481f-8b41-f107f2b91ef8@suse.cz> Date: Wed, 9 Apr 2025 17:09:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 3/8] slab: add sheaf support for batching kfree_rcu() operations To: Harry Yoo Cc: Suren Baghdasaryan , "Liam R. Howlett" , Christoph Lameter , David Rientjes , Roman Gushchin , Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, maple-tree@lists.infradead.org References: <20250317-slub-percpu-caches-v3-0-9d9884d8b643@suse.cz> <20250317-slub-percpu-caches-v3-3-9d9884d8b643@suse.cz> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: yd871eqcrh5kmc7hcxzp3gf65meefby9 X-Rspam-User: X-Rspamd-Queue-Id: 9ADF0A0023 X-Rspamd-Server: rspam08 X-HE-Tag: 1744211349-617116 X-HE-Meta: U2FsdGVkX1+BMr/yK/vJ7m1zMTW82hNTlY2bQ+gfTS/bPUXvEeSWopA6+rjD3N5el6oBxtGxY60kxzsu9tK0rT+gkM38srJXf23Td0cymI6WJkC5wx59nG4AO1xI2Isca9iq694mtHqSZlZU/jThgJxQpQFPurSPf9c0VHFGeWFb3CHEtULsU6WMNQSpx2D1Fg8WivTTIUCXXNLrmf8bmjCdzAlTEynDQJBo4CdUQRHORugt3dr7iACVnYYiRbRAA5/gaLaZE+j5nyDVx+S3IN1Yy83KjUyQT+9cAGZYpSaB6l/t+DGAU7c/l2vB70KNTM0hDQOB8hs/toHjoIVrIk029TsEQxNVaCgDJROqAcUe01n3O36XTbaB/enpdGdtVnmFKZXHdAvC8wuhWAYJHuYz7hrnj9Xbrx20uRlWxbi0BXRHe+49ZHLdE6L0QTvvY4e7M64DLh+BoRQQ4C6CsQkAf5zV1ydC8VEZmOnKTgO1Z4ictYuxygKBlnNhUDN5MsPkMsZFjlOc0FDP71E5ruEK9g3KcoMjouuRmUD6ALjdNwQUI4GXWJMRl1ngfYTUYAZ9qbDR0u0vZCpRH//DlpTmMVInMZ497zMfyPL7KOgXSWY1xWomQhsSF9KtMbpahiZ+yy+is/IGxLVsrnsov0r//kSyY2z1FIMQslBWzymCCh25gUJ1WzPlux5TZvphuW7jcs6wW4UhAlYMMW8Z721qCAp/NSF5DwYqF1ekyE6tOTjAV8xH/9s1+YcKx4Nx5ntONDuQurPTMeeQPi+lP1b2RPPZpUt2vEQkJffdRL84bgAL88GOYgrXf4LiXbsZQCiuLEKo2VWtC/bafV46tEKaH8Sk20Lx/X2T2km69RWi4jE1JPCvP1UhYd1y9mO59qhPxhMeuHofweO6qjf2ug4UdoyutLTUWkwMA59wY5CX0LWCnCwv7szPos6icmlOPOgAag4RwymcW7H0LDc b8GoQ7Nu WHSuIx7gIBF6hf3NMDJGbOO2aM0TWUmtba/Zw2NdIuYT4Ql78KJC8MEEyiq/1hu7Jbn+jI8LnxDQaKMULsXQOtq7olmEo9qF4QPguB8HDtUJaH3IIRWx8hD6ju5dXPM/mYa18e0AUYf6K9So05n8EtzMWqUEsG47SIr+5V3mOz2Bh3G/s25ro+Vs9B+ORf2rvp/nRNYHFhtZf4eBffLHXvNVZ+uO6cn83v8kMd2cmEjD1r0unxTLSKprduIoyX1NPvkYNs2aezCawZdegyDfLhGGv37IpSGQErbwVMeDPtddgbwKxQ2RIrgxGPMN4NYasrHqPn24Vv3i88eEDoHJxX1fb4Eft1LwC2IXQuDLrZAZ1Xy509nJlVKNTiZUsIDa2NyKh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/9/25 3:50 AM, Harry Yoo wrote: > On Mon, Mar 17, 2025 at 03:33:04PM +0100, Vlastimil Babka wrote: > > Hmm this hunk in v3 is fine, but on your slub-percpu-shaves-v4r0 branch > it's calling local_unlock() twice. Probably a rebase error? Yeah, thanks a lot for catching that! I've just pushed https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/?h=slub-percpu-sheaves-v4r1 with this fixed, and fixups for 2/8 to the points you made, plus a proper strict_numa handling in 2/8, and an extra patch for better NUMA locality > Otherwise looks good to me. > > When you address this, please feel free to add: > > Reviewed-by: Harry Yoo > > Thanks! >