From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B3EDC27C53 for ; Fri, 7 Jun 2024 09:24:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACCBE6B00B7; Fri, 7 Jun 2024 05:24:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7C776B00B8; Fri, 7 Jun 2024 05:24:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 943366B00B9; Fri, 7 Jun 2024 05:24:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 751DA6B00B7 for ; Fri, 7 Jun 2024 05:24:14 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 23192A17AC for ; Fri, 7 Jun 2024 09:24:14 +0000 (UTC) X-FDA: 82203556428.25.4B3D294 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 1049F40016 for ; Fri, 7 Jun 2024 09:24:11 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717752252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jED6M5gH3RYjK5/rTB5Iwp7CAcL8ltMwQc0RkjOqabk=; b=qxOwfDXAplMbhBN+8v1+YY3tXiZMYW9rPeKe5eWFnAr7p1GtFIP45Pbdgsf6j+Vy20CI2v dGAGiNGOpXpgHSOODcLClOC3pVhkY67kSiowPcjUggEqwyg3U1jH+DwhYUpxwQ/I1l3iXh ie466xe0YcKKX2cmanwQpHuMIFZvpLM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717752252; a=rsa-sha256; cv=none; b=umLIghmP9WTobPiTOr6Um1lAB1R9FGBXvTZwX6ZoEof2Njccl1FGkXtXN4Z9lFXixOCKHG Euz5xuFamwNbkWGOnCiw7Y+mRepCfqvQ15g7kp/gZzXWslKHzXXS+MnEq74ZpmPRO4G3Kh yFFVCjx+e158NMUY/96a1l8kMEyeKcY= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7EB3D2F4; Fri, 7 Jun 2024 02:24:35 -0700 (PDT) Received: from [10.57.70.246] (unknown [10.57.70.246]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1B5B43F762; Fri, 7 Jun 2024 02:24:09 -0700 (PDT) Message-ID: <4f0732ed-1355-436f-be66-c7486e3cf1e7@arm.com> Date: Fri, 7 Jun 2024 10:24:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: mm: Make map_fixed_noreplace test names stable Content-Language: en-GB To: Mark Brown , Andrew Morton , Shuah Khan , Muhammad Usama Anjum Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240605-kselftest-mm-fixed-noreplace-v1-1-a235db8b9be9@kernel.org> From: Ryan Roberts In-Reply-To: <20240605-kselftest-mm-fixed-noreplace-v1-1-a235db8b9be9@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1049F40016 X-Stat-Signature: 75h7okw1sa5fs3qc1m93qbwdpgn6e3mi X-HE-Tag: 1717752251-109971 X-HE-Meta: U2FsdGVkX18ZqSZ2esfcqiJYdm52oorlfgat/s7JXe3M6mZ0psgRAUrXu16GQ5hA6QgGEvAi6/NJrY0FKIEAv+c/iQr+QXTDSuvGZHFOGgZqLUcqEC+57xMtfTleOV+tKuWUCNTgfvCARMovupXiTm45H1qBl2+Aw37KB6Prrid78ZxkRWTlMTqkKEkN8kYMRnm+g5+LYw4P7uxnhv35SU9f5jwq1cIWmPfN4zsp2s+qZ23Qq/3E6vlHu6t40RierPDvZeALG+CBfcEiu31D6zSGcv95XDTJ7F1Gz4dPJHfzIWbX6/gfT92/67r4x8D5Y/38U0dSQZKfR1R9Go+NgxcXoTTroW/Rnh5cWh4IanMVLcXw/2lugD2VTFFS/CXf5RtCaI0S2vbj1zCqa6NPsbv/Nwe/X0vWGl0OfbuoSUaMrC+sY0zh12OwfMCQWr8+1Pcnukcgmo/XMoLUCpFfNwoDe+NSMtXqnAU+p+NVVGbaa3+jJj5enImUjp3gP4MngStwI+r1CIn8L44mLFppzRrIdY9Vh3jjAz7DEFIBi5kvwyJNRA8mBWBnH5Vrv0U11EpvPQvYBKNDyCAdcNlF0vhVzLIrCbUnXv1EM3ePlMBq0EnT3pPX5Z8CEaI4qjozTFTeSy22H5QGnsnVu9feUMSANJXzblhXqPwDiukah6KTyd7cDSuqheT+RkBpxML58Z0f2llXPafisgENrXCgxzp7B6xZxbEHTduLvn4HUKjBnAqFOwqJlpAvNVwe7+NWSEhjgI3Cp+Pmx9EaQIjh/n9QQtuV3EYfFxfV5Vw4uCIygty9/ZHlW6NZjFOK5kYHy3VTVuvO2XEVUb3KCAsORZWjMhoXx/GUSYrvCUScg1C/31sS4KH1nRTVE2YH9nhvpmiFJz/Xe+RbRNuDarAjbuDknDdpCd6puixORp+hwR+qro0cHMelhz2IltZAwfpIL/JbkD0o4B+oy4ND4rN Vj+VwJeC HnXDKUr0ckZ0cWbiUllQ427POFIi1KtyBpZeBADDd48Wv3PJdSmt05Uqex7ml9G+gR5kHPqrW3ubi/u3E+SWPNASJ/WmlvJiRbBW+NmSrzW11mms7sB2qW0EkQPWwJ+Vlk5q+JhA4lpzkUuRsemv9MBtxsjars0AalRPUhuczDtbVXhGIeI/Okkki5CXoD1dMyghmQ0fpyXA6dYiCFLCNLy6YhfKpMf+xPSRBrEZLLziz3efSgLncf/Z3M9VaFUwEyWEpmORz70OsDbgvOHDlMVUXGWk8DyzJnBiDJjtosBh9f9NVF1dlwF19ZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/06/2024 23:36, Mark Brown wrote: > KTAP parsers interpret the output of ksft_test_result_*() as being the > name of the test. The map_fixed_noreplace test uses a dynamically > allocated base address for the mmap()s that it tests and currently > includes this in the test names that it logs so the test names that are > logged are not stable between runs. It also uses multiples of PAGE_SIZE > which mean that runs for kernels with different PAGE_SIZE configurations > can't be directly compared. Both these factors cause issues for CI > systems when interpreting and displaying results. > > Fix this by replacing the current test names with fixed strings > describing the intent of the mappings that are logged, the existing > messages with the actual addresses and sizes are retained as diagnostic > prints to aid in debugging. > > Fixes: 4838cf70e539 ("selftests/mm: map_fixed_noreplace: conform test to TAP format output") > Signed-off-by: Mark Brown Reviewed-by: Ryan Roberts > --- > tools/testing/selftests/mm/map_fixed_noreplace.c | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/tools/testing/selftests/mm/map_fixed_noreplace.c b/tools/testing/selftests/mm/map_fixed_noreplace.c > index b74813fdc951..d53de2486080 100644 > --- a/tools/testing/selftests/mm/map_fixed_noreplace.c > +++ b/tools/testing/selftests/mm/map_fixed_noreplace.c > @@ -67,7 +67,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error: munmap failed!?\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 5*PAGE_SIZE at base\n"); > > addr = base_addr + page_size; > size = 3 * page_size; > @@ -76,7 +77,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error: first mmap() failed unexpectedly\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 3*PAGE_SIZE at base+PAGE_SIZE\n"); > > /* > * Exact same mapping again: > @@ -93,7 +95,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:1: mmap() succeeded when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 5*PAGE_SIZE at base\n"); > > /* > * Second mapping contained within first: > @@ -111,7 +114,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:2: mmap() succeeded when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 2*PAGE_SIZE at base+PAGE_SIZE\n"); > > /* > * Overlap end of existing mapping: > @@ -128,7 +132,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:3: mmap() succeeded when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 2*PAGE_SIZE at base+(3*PAGE_SIZE)\n"); > > /* > * Overlap start of existing mapping: > @@ -145,7 +150,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:4: mmap() succeeded when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() 2*PAGE_SIZE bytes at base\n"); > > /* > * Adjacent to start of existing mapping: > @@ -162,7 +168,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:5: mmap() failed when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() PAGE_SIZE at base\n"); > > /* > * Adjacent to end of existing mapping: > @@ -179,7 +186,8 @@ int main(void) > dump_maps(); > ksft_exit_fail_msg("Error:6: mmap() failed when it shouldn't have\n"); > } > - ksft_test_result_pass("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_print_msg("mmap() @ 0x%lx-0x%lx p=%p result=%m\n", addr, addr + size, p); > + ksft_test_result_pass("mmap() PAGE_SIZE at base+(4*PAGE_SIZE)\n"); > > addr = base_addr; > size = 5 * page_size; > > --- > base-commit: c3f38fa61af77b49866b006939479069cd451173 > change-id: 20240605-kselftest-mm-fixed-noreplace-44e7e55c861a > > Best regards,