From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 685C6C5320E for ; Mon, 19 Aug 2024 11:13:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3F7A6B007B; Mon, 19 Aug 2024 07:13:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C8576B0082; Mon, 19 Aug 2024 07:13:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8699A6B0083; Mon, 19 Aug 2024 07:13:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6B14C6B007B for ; Mon, 19 Aug 2024 07:13:28 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 223801411FD for ; Mon, 19 Aug 2024 11:13:28 +0000 (UTC) X-FDA: 82468734096.13.56321B9 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf30.hostedemail.com (Postfix) with ESMTP id 937998000B for ; Mon, 19 Aug 2024 11:13:24 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724065943; a=rsa-sha256; cv=none; b=654MgMe5vW1Y+KhutIIr/dxo5Qj0hFvy47uub3VMl5dPJ37KMI0/W7P8GPxooTxDJxeWS0 FufKmOmKDGIrpfTnM0P8OQ2WcJse54vACQpw9oR+icwSYYJ3ol2X2xn121UwZHxt75U4Xg PP0+U6U0rsXpvAzZ8aVrTOlkrOSWIMo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724065943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G3fk2dKQMOwfpDJjQFEhWouz32NFR9pJor2uUWl+9ns=; b=a7j9z2PST97ByqkW1P8qyuWfbOGwt+eh/F/uRnKeOaf4OxLvlKsnaumVd55yv2RQwPuYUp enQJMbvCRNsybfcr0xL4W92iN2cOnyRhpARc7KD7jr3pwe6u1/RX9vaAPYg+qCcYxqda8L 1y9NjZCkantrocf/imJHicmOzMDw4yU= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WnVK35mLLzfbZ8; Mon, 19 Aug 2024 19:11:19 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 6A8EE1800C4; Mon, 19 Aug 2024 19:13:19 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 19 Aug 2024 19:13:18 +0800 Message-ID: <4ee78f2b-05e0-4f6a-99fd-73e6571e91d7@huawei.com> Date: Mon, 19 Aug 2024 19:13:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] mm: finish three more folio conversion Content-Language: en-US To: David Hildenbrand , Matthew Wilcox CC: Andrew Morton , Alexander Viro , Sidhartha Kumar , References: <20240817095122.2460977-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 937998000B X-Stat-Signature: aw4ac4whgp9kwhyzc6tsuhac3tsqcsi4 X-Rspam-User: X-HE-Tag: 1724066004-504486 X-HE-Meta: U2FsdGVkX192qIkVXmWAqq3EZXgzn8uoRJAbiVdyHjzDCFc96RpHgNB+Opd0oSgcYGoYf3JZwMYB+D0xHem//WjVYrv8/A8DcGIxoyqS/tn+X+Vu++xdvHA3Xbqfd0wzR7CFqJWRPZOZGgsCfiZsXK1Gn+YpuIGJYu1WLMz/47tz0kqSNBpr6r2wPxkaCJrXcs4k9+ZjEkYiYY4PDozdz7IQsk958YXXoeUlJRC9S8x73Kaey2Qv3cNfvdG9sdc4BM+NCMoq3xvblldclSlrottmoiFrVrWC9k9ntmjFmuIXwo1xmtKQYZ9pOAJn/Mm4u6HHFHGdN7QLkxa3P7MWhthWDFpmuvVNGi9hv+U2GJU0tXwgu2LWSWsMr9CkhPu82ZfCN69xfHDcB+dkLKcHuDo0IA0FQ96UpOZ5gd0iz3NUz0z8A10EI6pKhtJdIBJTGNLHQLsbKCzyiLLMEgSLbbaX7L6wdZmJeumMUQsNNXfK/sb02kAFNFuRC7KI+HvkLDjUBhtUu3RWLOXyOJ7JBPx9MDv18KOJKDYvdsZ+LWcadaa5UwZZ8YddmLhZUP46uP3aSVc6QknApDU1uFIjl0ZGadGFwEPqSYypyR3aOLbk6X1beT6APnB+glcjxM/rvnqzvGlqqPyoAw+sIhPJm1k5vJ3mjqF/kfMmXZAdTvz1lbilpjqIMEl5dTW+NncZSdHcryikO2cw0GnfsAVhktEIexgnufb+2+I/Z5vTfuS4GSbU9QIr5Gw1L8FhkOP1g02smmAYJ51/ar9iEUMNjxsUceM+uPqjqv1ua6rJ0l8zpwm9UEonB7nzC/bTn5+/FCV/6bMjgR84FV1Bgr78/wISnUYbezZ3Ex6CKFCMqQT7FT/TDQngBzq812Nd9ZiqOY++bEPbD+fhMocn0eYIOBG2eEb9dxxIO4PtAr0JEOqBVUXEgJRsL/ls3JtsSFq0dfcAV9CtacE4/Z+d4ag Qw76o8rm r2J5NbvmekRjPGkyCMaX19Dp7zMegE60cPHK00U54NIMZ9JLAjw+a+bWtk6rujlOmvwShrQNJ160eEFSV4wZulDo0a8TDNH1/KYTyoG6Tcg/USaVF50cmq75osqgUqohMoY0L7jDXh5L0d/lW4yWAp6BQxMbXfXDaYak65N0cuIk2X0tVkGts3anLxVrI+esNtxFzF174erst7ixW4k4de91eWK9CMmI7BQ23A7pc0wLSzdFGEngd9HqQj2J7VDwjARSizHYWi/LU7d2MR1PxZKPF4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/19 17:59, David Hildenbrand wrote: > On 18.08.24 22:33, Matthew Wilcox wrote: >> On Sat, Aug 17, 2024 at 05:51:17PM +0800, Kefeng Wang wrote: >>> Convert to use folios then remove find_subpage(), thp_nr_pages() >>> and PageTransHuge(). >> >> This patch series is premature.  None of these APIs are particularly >> advantageous to remove (they're inline functions, so cost nothing unless >> used). > I do enjoy seeing the removal of thp_nr_pages(), though :) > The thp_nr_pages() and PageTransHuge() removing are found when improve memory hotplug[1], also find_subpage() has issue[2], this is where patches come from, since there are only few callers, I think we can cleanup it earlier? [1] https://lore.kernel.org/linux-mm/20240817084941.2375713-2-wangkefeng.wang@huawei.com/ [2] https://lore.kernel.org/linux-mm/646f8a48-820f-40ae-bf96-7d554bf4493a@huawei.com/T/#u