From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 017E3C54E71 for ; Wed, 21 May 2025 15:59:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92F616B0092; Wed, 21 May 2025 11:59:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B9636B0093; Wed, 21 May 2025 11:59:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7812C6B0095; Wed, 21 May 2025 11:59:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 584196B0092 for ; Wed, 21 May 2025 11:59:36 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C8765C0AE7 for ; Wed, 21 May 2025 15:59:35 +0000 (UTC) X-FDA: 83467375110.11.E0FC1B8 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf14.hostedemail.com (Postfix) with ESMTP id 2EE43100007 for ; Wed, 21 May 2025 15:59:33 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747843173; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6G1ZLI2wuMRG6TbW/7+YRTVHWfEMPpGjX54SgHctCVE=; b=PPGMYbaBua9ba1dRJhdnPgZqvK2oF0mUHNACp/uyNI7sl9ds8RA18q9796F38vYqg9EAmH ADCXK6mSbKVv+cZ+ZFrryz/UHFrvsLFjw+FbehtSrncUJWCgC/469wrb2H/nOr1D7pL//x O8ijPhLHmzOboDa3y7pS0wUCRdMmjbg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747843173; a=rsa-sha256; cv=none; b=anKsxf8k+oaiYdSuk++yVLkRn+rInaQSipsds6kJO71qYLhAnmIx92RAbeK/zcaPmzYda+ 9K59k++vphDJZRbicQMY0/AERRHDbqjMWSW5lvU1FcFppGYOrZYZBMdSjuBXJHB+pCIans ozmITTrSKhugz3zAFIerXHd3kMDc134= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1uHlqW-000000007vu-0Xwj; Wed, 21 May 2025 11:59:08 -0400 Message-ID: <4ed8b8998a18ff5ceeaec803244897d127998ae4.camel@surriel.com> Subject: Re: [RFC v2 6/9] x86/apic: Introduce Remote Action Request Operations From: Rik van Riel To: Dave Hansen , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, nadav.amit@gmail.com, Rik van Riel , Yu-cheng Yu Date: Wed, 21 May 2025 11:59:08 -0400 In-Reply-To: <036f8679-485a-4c99-92e7-f271a972fbf8@intel.com> References: <20250520010350.1740223-1-riel@surriel.com> <20250520010350.1740223-7-riel@surriel.com> <036f8679-485a-4c99-92e7-f271a972fbf8@intel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 2EE43100007 X-Rspamd-Server: rspam09 X-Stat-Signature: yszp5kdwn71wthand6rewk5cspbrswf9 X-HE-Tag: 1747843173-480153 X-HE-Meta: U2FsdGVkX19qFsBfoutBrv56dM2s9BDM5XVn2ba1QfIYyzpFBqHNFL5NqkP3hp0pJ8DU5ZzONFKWC/nDxGbLt5LgBM8+oe+Cx9EoxpZhvXtwLUHr9T5YNfBFNLvt+oCr+SYJTCR6EENKJBTNhJGp3K1IHsTI6v0ay1HLFnTaELvPxFxhGMtgoUVY+pM95glTrcFCV14wz3g1I21/P2dwSyw55Z0yNgOMCfbtaiZabQlSy+gD+XUz+WJVC1ynfOPMWIy0FnJEPasDxFY9BMmGFP5zURVfKhuIPYZ1IPWPuHmOtnbswqeUNHw3+5TVNRrH7RtguqsdfLtuugr2FHgvL0HrD9mK3h/tIDmmCcmHlNPQ+YrIbK4cgsKJuc63pxXliA7TIyGKXmwrh+Qq2AWBbHGk1Nlp1Kr3uGt0AkuV5D1r4M4/S3Gi6d55iKGyHZdCQ0QSZonYJN4LN7deTR9JQEov+s/Y+ZeL7ES7MBs8Xq9byWKl3EWfxMx5IN3zu/w3yi/EU8mr6xJygvpO38kR6ZH/N4ZQ6G7wVTKvLs8PJOCSFIquOFLemRQPigDoKYliTpzO2lsxwnHuG7wWOD2v9IeNCqyKWhxgaFvxT2HgDUPH/uI2WFfPT03TBwwxFGt8NeCxEtkypRp0+2ufSddwpB5B7pro8/ku6UTVprGmV2a1q58QN8Mg8FPtnHKPq6UjZ87lNAZ/wKYZ8Y/1iZc0qSvhOztRE0Uf1ksVFenlbDC+ptmNBcnyrc0U8RFp/pdVJKAtpMrVpdKIBRUi9325wFfMkXRUWeP404qqqLNgcpbHPvYt3Qqgf5sO7ZLOD4yBJq1WSKRYLCERqS70cdkaerI6i/DFqvgyX9+yjtFDY8KjXkGCX+Uw39yJfnH4KbA7h68zwZagm8wxkD6MXSPVHxwTQziWZaDXyD9dQvJ0wdit62pOTmA04UGDVGpeHuxCUdc3tZqF+JbyHpV0aNz yh1WzpIT K6OXWUgnf1EmyFSi3myz59XJacs7ncX5iwPb1ww+qlU+Re4BWJe4ndj+Qekv5hW4e/3HYaPouLfPV4srUq/aKe4W7G4N0RJw/nu8H07Mf1FRkB37fZ00xG3AGi8pFMoxzptwOa4AOV9Oz1PGsh0tcXGLegFMJBidmcq1cmn42OAg4gqBRDJaIMdhYD7jYOwZe3TPkXFQ0VeM7Q4HKTyGDASaZd8B2YKIcv6cVaxAXVktBO34tX4ubC7A9JmIPYPup2JRbsKxqrx9YUIsBcHzwbAhVYOJJlUXW1Z9mmZp7hsZ+3UK8mBPHMvk8couSqMlTkj1Va0nC4nDolg+omK433Zzclw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2025-05-21 at 08:28 -0700, Dave Hansen wrote: > > diff --git a/arch/x86/include/asm/smp.h > > b/arch/x86/include/asm/smp.h > > index 0c1c68039d6f..1ab9f5fcac8a 100644 > > --- a/arch/x86/include/asm/smp.h > > +++ b/arch/x86/include/asm/smp.h > > @@ -40,6 +40,9 @@ struct smp_ops { > > =C2=A0 > > =C2=A0 void (*send_call_func_ipi)(const struct cpumask *mask); > > =C2=A0 void (*send_call_func_single_ipi)(int cpu); > > + > > + void (*send_rar_ipi)(const struct cpumask *mask); > > + void (*send_rar_single_ipi)(int cpu); > > =C2=A0}; >=20 > I assume Yu-cheng did it this way. >=20 > I'm curios why new smp_ops are needed for this, though. It's not like > there are a bunch of different implementations to pick between. >=20 You are right, this was in the code I received. > I feel like this patch is doing three separate things: >=20 > 1. Adds smp_ops > 2. Refactors native_send_call_func_ipi() > 3. Adds RAR support >=20 > None of those are huge, but it would make a lot more sense to break > those out. I'm also still not sure of the point of the smp_ops. >=20 I am not very familiar with this part of the kernel, but would be happy to make whatever changes the maintainers want to see. --=20 All Rights Reversed.