From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B6AC27C53 for ; Wed, 12 Jun 2024 16:34:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFB2C6B0098; Wed, 12 Jun 2024 12:34:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAB1C6B0099; Wed, 12 Jun 2024 12:34:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94D646B009A; Wed, 12 Jun 2024 12:34:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 767B46B0098 for ; Wed, 12 Jun 2024 12:34:52 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D7809A1EAF for ; Wed, 12 Jun 2024 16:34:51 +0000 (UTC) X-FDA: 82222785582.29.4C529C3 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf18.hostedemail.com (Postfix) with ESMTP id D1BF51C0026 for ; Wed, 12 Jun 2024 16:34:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=i4JhOuXc; spf=pass (imf18.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718210089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EtSsz+KOnqb1J9OrnqyEU8J0Ssy5VLPANqhbhuShfVo=; b=sACCRiinbrh1F1g+mcgXTP/bqLWdCIrAd2NcyzL4JPpxqOeg0mXAhO5utafLl1SmwoF9Ic qYpy51JF5nyBEVnBKAD08eF2M386i29GURJ7lf2h9EEuo8hoZChM+W6SPKLa5/7vcetz16 mqmFPG7BzFTyCN36nn5o16tSMOrZ++g= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=i4JhOuXc; spf=pass (imf18.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718210089; a=rsa-sha256; cv=none; b=7Do0RsELRGmeZN1XqWZ09VO3zuQM8klra/+R6pkgFGQhKn7HisYFyCkGURy/aOdxu5/KrN fHNoyvUjQUKxY28YKQ4mr3/bYCaC42SDURGak80JPITfCYzpYs9bNwfOxnYGe/IbmoZ0bj AEWTC3gglZnU2XIpI/5R/eZNuKduysM= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-57c7681ccf3so5126453a12.2 for ; Wed, 12 Jun 2024 09:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718210088; x=1718814888; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EtSsz+KOnqb1J9OrnqyEU8J0Ssy5VLPANqhbhuShfVo=; b=i4JhOuXc6YAe1PRC+l28MYkXPgceT89dnx1XZ2LnGNPaQmNLj76jYcgIEVKC/m6YTF R6sE5+xhOIIn+I5vHq9RN82uZbhDim4GprVyiwQ1rQ+rjW8r+I3gYaELaSEIpzqpa3BZ opXoLvZvGzHYUnPcRtOql2pt7Cu6aeXMxGnNC95U8Csh+7/BFcyJJLUBLgxP+27h14Pq KEcLMSdA/LFTWnOIeINoQYmNQgfHs0eU/GegZSTRr01CC+fbApNcDrQSIbc7Vv6hNOig dstyCOjwuJykjmbg081s6ZMnpIdWyX+9/rMAiHRANcBIWkOq/xst9LG03bjsPg6NguDE hDZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718210088; x=1718814888; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EtSsz+KOnqb1J9OrnqyEU8J0Ssy5VLPANqhbhuShfVo=; b=Di2moS9VA9LBy4S9gFTpxeI8eUdf6XlDcJaRsCkH13eKf3yUC4k/IZjOFiBPUkxvh9 9uUXDjW4SfCSoqS9sLXTcl5rdntmq1Qq6GOlEx+Rb87tTDrpuAseCjr7uCIBNcQlOhD0 56ps07OrFK6mu6CysrBSs46vRR5WVPBdueYbur38CZeEyIld36aR6zaDQIaEJXA1ZjpC gMMIvKb4dF1GXr1zRldsD8Qz5tqGxPouG2joLI4GVCKhiYXHZIRpbL3Jh47gj3tNKUUM 8J8fOfZSk3aaCNB8xXN0jFEPbJN4UJqxTQ010MYpy/TbhwehN0YpCG41rMiaXOdN/drv URAA== X-Forwarded-Encrypted: i=1; AJvYcCV3wrIq8NKP4pwvpGN9NqLJjNhcF5KGjr+aPvG1PxHrCXmBFbvHW1LDeSAFqFVYftGVphFRGkf45+xqFrcgjbdChbk= X-Gm-Message-State: AOJu0YwAZwCJSPF+aqlr1+/eeDdA1iYO4uoEO9i/MdM0R7I9EM6lmigz g+V/WB1YIcbvNeWk8zsxI3HmyOzE/cB9XZrotlPHdWhIuO1TfkSZ X-Google-Smtp-Source: AGHT+IG4uT61eIvoyqMgpgqvyw2H4NUbmEO2X3ZoJOvV42tIdhVbDOeKNtg7d9o2zC8TdNhQcH5fmw== X-Received: by 2002:a50:9fc1:0:b0:57c:73a7:da08 with SMTP id 4fb4d7f45d1cf-57ca9762e87mr1461728a12.21.1718210087921; Wed, 12 Jun 2024 09:34:47 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:eb:d0d0:c7fd:c82c? ([2620:10d:c092:500::4:e76f]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57c7cf18193sm6461175a12.50.2024.06.12.09.34.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jun 2024 09:34:47 -0700 (PDT) Message-ID: <4ed7f644-46c3-4a48-933c-04364c10484f@gmail.com> Date: Wed, 12 Jun 2024 17:34:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] mm: remove code to handle same filled pages To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, shakeel.butt@linux.dev, david@redhat.com, ying.huang@intel.com, hughd@google.com, willy@infradead.org, yosryahmed@google.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20240612124750.2220726-1-usamaarif642@gmail.com> <20240612124750.2220726-3-usamaarif642@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: D1BF51C0026 X-Rspamd-Server: rspam01 X-Stat-Signature: cuixantgrb6k3siyffi69yx6qgzkrke6 X-HE-Tag: 1718210089-470940 X-HE-Meta: U2FsdGVkX18OhgeKfuXr4DassoaJ44JO80SbzqOjCWtiZMqaVN/EfckoYpWSiy3l8jakHZR9TvUgF6fYTCuWpDbNFVV/JgkVunvXNNnjmnZDC2zC17pxn2zfK7Jt/MbhhX9T2ZLRJZDCaav6Pfm8dKHNcT5wwa3FnFCPzRGcHzSm3ivxLaJKYpWLVPpO/QwKGgLiM1qXdGQsaRnjwU7gXk4zbPklIp0Lbwiz96IXfwD53RheHcA9SMc9+wGKaJ0Ov9VvUq+5IYt/K3IJRpxbA0CT2Bdq7f6eQwFP0WUY34e7z6X8CirYVkLPfDrsGZ92FVD8ROVop1CMXgpCx3GqKJS4FdaW3nH1mqxNym6+d5vGiYMnwHmeixCeWHpwMqfsCbZ/eOj1J18hR5XOdhCvi+BYoZ+4GHE8yKO9Qo2n03LIyDgCD7xedIq7lhx7WafxBWQ/cloR8U80j+zibOoxW0qqdi6fjm3WHzlhrqHVEM8YMPhif/HJplK1LVsiQWW34hrUQYp2Pc+SbZcc3QacQSRrZ3jVULMkrKIUOA29DAL7Frn7HCBzFxD5BLdC+NgdFJU+jcOM8XnWZpPw8Hnx/kwIS2JaBEwPq5QqM/AKyevzryYNo3vLWkqGnDnGL+cqrmE/Z/GdFfW819jtHH9CKKbZcjQMtBHG63XO7k+fNFGMyR8j5t2OJulyjFJ3SuAlQp873E5N4mVRG46lKQWzjI7KwI6xPfcFHwln94HaeHbV+kbK+j4JnSIDye7Afcg8BZahl+i6dmuRX3zB9/0aFSUKMARok+JIR6Vo0SgHsHcqNuJbxrczWeplKgkqGOU9AcZDamKzYo5FCNb9y6Wfdm9BZvLkiuxk+dFogTutrwqCBU25Pr1WZkiyCiDrsUxqeAYPYFz+Ac/EcpfY17uDsLzmkif5+ipHZzdqaQgE4svjdSf5shnlQQ1R5bT35dtMWF6orjbcA4B6S1mGvV3 jJBOP/ct E+U0/0Nl77rIYlkqid6P9m7s24U9HrvgOecOHYr1BdfPS3egT99lzueUAxo0aVGACBw3LBOKhigISWKN9JbccUI32PT+suW7fr4Q3gLye2Onu99tEjhs/tOZJ6NbGrElx9RJQlxVKUyyScGABbba+IKwTsF/jKSLG1vXo4cnqrM58EARCG/pOEmErsdoiCOVy8YqgoOIlPFkdyWiMGP+jshmyAzmQWdeJyVxF0975ifgbw915QKwZODD5GpLLS7bJMAQ/C8Sc/CBhjUyAUWNlgTl+pnMQ9gQSet64r0oqVWRC9rHiq/b3WFTRf2y53kMc+4ImfDVG/JjepXBTmNjyogpR5UjEE4pzBTJsKvIHAK+cjQB5bkIBlvUPw6nNvFMsVv50DzAyJAdPXG6zUY/fI0sdrW8C/zPf0/lTs8S3Y4HKSlfuMmbDOARH4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/06/2024 16:09, Nhat Pham wrote: > On Wed, Jun 12, 2024 at 5:47 AM Usama Arif wrote: >> With an earlier commit to handle zero-filled pages in swap directly, >> and with only 1% of the same-filled pages being non-zero, zswap no >> longer needs to handle same-filled pages and can just work on compressed >> pages. >> >> Signed-off-by: Usama Arif >> --- >> mm/zswap.c | 86 +++++------------------------------------------------- >> 1 file changed, 8 insertions(+), 78 deletions(-) >> >> diff --git a/mm/zswap.c b/mm/zswap.c >> index b9b35ef86d9b..ca8df9c99abf 100644 >> --- a/mm/zswap.c >> +++ b/mm/zswap.c >> @@ -44,8 +44,6 @@ >> **********************************/ >> /* The number of compressed pages currently stored in zswap */ >> atomic_t zswap_stored_pages = ATOMIC_INIT(0); >> -/* The number of same-value filled pages currently stored in zswap */ >> -static atomic_t zswap_same_filled_pages = ATOMIC_INIT(0); > Can we re-introduce this counter somewhere? I have found this counter > to be valuable in the past, and would love to keep it. For instance, > in a system where a lot of zero-filled pages are reclaimed, we might > see an increase in swap usage. Having this counter at hands will allow > us to trace the source of the swap usage more easily. I *suppose* you > can do elimination work (check zswap usage, check disk swap usage > somehow - I'm not sure, etc., etc.), but this would be much more > direct and user-friendly. > > Not *entirely* sure where to expose this though. Seems a bit specific > for vmstat. Maybe as a new debugfs directory? > > This doesn't have to be done in this patch (or this series even) - but > please consider this for follow-up work at least :) Yes, would be good to have this . There are 2 things to consider: where to put it in debugfs as you pointed out, and where to decrement it. Decrementing it will require to test and clear instead of clear zeromap at different places, so might be a bit more complicated compared to how zswap_same_filled_pages is tracked. I think best to keep this separate from this series.