From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3DE6C6FD1F for ; Wed, 15 Mar 2023 01:27:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC2A16B0071; Tue, 14 Mar 2023 21:27:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D72336B0072; Tue, 14 Mar 2023 21:27:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C39986B0074; Tue, 14 Mar 2023 21:27:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B01176B0071 for ; Tue, 14 Mar 2023 21:27:49 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7E039A0F3E for ; Wed, 15 Mar 2023 01:27:49 +0000 (UTC) X-FDA: 80569395858.05.45E7DDC Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf29.hostedemail.com (Postfix) with ESMTP id 79DD112001E for ; Wed, 15 Mar 2023 01:27:46 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678843667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VBItBzyV1fughgbBBcJEMoYhKqk2JCs72WlzNUoGjmU=; b=7MCjFnXSfrFDXoE8lIjM+qrgoclB0ipY7yueTagcfkpnXqOsO9ECcSjpHT4kdjpRzauiJh TRmHLWxKfG5RsAn/7lKRMvAUlYVoqRvBVWXl/B1rd/eB2W3V79Tc7S1/ZDg7i1bx3g3Iww rcxj2xsPXA+5DENVUHkv3rvT3swQgjY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678843667; a=rsa-sha256; cv=none; b=2tnXLYBDM8w9zfIBwaleihiNctY7OO8vVoat0pugkI+0q7/9zOjSMmXYzH71Iv4u8WqmMF rjzTqHgGI2uUUH3Itjy5hfv823X5cFejj2z1ocWDAbNOgV4yC90bgCOklC/NIXxL3SHrwb SGDTMJ9Mn0FfLzWtoEsNxyGNIoIIAWY= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R801e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0Vdtx.Pd_1678843662; Received: from 30.221.128.163(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vdtx.Pd_1678843662) by smtp.aliyun-inc.com; Wed, 15 Mar 2023 09:27:42 +0800 Message-ID: <4ed1ebe6-0579-1f1b-6dae-7fd04f40b3d1@linux.alibaba.com> Date: Wed, 15 Mar 2023 09:27:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2] mm: compaction: fix the possible deadlock when isolating hugetlb pages To: Mike Kravetz Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, osalvador@suse.de, vbabka@suse.cz, william.lam@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1bc1c955b03603c4e14f56dfbbef9f637f18dbbd.1678703534.git.baolin.wang@linux.alibaba.com> <20230313170838.GA3044@monkey> <20230314172725.GA4769@monkey> From: Baolin Wang In-Reply-To: <20230314172725.GA4769@monkey> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 79DD112001E X-Rspam-User: X-Stat-Signature: jo49igsc8jiy13xpnuhkz5nk5eyfk8zg X-HE-Tag: 1678843666-378575 X-HE-Meta: U2FsdGVkX1+Op3psGy1fOsw4S8RNhZrzJdFvLaF++Z3wU/AzdG8s04NmC0qKtSytvRIECf1VOgb3+z2xlMNi3le4c+1O2P4fCz1Xrmy46zAr42c2chXR5oIsAI2H1X5eYLaLhYjXRm9Mk/QSNK0LSvCwjp+Dm5lgH01wrr0e0oCgEhafpCjdQDxEsZEEL1DWwNYrLsBw1Wo8fr5QiY9S5fYXoyzkJEO63vn58Bw3P6xDsN9MBcxdQ5FByABIKqZRlDEpTYEMxyLeg2BK6ZwckfHPZzbEI6IBPck0U6OUgyh2gO1hCogKUoPioHjg32zU68dQJs8ScBRDqQ1jp9FUnma4CfJkxknkS1QLNEsTAEV4VkEJ4l2gN+cSCNiG8uTWnyyMI9B4HRQ0o6MU5r90sfjfmh36ZtdnGZRqSFPheR/sp+syg/leqPnPSwj7vTUAX87gVwSHuzfML01ceBHiGgX3as6j60OWICd8VN/j/U0J9kEH/Sc+aWbWDRn9FZxFoxBpqMjzvSP7whtUrTWi20DmHGzRRuCIDxxqxL655hLmV6+ANXSXyB/tTedmPy+p6u3okQB/qB6jb6ZDfzb6L+Pp1iJnq6SATBP8admgXYU5SddWQ6+eKxs7oZLJ4FEAstMClALItFTSFM9zOzm0YwZcy36ULuJZ02pLdgc1fEGnovyQgE+9oyuM0egOUdjfwGUii366Y4SabbK1T1zBs8jTXHnYOVfr9CAoB+WnswYgp4h2oC61fp+7NvuP746tuhhJagI1CN9+L2RpqOpuYDiRbaBV+yFdM+xT+9k9oUPiuVE9GwoK/KdT72qR9wq0634QZfkiHvJkK6h75H+RE1KtPrwtDtfrnPDX7Z7N2WysdN/9sbTCRRUugFoCV6OaDbwvnTRlFPFgTCPEBHuImVDQOpdYkNLyu0t5X8qBuERz7zWz/qGjq615wgNmH0ztk3qbtedKQ6dr/O1WXnM KY79Crxe keV9wBn+3kmASd1uTplSaXS+6UlmsF4kuN/Jj0q53dlD3MuGEtB1lvl7g/GAHyLiytf6tOttKuNPfS+rI2a+GBDgiq/tKwQb2JU4uHhLC8ekjseHdrHrXnwvVZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/2023 1:27 AM, Mike Kravetz wrote: > On 03/14/23 12:11, Baolin Wang wrote: >> On 3/14/2023 1:08 AM, Mike Kravetz wrote: >>> On 03/13/23 18:37, Baolin Wang wrote: >>> >>> It would seem that the pfn of a hugetlb page would always be a multiple of >>> COMPACT_CLUSTER_MAX so we would drop the lock. However, I am not sure if >>> that is ALWAYS true and would prefer something like the code you suggested. >> >> Well, this is not always true, suppose the CONT-PTE hugetlb on ARM arch, >> which contains 16 contiguous normal pages. >> > > Right. I keep forgetting about the CONT-* page sizes on arm :( > > In any case, I think explicitly dropping the lock as you have done is a > good idea. > > Feel free to add, > > Reviewed-by: Mike Kravetz Thanks for reviewing.