From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0E2C282CD for ; Mon, 3 Mar 2025 07:15:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91B10280008; Mon, 3 Mar 2025 02:15:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A343280007; Mon, 3 Mar 2025 02:15:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71D61280008; Mon, 3 Mar 2025 02:15:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 57D77280007 for ; Mon, 3 Mar 2025 02:15:43 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CC6A314035B for ; Mon, 3 Mar 2025 07:15:42 +0000 (UTC) X-FDA: 83179379724.27.D820729 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf19.hostedemail.com (Postfix) with ESMTP id 802781A000B for ; Mon, 3 Mar 2025 07:15:38 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=H+m+Kois; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf19.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740986140; a=rsa-sha256; cv=none; b=zQgUrVnslpSlz/6KZ238QtEQ7quNq1iRbnBfmMxklks7qEpvDBnuRNX/W2te1h73Dh0ir1 IIh8OTNxLYIf2iCUkuiWpwiZ6lstWBkGJMj7oAVpwNu2kX0nhAs1DSDn/CbQinEQQZgArA MBN2Oe+4Qhafzr8XMUp6ft2TzcyazqI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=H+m+Kois; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf19.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740986140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z3xf7HJyOLISUqnBF4lpknQTsncyxq6apcdgU1Q2bwI=; b=CJh5tlo2X2ZsZ0ybidnp+vR5icdZYx2u3W0eSMZp5/4akmjv4c08e2HAsNICinvHPkUwpB oxsDuZYmnSTohw7K8unjcrnI7CpA38iZRAcOq5R3TBBnUj2VjlBo6ewYltddRoevZZX8wP q/mGveNjjw5yT8PDRljSID+GUtX+CsQ= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-22328dca22fso60768505ad.1 for ; Sun, 02 Mar 2025 23:15:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1740986137; x=1741590937; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Z3xf7HJyOLISUqnBF4lpknQTsncyxq6apcdgU1Q2bwI=; b=H+m+KoisgnfFNXXwUkizm1DSsrx1H+tQ70aJr2hMkR7EoUo6ogEBSLhYNpIbrPAcvq 10O5OASi2volRsVUCUulk69tmljCpx3JpFD+os6SDduAOqlp0nsnFyJ0cdjmhYOmcIzR u0XUkoeLEtDVZcxB5cdOglX8MSvitNryIQ7tOxyHf5Vd/Ho2D/uRNqT0VSL3p8BSdeh0 mVJQ/Fw8j9aPff2vIQy252xdCc/JelmkCAjTXso36I4+FcNcQtcR0Yq6DXKeduuAbr9Q Jyg/yticiTX/mI4yYqzxPxt4/BccOMZ279aGMUXO7H7wu8OunjB0doS53fHOYUcIPEn7 lwRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740986137; x=1741590937; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Z3xf7HJyOLISUqnBF4lpknQTsncyxq6apcdgU1Q2bwI=; b=ErAzYPVUdcuknymRCb8xYtg000e1iTIIG6ENiXmzlt2u9Lm+SKOeZizdYalIeX7DcE HAmmym8BdoB7Yk2d9EJFUmW5uR+BVXG9Y2khfZlPuJNMHUBK6Q0u6jcLmtiA6PpJzRdx pp7LPQOr0G2tYKuops4R9zIOcwG2mjJhrPe5r9Yd99CCf546vrCihI4rLPjn5o+Y/xQC b90lqZbYSfChg7mdeU9QwufB4Sc+HX1kNmJWax/1ULZ5emIl2uum0+9EbBa3aj7vPEeO ch4z19arJNnEGcSWuXh3ndLaTOm8DT/tPDOhM2kAT99HchybfljjvFXiass/x8ppusEG tCow== X-Forwarded-Encrypted: i=1; AJvYcCUuzbcJzMtgHIY2sH4cJAFnkeGJzd5Ezd17acD/vRswGXsF7LoPFcAIsSQ6qJOzATObxheWSlVSSw==@kvack.org X-Gm-Message-State: AOJu0YzIghC/YZ3eS/AyIx88noUzQ5wupeMGy77ikHJf1veN/YZ0doSu rBYWnqsQqlHW4Dz3TxvLsfccEgwcEGV5aioqOZoh17g3ijoxaImAcC8GRwMYEvI= X-Gm-Gg: ASbGncurkXI1tnQbVvo4yZ6Li8JgyYqtJIn+oW5fHDXYxOl/JZ1GOqGmkkq7EFcNg6R n6Awbz7RBbHVLKZCZhR/ZdfogGjy1IHC2526V4wf5nn/RbhY7RjfY+4TwfU8T/u/SIbBJfoY1Ze BmUwh30+4OGhRwmWAboMBuyVE9xt1IboU5PhiTkMH5GsdEZxPbT1iyTqxnz99rUVjcBxwZBqnCE 1YmesOwvDp0NBWKciNmqWaTQVH7hlOEdV2hdGEVjVD7ApV1DVAQVP4pS8NmMOQpuoLFy7/dJbRO K8GfAUBXuN8xMez/4g+yJbNqj4oyU0lmP9afjqAxKFArOm8bZuwNXzNzcA0bhCTjBNvX5Q== X-Google-Smtp-Source: AGHT+IFFzAQLESy+9XTrR371K4l9s8+Ug8zXVzf/oXiEIXCRNjxwSBTp4Oh3Iq6eaMxuwqzsZm0CFA== X-Received: by 2002:a17:902:f64a:b0:223:5645:8e1a with SMTP id d9443c01a7336-2236926727dmr181629675ad.51.1740986137075; Sun, 02 Mar 2025 23:15:37 -0800 (PST) Received: from [10.68.122.90] ([203.208.167.148]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2235050ce10sm71093955ad.200.2025.03.02.23.15.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Mar 2025 23:15:36 -0800 (PST) Message-ID: <4eb93ca8-7526-4709-b43e-2ed9e5583e3b@bytedance.com> Date: Mon, 3 Mar 2025 15:15:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] riscv: pgtable: unconditionally use tlb_remove_ptdesc() To: yunhui cui Cc: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org References: <9025595e895515515c95e48db54b29afa489c41d.1740454179.git.zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 802781A000B X-Stat-Signature: jgaqso17hxexyzmkxff6pu8pp88u6oye X-Rspam-User: X-HE-Tag: 1740986138-456315 X-HE-Meta: U2FsdGVkX194wmUcLuBPqT33Ld+P90FixAy6S7Cnr4RHKpP5T/Hj53O7vPJEspzSi8IKmplc/S4Z/h4okABM/JrjiW4vnPM5jaO12E/FK7MuIudNRWdEa7+ubl2uIpRfKe7t46cG7ZZoB3GUB+/RB8RmQm8yO4YiQHM7iEmBkMD7wZ/sQZ1J52zHLXXtcjydFowWDuceLkuIIEcXq2st6n9PqQ3asLRfdSI6hD2nIqZaWtUgeVQqARjJj9oe/1pXDeEoOMz8oje84gT+oYpJ98nLk1dwqUUq1Geg/wmvjTcH8irPMg1Rh6N3OXDnUTsU+jTxKMPlDDXRACQLKIbO2LOkEEXERu9gjy9ex1LOlY3TCsqV6oFm122Jk9LdNnh4vJ4RfAOdhT+Fsv/+tFXryp9AoBQGxjXSZLRae7REFXUpemaD1BDvLI21W3LYZLjQHN0iYqUt6EaC3vR0a+s8hQoE1o04p91mCqIVzamhnASUQYQzZTOAY2kRscKOdBHNKlyYfUVE4ahwRrRuRT4AnvYnyeOnAmmaULs7r/wPJTbS5oRTQAcw+nC7XveVClvOc6U7l7+ntxwWbkGdUnQdCkAczjSJLp5ffEaJRpLIKPWB7e2TmaPEjSf6jobjbX7NlyR6DXtxvi2Ppy8Rh17MTJwC0LB3qDOTDxTR1LPGgZBj40EUBE3rGACvhF2KCN9FVAvSS2Uo/oVXaGh0IWBJiNdxNqkNaqi+V+Ja9bNR+u/OSWcBkPUdxxJbv4cB9j8p713gAgkvGTcwCCLNAs0elSkYVWBbq0MuecYPq8g+BunUgEGIPK7H/6gfF3cgi86ttUPoF5XRVrAOR+QOcFu5O1zzZmGiocvfDsBG2AePQ3XtlcxWHMJDmzlesEPSbKkUXQvkwcTHM68sylCq28JWxQoMmHZR6e6YgAM9uaBlubwyi2FYWPiJlquvxQmRamoCFJFYFVi8A6IruKQ/aQu 5sZh8F7S F60ANSsPeyc+lw7Z0VZN0gHmQjNasPHKkcj7+ffVWqEVNB8yydDjlsGuDs2kF9yKErCIaLZBYWSKkl0P5FzxL803wjt2UYW/07zQgfhpQ0JP1OWZtew/WIsasvwueIpHNJHwINPDaUKmQkbCOhSeopHEp1Id+4NieXg6fQrxgdu4D683PD7WWoeTThgzQVVf6tsSMwa/KinZ+li3IgL9g3gVPqLmyfbTV+UbHLTUn98p8D3Q8dJim/s68T56J7mbzoswOkRJV+pbTLnD6lUNXS144BYLi3Z8uvUO6eCerwQIE+HyCbpr1g54pxpXLM0GCO1oHQVEw7CPPhFPARxJZEm8dC9efiCH+SqPCj6h60j4B1jdniePBFUKThjsqat8GobbdxB8qDkDndKLTmDuuHrWRE/md/9QaIIippFDKv1nra506NdY1A6Sz+59IoG0xjE05a+gYLmKwh7h8DdjtO1Ny3CkmL/+f1xZ0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/3/25 9:45 AM, yunhui cui wrote: > Hi Qi, > [...] >> >> > > This set of patches mainly refactors the remove page table function > interfaces. The comment "riscv_ipi_for_rfence" has been removed, as it > was no longer needed, and this patch handles that. > > Additionally, whether riscv_use_sbi_for_rfence is true or false, page > tables can now be released using RCU. This patch changes the previous > synchronous release logic (for !riscv_use_sbi_for_rfence) to an > RCU-based release. > > So, Reviewed-by: Yunhui Cui > > Based on qemu-system-riscv64, I tested this patch. The log is as follows: > ./gup_test > TAP version 13 > 1..1 > # GUP_FAST_BENCHMARK: Time: get:663365 put:117 us > # ok 1 ioctl status 0 > # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 Nice. > > So, Tested-by: Yunhui Cui Thank you very much for your review and testing! > > Thanks, > Yunhui