From: John Hubbard <jhubbard@nvidia.com>
To: kbuild test robot <lkp@intel.com>, john.hubbard@gmail.com
Cc: kbuild-all@01.org, Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Christopher Lameter <cl@linux.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.cz>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] mm: track gup pages with page->dma_pinned_* fields
Date: Sun, 1 Jul 2018 22:05:49 -0700 [thread overview]
Message-ID: <4eb75815-9246-3185-d77f-7718e02bef7c@nvidia.com> (raw)
In-Reply-To: <201807021030.EyzuzHW4%fengguang.wu@intel.com>
On 07/01/2018 07:58 PM, kbuild test robot wrote:
> Hi John,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.18-rc3]
> [cannot apply to next-20180629]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/john-hubbard-gmail-com/mm-fs-gup-don-t-unmap-or-drop-filesystem-buffers/20180702-090125
> config: x86_64-randconfig-x010-201826 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All warnings (new ones prefixed by >>):
>
> In file included from arch/x86/include/asm/atomic.h:5:0,
> from include/linux/atomic.h:5,
> from include/linux/page_counter.h:5,
> from mm/memcontrol.c:34:
> mm/memcontrol.c: In function 'unlock_page_lru':
> mm/memcontrol.c:2087:32: error: 'page_tail' undeclared (first use in this function); did you mean 'page_pool'?
> VM_BUG_ON_PAGE(PageDmaPinned(page_tail), page);
> ^
Yes, that should have been:
VM_BUG_ON_PAGE(PageDmaPinned(page), page);
Fixed locally...maybe I'll post a v3 right now, as there were half a dozen ridiculous typos that
snuck in.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2018-07-02 5:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 0:56 [PATCH v2 0/6] mm/fs: gup: don't unmap or drop filesystem buffers john.hubbard
2018-07-02 0:56 ` [PATCH v2 1/6] mm: get_user_pages: consolidate error handling john.hubbard
2018-07-02 10:17 ` Jan Kara
2018-07-02 21:34 ` John Hubbard
2018-07-02 0:56 ` [PATCH v2 2/6] mm: introduce page->dma_pinned_flags, _count john.hubbard
2018-07-02 0:56 ` [PATCH v2 3/6] mm: introduce zone_gup_lock, for dma-pinned pages john.hubbard
2018-07-02 0:56 ` [PATCH v2 4/6] mm/fs: add a sync_mode param for clear_page_dirty_for_io() john.hubbard
2018-07-02 2:11 ` kbuild test robot
2018-07-02 4:40 ` John Hubbard
2018-07-02 2:47 ` kbuild test robot
2018-07-02 4:40 ` John Hubbard
2018-07-02 0:56 ` [PATCH v2 5/6] mm: track gup pages with page->dma_pinned_* fields john.hubbard
2018-07-02 2:11 ` kbuild test robot
2018-07-02 2:58 ` kbuild test robot
2018-07-02 5:05 ` John Hubbard [this message]
2018-07-02 9:53 ` Jan Kara
2018-07-02 20:43 ` John Hubbard
2018-07-03 0:08 ` Christopher Lameter
2018-07-03 4:30 ` John Hubbard
2018-07-03 17:08 ` Christopher Lameter
2018-07-03 17:36 ` John Hubbard
2018-07-03 17:48 ` Christopher Lameter
2018-07-03 18:48 ` John Hubbard
2018-07-04 10:43 ` Jan Kara
2018-07-05 14:17 ` Christopher Lameter
2018-07-09 13:49 ` Jan Kara
2018-07-02 0:56 ` [PATCH v2 6/6] mm: page_mkclean, ttu: handle pinned pages john.hubbard
2018-07-02 10:15 ` Jan Kara
2018-07-02 21:07 ` John Hubbard
2018-07-02 5:54 ` [PATCH v2 0/6] mm/fs: gup: don't unmap or drop filesystem buffers John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eb75815-9246-3185-d77f-7718e02bef7c@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=john.hubbard@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mhocko@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox