From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCEAC00140 for ; Wed, 24 Aug 2022 12:57:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BC7694000A; Wed, 24 Aug 2022 08:57:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26C59940007; Wed, 24 Aug 2022 08:57:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1344D94000A; Wed, 24 Aug 2022 08:57:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 043F6940007 for ; Wed, 24 Aug 2022 08:57:43 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D3273C0BB5 for ; Wed, 24 Aug 2022 12:57:42 +0000 (UTC) X-FDA: 79834487964.09.B0F01AE Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id 5EB60C0031 for ; Wed, 24 Aug 2022 12:57:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EEF85342F9; Wed, 24 Aug 2022 12:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661345860; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qEYREoYpO2r0uaJb050xCbUhHiBkt0oP6Nue5dyx8Bg=; b=XNzrs4baLaYIrNDYGyvKBQUndJ/ajnq951RFRjc1w1wSyolWme7nbLjtoL2F5/yJNMJL6O ldoNCms22OK6THaxTTjcshjsIqCPa+ezH7xYgWpjieB9VlRvCEYya99ch/2CyE8D9S5tZh D/t2uqLG08BAp42Z/8NyH2o8Ss7C0Q4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661345860; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qEYREoYpO2r0uaJb050xCbUhHiBkt0oP6Nue5dyx8Bg=; b=Kg+ugPo9eK4xzhYH8bzYgqzk6lmy85vnvGKjOmqPWdisVhlFfzOSALpsw94uByT0HtVVGT ZpAnNVnD1cRM+MAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CA9AA13780; Wed, 24 Aug 2022 12:57:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8OEHMEQgBmNdXgAAMHmgww (envelope-from ); Wed, 24 Aug 2022 12:57:40 +0000 Message-ID: <4eb30402-395c-6cb4-ab1e-a008c4bf32f8@suse.cz> Date: Wed, 24 Aug 2022 14:57:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [vbabka-slab:for-6.1/common_kmalloc 12/17] mm/slab_common.c:1023:7: warning: no previous prototype for '__kmalloc_large_node' Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, kernel test robot Cc: kbuild-all@lists.01.org, linux-mm@kvack.org References: <202208241004.jZykmQOH-lkp@intel.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661345862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qEYREoYpO2r0uaJb050xCbUhHiBkt0oP6Nue5dyx8Bg=; b=I7DDfEuHlNfOko6r/4IEKG+Ys2Fjk37qq/bYgbpypPU3Y59WYGzMMigkduluq68E+ooePe PnRjEZhsFYBaOBqDP8AehDIuWSp3sv0r6a48nkFrZUths8yGYN1cTtPWOZ9a5HaxhrwhoJ WniiDgPg08SGJa0oP9tldmbFzH0QLcw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XNzrs4ba; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kg+ugPo9; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661345862; a=rsa-sha256; cv=none; b=GArMHErkeYhWO+Tip5/uoElSYE2/a2bZzXoTkg+Yy28zeDiiOtLnqtituEay1y7obGOulP bSkGFNAo7501favEl4E199iQzUv7pycZqLm+h6GJGRU7SL8Z4PBJn9Npyru1A3NWSIgP/a UHqSJUtOTUlp8AjxfzT/50frgc58rZg= X-Stat-Signature: gyqty8a4tzudoeni3urixss4bun8a4at X-Rspamd-Queue-Id: 5EB60C0031 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XNzrs4ba; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Kg+ugPo9; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1661345862-985946 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/24/22 05:49, Hyeonggon Yoo wrote: > On Wed, Aug 24, 2022 at 10:46:55AM +0800, kernel test robot wrote: >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git for-6.1/common_kmalloc >> head: b261334803b44092acd06be3c9f32c46af818359 >> commit: 79c7527b9805edf14c952deca45de60a8a06a414 [12/17] mm/sl[au]b: generalize kmalloc subsystem >> config: x86_64-randconfig-a015 (https://download.01.org/0day-ci/archive/20220824/202208241004.jZykmQOH-lkp@intel.com/config) >> compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 >> reproduce (this is a W=1 build): >> # https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git/commit/?id=79c7527b9805edf14c952deca45de60a8a06a414 >> git remote add vbabka-slab git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git >> git fetch --no-tags vbabka-slab for-6.1/common_kmalloc >> git checkout 79c7527b9805edf14c952deca45de60a8a06a414 >> # save the config file >> mkdir build_dir && cp config build_dir/.config >> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash >> >> If you fix the issue, kindly add following tag where applicable >> Reported-by: kernel test robot >> >> All warnings (new ones prefixed by >>): >> >>>> mm/slab_common.c:1023:7: warning: no previous prototype for '__kmalloc_large_node' [-Wmissing-prototypes] >> 1023 | void *__kmalloc_large_node(size_t size, gfp_t flags, int node) >> | ^~~~~~~~~~~~~~~~~~~~ > > Oh, I did not add static here. Weird, I didn't get this warning even with W=1. Only the kerneldoc issues. > Please pull: > https://github.com/hygoni/linux.git slab-common-v4r1 > > Fixed warning above and also fixed wrong comment (@objp in comment but > its name is actually 'object') > > git range-diff for-6.1/common_kmalloc~17...for-6.1/common_kmalloc \ > slab-common-v4r1~17...slab-common-v4r1: > > 1: 0276f0da97e3 = 1: 0276f0da97e3 mm/slab: move NUMA-related code to __do_cache_alloc() > 2: d5ea00e8d8c9 = 2: d5ea00e8d8c9 mm/slab: cleanup slab_alloc() and slab_alloc_node() > 3: 48c55c42e6b8 = 3: 48c55c42e6b8 mm/slab_common: remove CONFIG_NUMA ifdefs for common kmalloc functions > 4: cd8523b488ec = 4: cd8523b488ec mm/slab_common: cleanup kmalloc_track_caller() > 5: 0b92d497e03a = 5: 0b92d497e03a mm/sl[au]b: factor out __do_kmalloc_node() > 6: d43649c0f472 = 6: d43649c0f472 mm/slab_common: fold kmalloc_order_trace() into kmalloc_large() > 7: cd6d756d6118 = 7: cd6d756d6118 mm/slub: move kmalloc_large_node() to slab_common.c > 8: fe8f3819416e ! 8: ec277200c5dd mm/slab_common: kmalloc_node: pass large requests to page allocator > @@ mm/slab_common.c: void *kmalloc_large(size_t size, gfp_t flags) > EXPORT_SYMBOL(kmalloc_large); > > -void *kmalloc_large_node(size_t size, gfp_t flags, int node) > -+void *kmalloc_large_node_notrace(size_t size, gfp_t flags, int node) > ++static void *kmalloc_large_node_notrace(size_t size, gfp_t flags, int node) Hmm this (and following changes to kmalloc_large_node_notrace) seems to be wrong, it's still called from slub.c and declared in slab.h at this point. So I've fixed the warnings up locally and force-pushed updated for-6.1/common_kmalloc (head is now ba5801e322), please double-check.