From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7328C001DE for ; Tue, 15 Aug 2023 16:58:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 189A994001A; Tue, 15 Aug 2023 12:58:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 144228D0001; Tue, 15 Aug 2023 12:58:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0294994001A; Tue, 15 Aug 2023 12:58:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E66258D0001 for ; Tue, 15 Aug 2023 12:58:11 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A87401A0252 for ; Tue, 15 Aug 2023 16:58:11 +0000 (UTC) X-FDA: 81126946782.20.7AEB907 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf22.hostedemail.com (Postfix) with ESMTP id CEC9BC001C for ; Tue, 15 Aug 2023 16:58:09 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=XbjqjpsI; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692118689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tnCNsZzQKHd1BrFY1oWDGUc4TVT5uPvYLedMK4qcLgc=; b=hGp0E23PtavbCXxzlRYDKjoB2v1vZiPF9RZzAcgC6XJJNNFwCrwb/iPEpAjy/hTQpGDxj3 k/d7ZqUL26bf/QlYdF3Yr7BedyQ4+ym/OlR78RQe7vm3fFVM1Q00vDPfNSU9Bo0+NNJIHH t4sXC9WBjW3n9ktS6PRTFkbXWCDojvU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=XbjqjpsI; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692118689; a=rsa-sha256; cv=none; b=ZT5I9RAGcUdPxRPFf2Ysce4+F5c1z+pSa/dpXVcFbbqdxAUXAirBGwWBnYUAYlaulYcEwN qInspJ9i+RXz+lodfrSl5a+i2HBr9qj1HymA393zGCer7O2vR4+wCIa+gI30jENcPfy/I0 oxsb9hyXMolabdTCnPMDDznZ9y4qJ0o= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-583b3aa4f41so58814757b3.2 for ; Tue, 15 Aug 2023 09:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692118689; x=1692723489; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=tnCNsZzQKHd1BrFY1oWDGUc4TVT5uPvYLedMK4qcLgc=; b=XbjqjpsI71gp//EQ1eJbjr8avsu9PxVQ4cMJSdHMllwrU71bh1AwI+lfPTewdd1hAh 72IUrt12Hfo6zZtI2pH8ojFuNpnKfm6MJuGlf33I/wny5u4jdsp50jRL9ATse8fnSq0W fjQdK1ZWago54M6vo7o6IQ4xl2fSKlGU3Swka2jM1GuHQuuAosZYki/kJEEPU/IeZ4Yt qRQoBQqObZq6B00/rpwRuHT2zzuoSWQZTqKNGNmyR9j8xsdPFHLX8sh9SFaThgxauhe9 cIDCONLFtGTipSeCnK8eRJdXZqWODoFwzhdFZ1UwEBwJ/84YyXkFNrxhJO8JUUtaZHpN WDtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692118689; x=1692723489; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tnCNsZzQKHd1BrFY1oWDGUc4TVT5uPvYLedMK4qcLgc=; b=LPxwK2BKyo9ZWqgB3/yfoZQazLbbpXhTyAdjhn92g0BRypHv1znaySdu10jo+fAqvx YCMj7NSnsw1q8ssek5nvDmVESPGlfbEnQVO0cYwurcKtug3925a9br4k9+EF8njPEVvj AMDxD4KIVD7RqFrT4DGF704najbhUUP5DzNrwLymjcKhnS1cQn8C1K7VqqDaFOiA5mKr LOCGoWdCR9f39h4u03gS+Zbl3QgLfKhaTlwjWezVZDtrszo8UPnNiTYblPRvuz4bEyLi Lp9v5qQ6Ur/Br+p2ApaVEKBzvniKQzorfcjpJjCamRf9LzTCt7kaC7fqSWh1VfQyS/OP ByBw== X-Gm-Message-State: AOJu0YxH0Lp5Wt9snLWgmpvA2NwcWQyCh31/qz2Hm1Uorj9xxMpxe6OP TVJTcHxkoe9W704Ky/t+bds8qw== X-Google-Smtp-Source: AGHT+IFJGFiIgKDeEIyyMWYkgpMldRTYMlRr9sSPTqQnRu7geuQrgMlURQTpIAgEUTGzf+/pSwZJSg== X-Received: by 2002:a0d:cb4d:0:b0:56d:1528:c56f with SMTP id n74-20020a0dcb4d000000b0056d1528c56fmr14474200ywd.16.1692118688806; Tue, 15 Aug 2023 09:58:08 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id n129-20020a0dcb87000000b005842447e843sm3515328ywd.10.2023.08.15.09.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 09:58:08 -0700 (PDT) Date: Tue, 15 Aug 2023 09:57:59 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Alexey Dobriyan cc: Hugh Dickins , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] mm,thp: fix smaps THPeligible output alignment In-Reply-To: <9cc6f150-6673-4fe1-a406-e04bc33a49e8@p183> Message-ID: <4eb1e67d-5fd4-af7d-c1b8-87ac0751fcd@google.com> References: <9cc6f150-6673-4fe1-a406-e04bc33a49e8@p183> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: CEC9BC001C X-Rspam-User: X-Stat-Signature: 6pspnn6dsq4rr79mnbj3iyns3zgrc8kh X-Rspamd-Server: rspam01 X-HE-Tag: 1692118689-529563 X-HE-Meta: U2FsdGVkX18gPEPnN02D9P9BbKcBzuX2NO5fLi0xZTQPUADJhFCwA/8+FswJ2bY5deyAkZENUJ2Fp/2n2zgFU26lfXnxT26p/KAJYZlpXTgrOZXBMsbFy0kSkequa7coHN1BuxIQyOuXJtuZFY7cDZOiE59g0Ycsmmy9YNgxlWaFEfC7yNJwZAwxFy5uZ/mcCYA9vX+3uz7Egwm6If44+AWZoWGRNpCge1FAwUbjYgUak2pggqCCRiNop+JOKRnABGJ/w46jxNqR4JS0KF6IrFtsHtVcgUU8hozhlOhGnKkWynoarHCM9rbIbdmI16FiuWXpxl2bEOF/iIjKhCf5YkWRRYe8xAp4qYeCB5g62a2F9Bj1WyCjHqTIoUD1hf5tK83CxXloZxSaTdW5WnykdrBfkQB5DQ0Na4E9MyDW06h88XcRGuZGhuT0EAmeql6VaIvx3VtDlHRnbLYq51A1ec+8Ht+FuhcfCN9M50FqTVrtX0LuAA8k7x23+ewQsH3yL7DoY95TnJInZkLI2f/+Mt0hrey15fs/K1kUjolwfVygyi+41+ef5ZylzdkKiEavYdhkL2pMqBiiI82pqBsX0vyOJhLaxdQgEjcMQ75NCgQ/aXUEuhsbrBh7ExOGF55DtIT2k9A1Sz5i/Y/y+98GQtRtFL1wX+esGrCk4YOKh9zCWUA1eNj4GGkLZHtbSqJRKJ6UoKaVGFqf0jpD2T2sXj4cUQ/qO5P+71PevHlqtjhZ6m0rHYkz6POpdW/uz6QSo5QkbNNAVF/SGEDg4SRT4BqxD9w8cl+BZN5seKmk9xLXYfg8HdJTEZSkMfbfF7e9iH2cWo7Hw4nPBwlPUtKaubeVEDEly7djZzZ6FLVckjYKf0bVrFqkKv4Cp4hsEDAw/+qfYpDCA8MG8Biz/VxkGCKPGcYAvTAVn7fs3Md5aevFXEL5WJXQ75mizO8W9A7s0C6qZEL/WZGdcUerPX3 eSGExXWo w7eQI1Y7KilMf+sUUdylA59/FEqOM2apqYglI8HC/L6dqGUE9GZzPyiKrdvZrB4GEMsn7NuaSJPli1KeAjQDXZHetL8I8mLvKaMWRgWsIJoNik0DwwA5xm1ZX0h4YyMcAFB6EmqChF+q4KcM/alGCK/ABQ2eVQPdmCyivEQDiYph2M6CvG61300Ackz8WYptr58ATWGMTXFoTH+INnc//KBeA7xy8+ga6A9LG3u957zMQhyx5b6I+pXRAzUvNfcBTGgL2JsIEEbwUzwXzll3WFuudy0cI8pHqST252edIPMvw1YVYZfGvajZliwmjZyfWL6bEgdvwuezuP8v+f3GpVt4ndBkSnVMJnj99wpu2LRfqgReHR49IwERe+8Jds48VlQ2h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 15 Aug 2023, Alexey Dobriyan wrote: > On Mon, Aug 14, 2023 at 01:02:08PM -0700, Hugh Dickins wrote: > > Swap: 0 kB > > SwapPss: 0 kB > > Locked: 0 kB > > THPeligible: 0 > > ProtectionKey: 0 > > > - seq_printf(m, "THPeligible: %d\n", > > + seq_printf(m, "THPeligible: %8u\n", > > hugepage_vma_check(vma, vma->vm_flags, true, false, true)); > > Why format string change? It would only slow down printing. To document the alignment, and to look like the ProtectionKey line below. > > I'd print with > > "%u", +hugepage_vma_check() Sorry, I don't understand. > > or just add whitespace. My original patch did that, then I thought it better to document the alignment and save those bytes of kernel. Hugh