From: Hugh Dickins <hughd@google.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/3] mm,thp: fix smaps THPeligible output alignment
Date: Tue, 15 Aug 2023 09:57:59 -0700 (PDT) [thread overview]
Message-ID: <4eb1e67d-5fd4-af7d-c1b8-87ac0751fcd@google.com> (raw)
In-Reply-To: <9cc6f150-6673-4fe1-a406-e04bc33a49e8@p183>
On Tue, 15 Aug 2023, Alexey Dobriyan wrote:
> On Mon, Aug 14, 2023 at 01:02:08PM -0700, Hugh Dickins wrote:
> > Swap: 0 kB
> > SwapPss: 0 kB
> > Locked: 0 kB
> > THPeligible: 0
> > ProtectionKey: 0
>
> > - seq_printf(m, "THPeligible: %d\n",
> > + seq_printf(m, "THPeligible: %8u\n",
> > hugepage_vma_check(vma, vma->vm_flags, true, false, true));
>
> Why format string change? It would only slow down printing.
To document the alignment, and to look like the ProtectionKey line below.
>
> I'd print with
>
> "%u", +hugepage_vma_check()
Sorry, I don't understand.
>
> or just add whitespace.
My original patch did that, then I thought it better to document the
alignment and save those bytes of kernel.
Hugh
prev parent reply other threads:[~2023-08-15 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 19:58 [PATCH 0/3] mm,thp: fix sloppy text output Hugh Dickins
2023-08-14 20:00 ` [PATCH 1/3] mm,thp: no space after colon in Mem-Info fields Hugh Dickins
2023-08-15 17:52 ` David Hildenbrand
2023-08-14 20:01 ` [PATCH 2/3] mm,thp: fix nodeN/meminfo output alignment Hugh Dickins
2023-08-15 17:52 ` David Hildenbrand
2023-08-14 20:02 ` [PATCH 3/3] mm,thp: fix smaps THPeligible " Hugh Dickins
2023-08-15 14:27 ` Alexey Dobriyan
2023-08-15 16:57 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eb1e67d-5fd4-af7d-c1b8-87ac0751fcd@google.com \
--to=hughd@google.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox