From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21758C001B2 for ; Fri, 16 Dec 2022 11:48:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A8978E0003; Fri, 16 Dec 2022 06:48:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 358DE8E0002; Fri, 16 Dec 2022 06:48:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 270368E0003; Fri, 16 Dec 2022 06:48:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1523D8E0002 for ; Fri, 16 Dec 2022 06:48:09 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D97D11A1095 for ; Fri, 16 Dec 2022 11:48:08 +0000 (UTC) X-FDA: 80247995856.19.19F272C Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf17.hostedemail.com (Postfix) with ESMTP id EBC6240007 for ; Fri, 16 Dec 2022 11:48:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of haowenchao@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=haowenchao@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671191286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1SphZLuLnXNtgnXa67btWVd0KteAKqsVoLJCmLWSCOw=; b=Q85NY/3sQwSut5BUPV53NTRFAA03cSXyD0WsdsyhxJr+34NcrzUGQ+eFVfhVZzsvauquEk N80BzkyWmErpIhfHXv1ZFGsDwqXci8QN22E94G6A1pQd+MglyZ0LvzUHcVCfIlVraFVlMq alTlBSqR3AQYZarOMHHe+xMfPYFvsT4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of haowenchao@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=haowenchao@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671191286; a=rsa-sha256; cv=none; b=AdfJw7Ym4cYtb9Axj3gNgoXkynOYGtRb9r2uYHSZPyuyVGh7BxjkNKi+J+FzuGQLV4kSrA 8YULlCpAxtXmzniW5zhikYZk9atd/x3nP4rgJ8cmc3WZZnJehBkNiJt9eguKW9Upbf3+eo wiOEwgT0l8ZEm1R2Qto8EKl7Timo6yA= Received: from dggpemm500017.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NYS1c4BkczJpMl; Fri, 16 Dec 2022 19:44:20 +0800 (CST) Received: from [10.174.178.220] (10.174.178.220) by dggpemm500017.china.huawei.com (7.185.36.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 16 Dec 2022 19:48:00 +0800 Message-ID: <4e9f9b32-7835-e4c5-55cb-9db82c98f9c1@huawei.com> Date: Fri, 16 Dec 2022 19:47:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] cma:tracing: Print alloc result in trace_cma_alloc_finish Content-Language: en-US To: Steven Rostedt , Masami Hiramatsu , Andrew Morton , , CC: , References: <20221208142130.1501195-1-haowenchao@huawei.com> From: Wenchao Hao In-Reply-To: <20221208142130.1501195-1-haowenchao@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.220] X-ClientProxiedBy: dggpeml500015.china.huawei.com (7.185.36.226) To dggpemm500017.china.huawei.com (7.185.36.178) X-CFilter-Loop: Reflected X-Stat-Signature: ppiiomgdyytussc8nxmu5krc71asfhdm X-Rspam-User: X-Rspamd-Queue-Id: EBC6240007 X-Rspamd-Server: rspam06 X-HE-Tag: 1671191285-522061 X-HE-Meta: U2FsdGVkX1+or17zgis/Xf+0In0PLwAQGYj3vJEqDDg2ucnAIu2DvkWAwcQUMukbl4mjSA8bI/Fg76g1h047XXbsDF7xuoV8DYDkaIqyH8O0+izcMxMzXdyJZbWtlGeO3z8LK4/uQlQWAn5PvuzMp4ompUj4XCIS6JkIno84G2v5PVPXpNBVeoK5JtybxTzAbRjQFSPnfsK8J+uZN7T0QyXVvxTt6ytTXRn4TdQsPw1H2vkGjbXE5mW9RHRR+uq2WmiqU/9BwW8OYIJwMDgAulWCzrcEBxpN5IppNLfij3L0IBFDWXdqJvLgUYNrRjmukJXpA56G7eisi7qsVoFmqPiPXJKnpDhBfAh0FCnY6UIQ384H2oMpyZ8sLgaVCWKx53RXatksKjRSAlCNjGhGU9yR9VsKd4x6d5A+/g7AZiPGIf/Wp5BVBfHTXQEA8FgBOOWoFffi3jE2MX+X3ZjtSgO1P3hgdT6hzsWNUEDukamo/V79G0OFaaVYgwG5d6O274GbMs0Wjp3Rs0k8FBS6Wx7j3zStZKPbfo9/UgFD8UKJsTI5kn69FJmSNp/Vo9/QenwJI6VWyjd0jpLgHTJ2z+IyWG30RDUm8vHaQeBJ+75XtyUHQJK2GSQVGzE1hZtUQSbhPH/mhaz2Tf+Oa13NVNN5mZWf+WqO5I1bzV0xLxiTNb/Dap/n+lYzs8ckDukf1r7Hjo0KOG3mcmbdjQVzyxouGoN0npzdQ/ckJNq9UOESOULkBKN3tlQwHAnj2WyWGuPfw2CfidWanccOBkwKN6NkZoMCib9U/uJXBGZiOVaONFt9PVG3gMG9WZ/b1WrxQ0JUzvjPlBsu3GyaiISvImG9Temjn3V8/r4eKt8WYFdmfYyztLsYVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/8 22:21, Wenchao Hao wrote: > The result of allocation is not printed in trace_cma_alloc_finish > now, while it's important to do it so we can set filters to catch > specific error on allocation or trigger some operations on specific > error. > > Although we have printed the result in log, but the log is > conditional and could not be filtered by tracing event. > > What's more, it introduce little overhead to print this result. > The result of allocation is named as errorno in trace. > > Signed-off-by: Wenchao Hao > --- > include/trace/events/cma.h | 32 +++++++++++++++++++++++++++++--- > mm/cma.c | 2 +- > 2 files changed, 30 insertions(+), 4 deletions(-) > > diff --git a/include/trace/events/cma.h b/include/trace/events/cma.h > index 3d708dae1542..ef75ea606ab2 100644 > --- a/include/trace/events/cma.h > +++ b/include/trace/events/cma.h > @@ -91,12 +91,38 @@ TRACE_EVENT(cma_alloc_start, > __entry->align) > ); > > -DEFINE_EVENT(cma_alloc_class, cma_alloc_finish, > +TRACE_EVENT(cma_alloc_finish, > > TP_PROTO(const char *name, unsigned long pfn, const struct page *page, > - unsigned long count, unsigned int align), > + unsigned long count, unsigned int align, int errorno), > > - TP_ARGS(name, pfn, page, count, align) > + TP_ARGS(name, pfn, page, count, align, errorno), > + > + TP_STRUCT__entry( > + __string(name, name) > + __field(unsigned long, pfn) > + __field(const struct page *, page) > + __field(unsigned long, count) > + __field(unsigned int, align) > + __field(int, errorno) > + ), > + > + TP_fast_assign( > + __assign_str(name, name); > + __entry->pfn = pfn; > + __entry->page = page; > + __entry->count = count; > + __entry->align = align; > + __entry->errorno = errorno; > + ), > + > + TP_printk("name=%s pfn=0x%lx page=%p count=%lu align=%u errorno=%d", > + __get_str(name), > + __entry->pfn, > + __entry->page, > + __entry->count, > + __entry->align, > + __entry->errorno) > ); > > DEFINE_EVENT(cma_alloc_class, cma_alloc_busy_retry, > diff --git a/mm/cma.c b/mm/cma.c > index 4a978e09547a..a75b17b03b66 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -491,7 +491,7 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, > start = bitmap_no + mask + 1; > } > > - trace_cma_alloc_finish(cma->name, pfn, page, count, align); > + trace_cma_alloc_finish(cma->name, pfn, page, count, align, ret); > > /* > * CMA can allocate multiple page blocks, which results in different pinging