From: Vlastimil Babka <vbabka@suse.cz>
To: Pengfei Li <lpf.vector@gmail.com>, akpm@linux-foundation.org
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] mm, slab: Make kmalloc_info[] contain all types of names
Date: Mon, 9 Sep 2019 16:59:02 +0200 [thread overview]
Message-ID: <4e9a237f-2370-0f55-34d2-1fbb9334bf88@suse.cz> (raw)
In-Reply-To: <20190903160430.1368-2-lpf.vector@gmail.com>
On 9/3/19 6:04 PM, Pengfei Li wrote:
> There are three types of kmalloc, KMALLOC_NORMAL, KMALLOC_RECLAIM
> and KMALLOC_DMA.
>
> The name of KMALLOC_NORMAL is contained in kmalloc_info[].name,
> but the names of KMALLOC_RECLAIM and KMALLOC_DMA are dynamically
> generated by kmalloc_cache_name().
>
> This patch predefines the names of all types of kmalloc to save
> the time spent dynamically generating names.
As I said, IMHO it's more useful that we don't need to allocate the
names dynamically anymore, and it's simpler overall.
> Signed-off-by: Pengfei Li <lpf.vector@gmail.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> /*
> * kmalloc_info[] is to make slub_debug=,kmalloc-xx option work at boot time.
> * kmalloc_index() supports up to 2^26=64MB, so the final entry of the table is
> * kmalloc-67108864.
> */
> const struct kmalloc_info_struct kmalloc_info[] __initconst = {
BTW should it really be an __initconst, when references to the names
keep on living in kmem_cache structs? Isn't this for data that's
discarded after init?
next prev parent reply other threads:[~2019-09-09 14:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 16:04 [PATCH 0/5] " Pengfei Li
2019-09-03 16:04 ` [PATCH 1/5] " Pengfei Li
2019-09-09 14:59 ` Vlastimil Babka [this message]
2019-09-09 16:53 ` Pengfei Li
2019-09-09 18:30 ` Rasmus Villemoes
2019-09-09 19:48 ` Vlastimil Babka
2019-09-10 0:52 ` Pengfei Li
2019-09-03 16:04 ` [PATCH 2/5] mm, slab_common: Remove unused kmalloc_cache_name() Pengfei Li
2019-09-09 14:59 ` Vlastimil Babka
2019-09-09 16:54 ` Pengfei Li
2019-09-03 16:04 ` [PATCH 3/5] mm, slab: Remove unused kmalloc_size() Pengfei Li
2019-09-09 15:07 ` Vlastimil Babka
2019-09-03 16:04 ` [PATCH 4/5] mm, slab_common: Make 'type' is enum kmalloc_cache_type Pengfei Li
2019-09-09 15:08 ` Vlastimil Babka
2019-09-03 16:04 ` [PATCH 5/5] mm, slab_common: Make initializing KMALLOC_DMA start from 1 Pengfei Li
2019-09-04 19:27 ` [PATCH 0/5] mm, slab: Make kmalloc_info[] contain all types of names Christopher Lameter
2019-09-05 0:40 ` Pengfei Li
2019-09-05 12:25 ` Vlastimil Babka
2019-09-05 13:51 ` Pengfei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e9a237f-2370-0f55-34d2-1fbb9334bf88@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lpf.vector@gmail.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox