From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E182C56201 for ; Wed, 25 Nov 2020 08:43:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C2C920B1F for ; Wed, 25 Nov 2020 08:43:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MFz+n78R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C2C920B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AE8316B0070; Wed, 25 Nov 2020 03:43:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A977D6B0071; Wed, 25 Nov 2020 03:43:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D5D96B0072; Wed, 25 Nov 2020 03:43:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id 8433F6B0070 for ; Wed, 25 Nov 2020 03:43:45 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5382E181AC9BF for ; Wed, 25 Nov 2020 08:43:45 +0000 (UTC) X-FDA: 77522302410.12.wave01_5801a5527375 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 36E521801BE98 for ; Wed, 25 Nov 2020 08:43:45 +0000 (UTC) X-HE-Tag: wave01_5801a5527375 X-Filterd-Recvd-Size: 4029 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 08:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606293824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iCA0NoplkuY0wv1lgLVwIs8tVQk43X2rCmw/7XtS8LM=; b=MFz+n78RLoxstRPPL+XKFC7qPANtX5Tx91dMeP46sAEJG8xuKaJ6O3PqQf8Lqkk/iw7OTv JzcZR/+CiLvq/OGRIZigVwR94Z6Qrw5al71LIlTafgzD8qUKhAA9wfEWDzTHOv2EGAK1d6 MS3h/iFyHUN52wG09RI2O4Ptz6OVZus= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-9f3Pk5vpMMCdH6epfp_sSA-1; Wed, 25 Nov 2020 03:43:41 -0500 X-MC-Unique: 9f3Pk5vpMMCdH6epfp_sSA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4BBA2180E46E; Wed, 25 Nov 2020 08:43:40 +0000 (UTC) Received: from [10.36.112.131] (ovpn-112-131.ams2.redhat.com [10.36.112.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF88060BE5; Wed, 25 Nov 2020 08:43:38 +0000 (UTC) Subject: Re: [PATCH 2/2] mm: Move free_unref_page to mm/internal.h To: "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org Cc: davem@davemloft.net, rppt@kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20201125034655.27687-1-willy@infradead.org> <20201125034655.27687-2-willy@infradead.org> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <4e989b22-a144-3778-6d71-f04137a523e4@redhat.com> Date: Wed, 25 Nov 2020 09:43:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201125034655.27687-2-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.11.20 04:46, Matthew Wilcox (Oracle) wrote: > Code outside mm/ should not be calling free_unref_page(). Also > move free_unref_page_list(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/gfp.h | 2 -- > mm/internal.h | 3 +++ > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index c603237e006c..6e479e9c48ce 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -580,8 +580,6 @@ void * __meminit alloc_pages_exact_nid(int nid, size_t size, gfp_t gfp_mask); > > extern void __free_pages(struct page *page, unsigned int order); > extern void free_pages(unsigned long addr, unsigned int order); > -extern void free_unref_page(struct page *page); > -extern void free_unref_page_list(struct list_head *list); > > struct page_frag_cache; > extern void __page_frag_cache_drain(struct page *page, unsigned int count); > diff --git a/mm/internal.h b/mm/internal.h > index 75ae680d0a2c..5864815947fe 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -201,6 +201,9 @@ extern void post_alloc_hook(struct page *page, unsigned int order, > gfp_t gfp_flags); > extern int user_min_free_kbytes; > > +extern void free_unref_page(struct page *page); > +extern void free_unref_page_list(struct list_head *list); > + > extern void zone_pcp_update(struct zone *zone); > extern void zone_pcp_reset(struct zone *zone); > extern void zone_pcp_disable(struct zone *zone); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb