From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48824C6FD1F for ; Tue, 14 Mar 2023 22:11:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6CAD6B0072; Tue, 14 Mar 2023 18:11:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1C636B0074; Tue, 14 Mar 2023 18:11:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBD306B0075; Tue, 14 Mar 2023 18:11:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A95276B0072 for ; Tue, 14 Mar 2023 18:11:56 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 839DC80EA9 for ; Tue, 14 Mar 2023 22:11:56 +0000 (UTC) X-FDA: 80568902232.17.8884CD7 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf16.hostedemail.com (Postfix) with ESMTP id 8F64F18000E for ; Tue, 14 Mar 2023 22:11:54 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oPNWwBIT; spf=pass (imf16.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678831914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SekFEmAeK9leXCVtEJ/5RiO3jcSsl6NVfTaRrfrZ9J0=; b=N9i33aaVixbE3pvbGNvtbcog82zGh1E8LsKiRP8szRNb1IcnYW+OwSWow3+CpoHhr2+yM6 S9ubsWCyD/+8JsKfkQL9XOykRQN6cLBNraUaeub4I9hWZI6yWHHmQuc55Ic4AkLweEGwF4 vJu56F6iSptjuaQUYfKPEi8QSjRQ6T8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oPNWwBIT; spf=pass (imf16.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678831914; a=rsa-sha256; cv=none; b=FLMZ51ki/FXFcHDojgEeiHo8J7CIVVeeo02bgbG8Lry5zlECXOCwZccJLdCX9p+ECcvMQ2 Ch6JDZjW4WCZY1ncQGEqjZ3qtaGPBt1mqliRA3QCJAAqAd47UPQPw+NVg56fjUoeSC4JCY 05w4uiAXpFsJcpgZ2xDEwbPLaF9P5zc= Received: by mail-wm1-f51.google.com with SMTP id l7-20020a05600c4f0700b003e79fa98ce1so11169022wmq.2 for ; Tue, 14 Mar 2023 15:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678831913; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SekFEmAeK9leXCVtEJ/5RiO3jcSsl6NVfTaRrfrZ9J0=; b=oPNWwBITue+0q+Gxhr58U1kNBLFxTO1MPp56f9Y+lN6aB40OfQA+HcognUG0yf4pmn e2gFvCzgqkNE6DheOGDTX0/va4sOjqSyisTfHD+971zqRBaQclJWHRyep4Ubzuh3yQXD PoP/JZglgDGJzPNLExl32duTvYBCrew7Gy6GazTQgjn56B9PfHWeIh2JJ6dNHCx6nStX SyYgktXbqCSlyFfVei4/hSS3w2rWnzrT0enOosoLz03a8OsbGSrYqpYavBHJzPR94Xoi zC+uHX4ceP0QL57R6SRib0pqx13y0moaj+EMNnhezYvMliREdD7Kc1djkgAfXkvd3NRf EGJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678831913; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SekFEmAeK9leXCVtEJ/5RiO3jcSsl6NVfTaRrfrZ9J0=; b=Y9MEERV5evsaNLw+qj7/8pQCpdCYCzeRhiGYF/1ZOxkZ1y8MAnhqal8Wv4hEnE/xqu UA8xnbY4OHEjn4D/pdOq9ce2pFzk5eph1jSMqUa6EA6I2zkkbkaPw0ZC8sxM9LRtvgEN ptvWDyWixvvSsIXhsquffdfkk4Kl58ZNCtSKfmicho4yAp71ZFMYKF7OdeJZIUZH/OS/ NIAaCZarZG125G2yoeHmyJPNlPKRqyOBPnffMj7lwIukdmDzT/C1iLjo3FAbvgGF4/4G iCn7IsKvFRi6w0ozERtYto3Zs/FGDoUqh8NHytBzKuHKIOclUwdne1UIGt2Aub1J1ao2 xkRA== X-Gm-Message-State: AO0yUKXNV871YYEnzjOJfANQ+5mSb2uPcdAmJ5PqZPmdz5B3rSJwcftm e9PLV/LCt7FTTFKNubZLJbc= X-Google-Smtp-Source: AK7set867EXlhkXXBMVZCE2npmcXP0xJU5GRhkg31e64K452iGc8VYDPMj8kt4wPWuhgptenPGsmDA== X-Received: by 2002:a05:600c:1c95:b0:3e2:1ef0:f585 with SMTP id k21-20020a05600c1c9500b003e21ef0f585mr16262253wms.2.1678831913150; Tue, 14 Mar 2023 15:11:53 -0700 (PDT) Received: from localhost (host86-146-209-214.range86-146.btcentralplus.com. [86.146.209.214]) by smtp.gmail.com with ESMTPSA id l8-20020a05600c4f0800b003db01178b62sm4438120wmq.40.2023.03.14.15.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 15:11:52 -0700 (PDT) Date: Tue, 14 Mar 2023 22:11:51 +0000 From: Lorenzo Stoakes To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, netdev@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 1/7] mm/slob: remove CONFIG_SLOB Message-ID: <4e936740-1f1c-4dd2-968b-b781ee2bfc6a@lucifer.local> References: <20230310103210.22372-1-vbabka@suse.cz> <20230310103210.22372-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310103210.22372-2-vbabka@suse.cz> X-Stat-Signature: wotdkjwgzpzeog9uwhkpkk99udcq8y88 X-Rspam-User: X-Rspamd-Queue-Id: 8F64F18000E X-Rspamd-Server: rspam06 X-HE-Tag: 1678831914-480063 X-HE-Meta: U2FsdGVkX1+C1t4cxOsnbr9oXkG7QEvPUbpHa0dQgYqM8KVMWRmxz7+AcR5cALkREEb9keKgqnXqQzD9i2T46j9Cn8Warmf+nVIcKCnjL5fCFLsETMKruJjjn2Iq+Dq/Xyxy4lSEImdgJWGZumhfxYp0quk67y2Z0PbNOCEL2rUlnUWeuIPV8/bF6PRIF5qGfAqM2+HALhadKyj5ItIyBUPgZUJrExynRvKPTyjUZ6zHWn719dlurEQQ58p/f33zN6edACpu84/dnGaHMkK18vtf/Gk7/c6/HkBQsJlIzy8V+KLJWiHCY0Srnsh+HLDG1Pfax9sAvuDbhA58owZ9CVkqDdwg8HTD4FYU5b55nLRP1qvuAjcJlSLjoCzl5HBpdUzd5FIX3RG59KQjiX/2tpyd8tvNf7t3s10Rag9EpMQD91LgsOD74ZJ0BMt+YoxDDYYhjs2aUJefjH36y4YljqY2YsO+U1Ld3kGo5UIKvUilxZw8vdhmdLkSXKDKp7nf/QCb0ohs+MocWGyyjiGlc7etgLzGCpK97vAlr9+F9Bc4H0dX8BsspaqRuzJ+Tr0nf1CIytgphVN2CQ52d9QE3md+Ennd+maSnG0PdbKnpvrDsVXpIVHBBhHxbKCjGNlEEE32jXujgUUjqT8unhwgTYUsfx8Y4xeSmU1tiInziYgtHC0fGcZdozJICDBBVzNVNENa2t4cq3Uhk2b75j3reF/s5mzu/cavmfhhhg+aYc6kGSOSPoAGiRArxeJAhjdRhkM9bB2kwddLd+X5JK28BkcKeJ2VdZNV8vr/gOW0CWL+YLndQYnqx+sZ4AIHUa0IRcyPQJ/JPZfJysdrURsEKYoXCgNzEoXJDAUayLpeZtdu7GIZcRLc5WIpyFpNFhXOydux3fGJNm+kARHNk1Fr3EykRyrrO5/0L2cSxRZCt5T2aQemKXryVxqQRaK5IiIbO0RDJuuL8X+lshy4hdx IJs0uyJl SPbMotW0QWmMf4biAwlhqu3d2pBIJ22sD2yOnTmMtOp9w8tHI+hmNFCvUEVFHpgQ06z2yWM/H0IHOus78JO3Gr8pRn+HfQXuGsARZCMJZ2msy92C4pQfsneanp9pIGRdKBZzcKdc0HTxP5fbGpJnuuNQrzEpBbGt1xndejdl00EXBUjOwTTerYxF35dvTcl2XUQnR/+wjcQxvVaXJEyeVurDgCsYstdapqvXebO6TGeKeaH/tSxSm6pMi3qI/1DrjOXyQ4v8rREW2pvSpD2k3QkyK5IDLxFwA/ytiRSPcRJKRW6vfamw1C2s0DVAnWy2oq5tMRneuwfAFWhojqeHWsh3Ixsz/5cnaYywMphlE7hmO343gei/wSemq9clfEJxDga8RuX2hAZthDT5n3my6LKHZnKeX2HSiuqMPyZhNE1EG52aeqi0CXhQWNsB10xx6ydCkfQh3jY2MO0tayhsLMFQ/zGMlbe4QfE0wOubiAZ+K8FwnYkkYcCJqZqOYTHT3Q9YLHifBmZPYCiWFzc0f0VboZAvU9JIH/IOulvVzn6n3XQauisQyIiCL3md9j4huEUaddO/mveySl4dSbhY3FgwktS642tybYIXdb+885V8db7GTL0mPirTocUqRkw7WySQQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 10, 2023 at 11:32:03AM +0100, Vlastimil Babka wrote: > Remove SLOB from Kconfig and Makefile. Everything under #ifdef > CONFIG_SLOB, and mm/slob.c is now dead code. > > Signed-off-by: Vlastimil Babka > --- > init/Kconfig | 2 +- > kernel/configs/tiny.config | 1 - > mm/Kconfig | 22 ---------------------- > mm/Makefile | 1 - > 4 files changed, 1 insertion(+), 25 deletions(-) > > diff --git a/init/Kconfig b/init/Kconfig > index 1fb5f313d18f..72ac3f66bc27 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -973,7 +973,7 @@ config MEMCG > > config MEMCG_KMEM > bool > - depends on MEMCG && !SLOB > + depends on MEMCG > default y > > config BLK_CGROUP > diff --git a/kernel/configs/tiny.config b/kernel/configs/tiny.config > index c2f9c912df1c..144b2bd86b14 100644 > --- a/kernel/configs/tiny.config > +++ b/kernel/configs/tiny.config > @@ -7,6 +7,5 @@ CONFIG_KERNEL_XZ=y > # CONFIG_KERNEL_LZO is not set > # CONFIG_KERNEL_LZ4 is not set > # CONFIG_SLAB is not set > -# CONFIG_SLOB_DEPRECATED is not set > CONFIG_SLUB=y > CONFIG_SLUB_TINY=y > diff --git a/mm/Kconfig b/mm/Kconfig > index 4751031f3f05..669399ab693c 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -238,30 +238,8 @@ config SLUB > and has enhanced diagnostics. SLUB is the default choice for > a slab allocator. > > -config SLOB_DEPRECATED > - depends on EXPERT > - bool "SLOB (Simple Allocator - DEPRECATED)" > - depends on !PREEMPT_RT > - help > - Deprecated and scheduled for removal in a few cycles. SLUB > - recommended as replacement. CONFIG_SLUB_TINY can be considered > - on systems with 16MB or less RAM. > - > - If you need SLOB to stay, please contact linux-mm@kvack.org and > - people listed in the SLAB ALLOCATOR section of MAINTAINERS file, > - with your use case. > - > - SLOB replaces the stock allocator with a drastically simpler > - allocator. SLOB is generally more space efficient but > - does not perform as well on large systems. > - > endchoice > > -config SLOB > - bool > - default y > - depends on SLOB_DEPRECATED > - > config SLUB_TINY > bool "Configure SLUB for minimal memory footprint" > depends on SLUB && EXPERT > diff --git a/mm/Makefile b/mm/Makefile > index 8e105e5b3e29..2d9c1e7f6085 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -81,7 +81,6 @@ obj-$(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP) += hugetlb_vmemmap.o > obj-$(CONFIG_NUMA) += mempolicy.o > obj-$(CONFIG_SPARSEMEM) += sparse.o > obj-$(CONFIG_SPARSEMEM_VMEMMAP) += sparse-vmemmap.o > -obj-$(CONFIG_SLOB) += slob.o > obj-$(CONFIG_MMU_NOTIFIER) += mmu_notifier.o > obj-$(CONFIG_KSM) += ksm.o > obj-$(CONFIG_PAGE_POISONING) += page_poison.o > -- > 2.39.2 > Looks good to me too, Acked-by: Lorenzo Stoakes