From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 314E0C197A0 for ; Thu, 16 Nov 2023 10:12:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A22DD6B044B; Thu, 16 Nov 2023 05:12:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D2DA6B044D; Thu, 16 Nov 2023 05:12:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 825876B044E; Thu, 16 Nov 2023 05:12:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6FCE66B044B for ; Thu, 16 Nov 2023 05:12:30 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4E29F160BAD for ; Thu, 16 Nov 2023 10:12:30 +0000 (UTC) X-FDA: 81463402860.13.AAE34A3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id F28C320005 for ; Thu, 16 Nov 2023 10:12:27 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KIfT9j69; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700129548; a=rsa-sha256; cv=none; b=KCeEE23HkLRw/M+PvjR5yrbuEsULHKwTZSHdAHsRgaM+akdMaqKN2VM0MJoFZBVhVnQ/A2 P6yRvu469aSpbTedoy8x+8JRHAtOtvZzJ0TCjw0x82+EdTqWLflcC+cshrPA1CNfw9bYAg 5aAdXAfL568GBd3ddS1QsHeJsZtYeWM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KIfT9j69; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700129548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5ZBbfhLMJV0XF/JRhcYrRxUZLfjN1NPiJz+tDpv7jDU=; b=uQiKGQIkUku0uldZXO6fnis9g2v46W+TzvMjmcJdR2ex5l6T8kawOG34vy3TWk+S7NAmQV 2K0jn/xsgn8RVvUwcoqrciyNiPvgR57pxtztrOd1jZsT7UdqFQQuxWF/IfYNGar3Y3WXnE dJeDGAfdRsAFkbu3eWFGrKiISM43m3E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700129547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5ZBbfhLMJV0XF/JRhcYrRxUZLfjN1NPiJz+tDpv7jDU=; b=KIfT9j69q2yXOaGCKa4pgric7GIn/Mst3WYdq3U0YV5MHYLGeO+BdHSMqTrT1jd4W7jOoA O75y8VB5sSuk/RualD401sSIfN2N1XP2NWrgEv0BNZlCQyF+htSN7HhvtpQC4c8P2/cpG+ L1j7JfouldVZMsDHPybU6UEFrHqB4k8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-Khigx2eZMbyz9KOFAivoCg-1; Thu, 16 Nov 2023 05:12:25 -0500 X-MC-Unique: Khigx2eZMbyz9KOFAivoCg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-32db43129c6so321969f8f.1 for ; Thu, 16 Nov 2023 02:12:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700129544; x=1700734344; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5ZBbfhLMJV0XF/JRhcYrRxUZLfjN1NPiJz+tDpv7jDU=; b=OjtbpqEYXlNGsFwXZkksoNZ/0dvzF+OwslQb455uNJQDW8GUpTiajX3+vOdDvuMxWN NwviXGXJjKxENocugxkmui9RXkehJ0tlHdkKN3YIPplkN3JXMrbb+1/ixqBAf2u9AY9e K3qyaKiPIvHe6hY+CaYiMZM/HuZDWkVtVyhnyicKwIIDq01U++Y/rvWZnsqC62hnKz93 VmyO7aBKwE/XxzVhpS4aqvEbm2LF1iQnCAmreNZ2PxFRX6Gs5218o4W6DWOmg3e8ANgZ vZXimHuLoL3/eph9pT5VApkTahhjceP9tNXqohjsmOGbvbtcrr0mHlomCG1FxkYtOoOH gPIg== X-Gm-Message-State: AOJu0YzRQcOL1/HgiV87acM6P48Stl6q7LMpZQf90Fmg3hTArbgDKJQk hrqK3qk1RG0gKQPVuo7aSo49imeyAnda/Gm4kLXR/h8byacj99+wxutslkJKLvu1W0c2UqY7OOY 3K1WbaK8KrDE= X-Received: by 2002:adf:b34e:0:b0:32d:ccdf:69f2 with SMTP id k14-20020adfb34e000000b0032dccdf69f2mr1167268wrd.26.1700129544293; Thu, 16 Nov 2023 02:12:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHMGUOW+sXP1OJtcDLRzdaY0Vfsn1RDtCT0aAHbY1L00AmpHwtD70nhXZkB4j4B2LaNebEChw== X-Received: by 2002:adf:b34e:0:b0:32d:ccdf:69f2 with SMTP id k14-20020adfb34e000000b0032dccdf69f2mr1167254wrd.26.1700129543860; Thu, 16 Nov 2023 02:12:23 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id e14-20020adfe7ce000000b0032d2489a399sm13087757wrn.49.2023.11.16.02.12.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Nov 2023 02:12:23 -0800 (PST) Message-ID: <4e8d329c-eda6-4ff8-bb56-8924bb4583b2@redhat.com> Date: Thu, 16 Nov 2023 11:12:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/14] mm: Batch-copy PTE ranges during fork() To: Ryan Roberts , kernel test robot , Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Anshuman Khandual , Matthew Wilcox , Yu Zhao , Mark Rutland , Kefeng Wang , John Hubbard , Zi Yan Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231115163018.1303287-2-ryan.roberts@arm.com> <202311160516.kHhfmjvl-lkp@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F28C320005 X-Stat-Signature: x9p3h9zpzxxw6mqktkws33m7o3unh59k X-HE-Tag: 1700129547-286406 X-HE-Meta: U2FsdGVkX1/nVXMqXcRoocOKXlaEZ571A7nj2aFHxJ/dZCfs9n0A5yxastHnc333QwkH1uk3+oBnhRPDo+O9VYep1rVfcF3OHe6zLF+Oe0d4WEtJRjNUc+5l+P2ZVDcJJI/nBBa+TRjfW2cAV2Bv+Tf+xzNkmUOB2DZdm3h3zp+SEn5jZOqmkMi97kxV/nIklH2ZW4HMmd5dG2gHisj3uSWEdkoMhhfo/C6+bcGi4LB8P2cdN1AEuTp7DklC/fZN6cVRwW9FoxogvCtq3+E6rmBdfI8Kgq7/jUg8+lvz0KggJqsybR3qAsj0sbWNqBAG3NB0dBGU+6RNfNh324/Fzc6KQtfQoN/sfqNG2RE0RkWZneBiOoxIiOUreLFh/BIz++U/YJMYmd4lvBRzBtBVJBL7ijwLzxBxiat0Z/OhUjkFCk0/kX5dkWgreRVE3wB48ZDjZBVdPkB/SI66mUfls5a4qeUgMbz7msOqlHZcfTg8R0LINOj1vkkiH0KrUcA6JCAPOdM+kuUusDnmn6VDpWcKhZtaYGd+LbnLtMS6Pcgqo87XRs6XNWsMin0/TJ+KHv/YSwDYhpjfouGxZetaLWTME8g3PX0yYv3TM43txjnfoClruM9pqXkxfaTq/sA8pJoUQuGIJQBN0h/qgyrOp2Gf5niRexyT5INq00ynvwm/v8rq+ZA9aRw8OUDRdxLawJWVUpsokvcNdcH6mDpDQ68vpZpQtiifk/fOJrY7mfzLGTyuiG4AyZ+RTVSj/D/fUp5GIC7d59vcVKodNLjkk22ode5Mv5yiNY4z+HO0huRlxCIl0dYGAvQUORJB4mtt2skG1GMDFnZKkSE5R5UVwDvJrWydQ3arC1mz5CZZsmxGVvjWzRBbEaHwzMjZQvRwgGxk6NnWZNkOtkfXcvphObIDw+P/OmJWc/NeiNgvG8WTVnat7nOCaQESfNsiX+/kXHLqf+td4Rd7bG72ddq Txbmdz4n Xe33ctJASZDy2OzJSYTnMrI1WeRE2FCByPEQKbR6Q7MzdBSrLukMWg9rDIbG9g3Q8klDNjbD8IwM1NbJ7APH6kZHtnrl4Pg+0rQ5izDFzND5S2WWp6c0R1HECjSjryITQ+qKU+F7h6lQfOuemOGL4O0arOuKr6fKLwIHXclPIEPipwEDvX6iwsUf1xVnPiRFc9OG88w09wPEnu09Pt57s1hkwiy6E8orqRB/z2Wbi08AcikjhRyKUBAyw4EqoUTyiB4ExahbqdO9PYFEznGqFoE4f8HkOHhRmR1KMmhDFd/gkRo1As2SFioOiyRdPIH1m1RJjxb468SMNPNQwx2ROsTX65ojeRW7bhRUUrWXp/NHIUF5Z6ii0cOhY8SsFNaEFgnTMsA09xO6Gei134bU1FdGZDfV9gUm3/Tbq15k/uOPRcG20Ql6krOhjRe65SEJEfBU+UDQsMCt3+I37PNqk3TVRYPORPrXuYeJN791DCuMZQmDuxa3qQI8oscJtfNIlgjfmhrchq0Na5+AyhJp7S+Ch8wpEgMOKA4NeOaL3PE60Fo3yyd7LC8jQ5HJytN4I0wDEevBLvwrQStpM5vgze+tuauyLGif7Y7dIxXmlLgXWQSHCwaaDePwkavFNpI1himy/sHhZSrmTfe4h18hcG95aSWfmd2RTgtt/YS8frslfIiZytI7Blx5UYMCcAMovmPp0nGeRb6HMlPM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.11.23 11:07, Ryan Roberts wrote: > Hi All, > > Hoping for some guidance below! > > > On 15/11/2023 21:26, kernel test robot wrote: >> Hi Ryan, >> >> kernel test robot noticed the following build errors: >> >> [auto build test ERROR on akpm-mm/mm-everything] >> [also build test ERROR on linus/master v6.7-rc1 next-20231115] >> [cannot apply to arm64/for-next/core efi/next] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url: https://github.com/intel-lab-lkp/linux/commits/Ryan-Roberts/mm-Batch-copy-PTE-ranges-during-fork/20231116-010123 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything >> patch link: https://lore.kernel.org/r/20231115163018.1303287-2-ryan.roberts%40arm.com >> patch subject: [PATCH v2 01/14] mm: Batch-copy PTE ranges during fork() >> config: arm-randconfig-002-20231116 (https://download.01.org/0day-ci/archive/20231116/202311160516.kHhfmjvl-lkp@intel.com/config) >> compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231116/202311160516.kHhfmjvl-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202311160516.kHhfmjvl-lkp@intel.com/ >> >> All errors (new ones prefixed by >>): >> >> mm/memory.c: In function 'folio_nr_pages_cont_mapped': >>>> mm/memory.c:969:16: error: implicit declaration of function 'pte_pgprot'; did you mean 'ptep_get'? [-Werror=implicit-function-declaration] >> 969 | prot = pte_pgprot(pte_mkold(pte_mkclean(ptent))); >> | ^~~~~~~~~~ >> | ptep_get >> cc1: some warnings being treated as errors > > It turns out that pte_pgprot() is not universal; its only implemented by > architectures that select CONFIG_HAVE_IOREMAP_PROT (currently arc, arm64, > loongarch, mips, powerpc, s390, sh, x86). > > I'm using it in core-mm to help calculate the number of "contiguously mapped" > pages within a folio (note that's not the same as arm64's notion of > contpte-mapped. I just want to know that there are N physically contiguous pages > mapped virtually contiguously with the same permissions). And I'm using > pte_pgprot() to extract the permissions for each pte to compare. It's important > that we compare the permissions because just because the pages belongs to the > same folio doesn't imply they are mapped with the same permissions; think > mprotect()ing a sub-range. > > I don't have a great idea for how to fix this - does anyone have any thoughts? KIS :) fork() operates on individual VMAs if I am not daydreaming. Just check for the obvious pte_write()/dirty/ and you'll be fine. If your code tries to optimize "between VMAs", you really shouldn't be doing that at this point. If someone did an mprotect(), there are separate VMAs, and you shouldn't be looking at the PTEs belonging to a different VMA. -- Cheers, David / dhildenb