From: Mike Kravetz <mike.kravetz@oracle.com>
To: Axel Rasmussen <axelrasmussen@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>, Peter Xu <peterx@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Mina Almasry <almasrymina@google.com>,
Shuah Khan <shuah@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] userfaultfd/selftests: clean up hugetlb allocation code
Date: Tue, 4 Jan 2022 16:24:02 -0800 [thread overview]
Message-ID: <4e811968-4467-daf7-eb59-1e1827371ebd@oracle.com> (raw)
In-Reply-To: <CAJHvVci5sSC-1TEiCBKe8uKQ=0uwCsoBJT_fsG1Rfq6ffy6Obg@mail.gmail.com>
On 1/4/22 14:35, Axel Rasmussen wrote:
> On Mon, Jan 3, 2022 at 6:17 PM Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> Looks functionally correct to me besides the one style gripe,
>
> Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>
Thanks Axel!
The userfaultfd test is not so easy to follow. While looking at this, I
noticed that we skip the mremap() testing for hugetlb. However, Mina recently
added hugetlb mremap support. Unfortunately, mremap hugetlb testing fails
if enabled. I am still trying to determine the root cause, but would like
to eliminate this special case if possible.
--
Mike Kravetz
next prev parent reply other threads:[~2022-01-05 0:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 2:17 Mike Kravetz
2022-01-04 22:35 ` Axel Rasmussen
2022-01-05 0:24 ` Mike Kravetz [this message]
2022-01-05 23:56 ` Andrew Morton
2022-01-06 17:43 ` Mike Kravetz
2022-01-06 18:25 ` Axel Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e811968-4467-daf7-eb59-1e1827371ebd@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox