From: David Hildenbrand <david@redhat.com>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] mm: remove an unnecessary goto jump
Date: Fri, 8 May 2020 10:49:58 +0200 [thread overview]
Message-ID: <4e652ee4-11e1-1cef-ab03-59c4010c6c94@redhat.com> (raw)
In-Reply-To: <dc38f5a5-e318-de61-89ff-27aa35528fed@huawei.com>
On 08.05.20 10:47, Leizhen (ThunderTown) wrote:
>
>
> On 2020/5/8 16:06, David Hildenbrand wrote:
>> On 05.05.20 13:58, Zhen Lei wrote:
>>> This "goto" doesn't reduce any code, but bother the readers.
>>
>> "mm/page_io.c: mm: remove an unnecessary goto in generic_swapfile_activate"
>
> Do you mean change the subject? So is it:
> "mm/page_io.c: remove an unnecessary goto in generic_swapfile_activate()" ?
>
Yeah, would have been my suggestion.
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2020-05-08 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 11:58 Zhen Lei
2020-05-08 8:06 ` David Hildenbrand
2020-05-08 8:47 ` Leizhen (ThunderTown)
2020-05-08 8:49 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e652ee4-11e1-1cef-ab03-59c4010c6c94@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox