From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 742DCC5478C for ; Tue, 27 Feb 2024 10:18:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0135380011; Tue, 27 Feb 2024 05:18:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0512940008; Tue, 27 Feb 2024 05:18:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D578480011; Tue, 27 Feb 2024 05:18:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C2094940008 for ; Tue, 27 Feb 2024 05:18:53 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9532440B84 for ; Tue, 27 Feb 2024 10:18:53 +0000 (UTC) X-FDA: 81837185346.10.60D30B5 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf14.hostedemail.com (Postfix) with ESMTP id 74145100008 for ; Tue, 27 Feb 2024 10:18:51 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cpyVIP79; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=UuxALrSs; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cpyVIP79; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=UuxALrSs; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709029131; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q4pT87ICIgMrimfBYIsFt4403+jQ655os57F8M8rAV0=; b=r8r250Dxa0uZjln0GpcUktvwfu9irIdghHm/oH+lByE7kkypZf1F8IJ+leUPZjhItd4ZbL zerl/p8R0kR0dHoBvFJcmmSCfzDZu27f58UY9r9i123wtg9IFhpzZo2XuqHwLGDKMdE5fR BSzC0m64dL+3fZVE2duweCynw2564YM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cpyVIP79; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=UuxALrSs; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cpyVIP79; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=UuxALrSs; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709029131; a=rsa-sha256; cv=none; b=NOk1pXze/odOBUrdStWutYNZFpoCPm/1ek1SV8fco5emPUKaCrCpxtRPr7o/UIwYS0cjje BUnSBTXgnIw3HyBM4ZgdbYM4CAIjeRntSdsHmZwK0KeAp0HqwNZKQ0OxJpE1hp1AsY1DNw yShLOvLUbf375xuc6JdB73Srh16LwVc= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5DE931F44E; Tue, 27 Feb 2024 10:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709029129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q4pT87ICIgMrimfBYIsFt4403+jQ655os57F8M8rAV0=; b=cpyVIP79rj0/sBrJvpdZDSi/YWGaVzMxOeOUTFZkxXRW5dBBpVG2nrSet3ziaxNcNhCRul fsn2i6ZDMFIR8vZKMy1rHahvaELrlR9TdV1JOh9wud8P37gKHfMGsbCuw8Lz1zGjf4dOM9 gotsrvN12NpBYdL5ELH484nyYHkPZRY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709029129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q4pT87ICIgMrimfBYIsFt4403+jQ655os57F8M8rAV0=; b=UuxALrSs0P8mLarP5bjo/PfJ0N2IwYv6LH6qdRMTKIyww8fRC4dOnMwu5xagQtZCCFsHZf 6lKfIVVRnWShjTBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709029129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q4pT87ICIgMrimfBYIsFt4403+jQ655os57F8M8rAV0=; b=cpyVIP79rj0/sBrJvpdZDSi/YWGaVzMxOeOUTFZkxXRW5dBBpVG2nrSet3ziaxNcNhCRul fsn2i6ZDMFIR8vZKMy1rHahvaELrlR9TdV1JOh9wud8P37gKHfMGsbCuw8Lz1zGjf4dOM9 gotsrvN12NpBYdL5ELH484nyYHkPZRY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709029129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q4pT87ICIgMrimfBYIsFt4403+jQ655os57F8M8rAV0=; b=UuxALrSs0P8mLarP5bjo/PfJ0N2IwYv6LH6qdRMTKIyww8fRC4dOnMwu5xagQtZCCFsHZf 6lKfIVVRnWShjTBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B14DF13A65; Tue, 27 Feb 2024 10:18:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id UH3gKQi33WXqfQAAD6G6ig (envelope-from ); Tue, 27 Feb 2024 10:18:48 +0000 Message-ID: <4e648451-31a8-4293-bc14-e7ea01c889b1@suse.cz> Date: Tue, 27 Feb 2024 11:19:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 21/36] lib: add codetag reference into slabobj_ext Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-22-surenb@google.com> From: Vlastimil Babka In-Reply-To: <20240221194052.927623-22-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 74145100008 X-Stat-Signature: np6778miszefgxmt93ww7fpujjprqweg X-Rspam-User: X-HE-Tag: 1709029131-99667 X-HE-Meta: U2FsdGVkX19j47sj0HAVqGugkXw4UfJ31q1xoO2xObTKWfP5AnqmmULPip2AbZXzXK5iOce5LvUYZtwYceFwW5Xqk96TcOb4qc1JTrx/LP2sPqLWl2gGAYb0C7rRaL3hFDUwGWNy5lCTjchENIVtPB8F8XS6Ku2KlVUO+rMvHDTKbjGhZBpTB49ibXQ6tx28dQx/puJoK9b9EZ+1nXvgO3E48cigmBdEtSiw3fwE25wMtiXAsvS3GA8RFcHc02oPOuSDFwx4xSKw6fn4sksxiwGbsvwchrMfMZS27y3ijTzVusfDGsvsfkWiaBMgs2pDIAigWQCpQHhaRyfD1aEWI/MOb0Zbgni6BBRWSGMkNosGQwsv9X5Z1EoAagFKskmoPua7efKZSYXPsDzCUzwzk92XcovA6LgeIi5jys27HBgkTeg59Hi+s7fOOaVk0L9nABITWrJaB6kmR/gKa0rMsqdDZh1KPsmWQ/zg1AVzVxmoScotvAsb+T6wJZ4HOQi1neTldiOK0aMXUXEUtw89QPkLpcpcbPwBAuwv/1LyFfXKbx+q+ctX63Lcy7NNHSI13gpAYqVVDIq/HS2oSa8GLpFSPFVZ07bphKvwlL+c2SXV0cx95TScUUN57fWDjvrQD4twjGj+KeZTWvqmpoL9zGyJ8SEtt6dpBxQB4sFY+ES67sSUlz/VQX0gLS8/AiTKBzIh++2g5Wid2guiHjBk6Z40QKFlIqawEf4uAJAugj/l1fQ+ki5ZS6i8nSKnc/f9Z26qczLWsclankcXox+Ty02tN5a9Qd0Bp/AI2XN0NOT35mW4YbrWMIziYEVbRxnto5cPB8CNOgT6feVWchGzr+C2ZYXIj7JFPJePz3TbFPJNp8Brt8ixsuT4UTxGKMzkgAnW/qc2CD9qwUo66c5pRsbqWeSGKI7VbVwFu8F62AUXFG2yFSXDD/ZhhQMU9ssvM7BgS+gaYCUkFwTTTaE SGuIBirs RRU4jhFqFWwMKf9Mg7wUdTJnjRRH6Sc8WftwniR764DqrkzxodeI5kvmE6s6YfvqfCdx/Cby/NDEOu+SXjHupDR1k4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/21/24 20:40, Suren Baghdasaryan wrote: > To store code tag for every slab object, a codetag reference is embedded > into slabobj_ext when CONFIG_MEM_ALLOC_PROFILING=y. > > Signed-off-by: Suren Baghdasaryan > Co-developed-by: Kent Overstreet > Signed-off-by: Kent Overstreet Reviewed-by: Vlastimil Babka > --- > include/linux/memcontrol.h | 5 +++++ > lib/Kconfig.debug | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index f3584e98b640..2b010316016c 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1653,7 +1653,12 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, > * if MEMCG_DATA_OBJEXTS is set. > */ > struct slabobj_ext { > +#ifdef CONFIG_MEMCG_KMEM > struct obj_cgroup *objcg; > +#endif > +#ifdef CONFIG_MEM_ALLOC_PROFILING > + union codetag_ref ref; > +#endif > } __aligned(8); > > static inline void __inc_lruvec_kmem_state(void *p, enum node_stat_item idx) > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 7bbdb0ddb011..9ecfcdb54417 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -979,6 +979,7 @@ config MEM_ALLOC_PROFILING > depends on !DEBUG_FORCE_WEAK_PER_CPU > select CODE_TAGGING > select PAGE_EXTENSION > + select SLAB_OBJ_EXT > help > Track allocation source code and record total allocation size > initiated at that code location. The mechanism can be used to track