From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE14C27C75 for ; Thu, 13 Jun 2024 12:08:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 317746B0085; Thu, 13 Jun 2024 08:08:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C61F6B0098; Thu, 13 Jun 2024 08:08:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B5596B009A; Thu, 13 Jun 2024 08:08:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F3E336B0085 for ; Thu, 13 Jun 2024 08:08:38 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9020E40A28 for ; Thu, 13 Jun 2024 12:08:38 +0000 (UTC) X-FDA: 82225743516.20.55ED5CE Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf22.hostedemail.com (Postfix) with ESMTP id 11364C000D for ; Thu, 13 Jun 2024 12:08:34 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=bZPrxzej; spf=pass (imf22.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718280515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+ybivgLRs3V47AmWOiMtdHW+UOwYmEorpegVchSb5tE=; b=E1qw6Ys7o0nJNGO+Q297mohAdMKLXpJRkWUBIlRTTS5o4A0EMPpqQVuIbVjJDYL1zC3yAz kDYlaCLckarruyEJIM/vWtr6bK1y+FC6jYdDozRSDcUZV43aB1Mq6Uy2jtEXxcZGJvh7tD CEWp57RODVBPbY4IJmsnZT3zvQOUYXg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718280515; a=rsa-sha256; cv=none; b=klDWuC9oC0o2Wfnoddbykq4wLgruk3AfdjC3kDOWXwo61uE0WVUVwCWWLzrNlk9TiVVC6V pL+pAhKK5DPkUxHJBKh4rVEb+bzoEZNwIUiZj4ZncoYQnd7Atatl4tOMx07jOUvt/BtR5l KXFqNzh4jaiTzuMpwCYfWGWJLbIbdUA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=bZPrxzej; spf=pass (imf22.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1718280511; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=+ybivgLRs3V47AmWOiMtdHW+UOwYmEorpegVchSb5tE=; b=bZPrxzejA+HrSv47ojA222RcmyjKqim5k/VeQsxLMy7HaOavFqQgDSYqdHcGbmzM0rtQrRNDnbAcAZp563J3w4Che76ArLzx6FlUcHAQZvGY7T7PdzrsC+sg2zMOiAdiw2MKae5RA6PJA1EbjnpLeTbbVnK3kgS23+zzrTkUMwU= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R601e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033045046011;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0W8O.f6t_1718280510; Received: from 30.97.56.57(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W8O.f6t_1718280510) by smtp.aliyun-inc.com; Thu, 13 Jun 2024 20:08:30 +0800 Message-ID: <4e578713-c907-4bec-b2c2-f585772eae13@linux.alibaba.com> Date: Thu, 13 Jun 2024 20:08:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] KASAN: slab-use-after-free Read in finish_fault To: syzbot , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com References: <000000000000e21956061ac3eff0@google.com> From: Baolin Wang In-Reply-To: <000000000000e21956061ac3eff0@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 11364C000D X-Stat-Signature: t99krgi5mwsqwn74fmewd15yat15jo8g X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718280514-167855 X-HE-Meta: U2FsdGVkX1+ht6DJy/lJKKT6AL+DOKRTHOxPpg0d052cewVwJbyJvzcLx93+DnwQhTblsGDZr30tJ/e1pCzHcWkbyJ8+ffYQmZ6ONhWqyVp7K4r+Mdb3CY8r4kqejRRABwhcZmuCH0tkZ4hrvW6Z0/dQB/VVoMIx0pmgFRjqsn/PRvP0JJPxqoq7QtrwmHwnsIoEYc5jzx+G7ZlJD0t5UgS9QDXeoj92EiemGX0BI14m8AIvQp6QQF7+Jy/lnqEvbpxjbDzLQMt9S96DAgB9RnaOdMvx5zb5gq1elD8nQCkC8n48GGrqQOnlloDUnE24X/ksmO5RWE89+OrCazdY3W31k7diZYaj1U9gpGKvwO1Qs+O0xvjRi/zsvQ6Jiyt83clA4bER8peRBvjzpZN+L5bEXBTOv9eYjGSvdPvXxTd96xCNDZ6PA40kgv4OkcIt+xArGWJ0lkHZhTBvuvkj8DpW6+OEWqTFrhBvScuK/g2N5FGePE9E0NauU9JgAsDBjiO6a2Q4OQk+ks/GNC7gXVsRvmiK3xwSvxPDUWR29iB36oEWgxq2qsxvoowvuEdoD78tHDniKfAv8DT7AtkRV47L6hw3hz+ZzqebjnWE3ESabl0SD569Z/v1pQO/GzkUa8cfPHYeqYq/pRgKK6pr4Ts0WnYCykXpF35+XfmfaBF9fG4wAzJQ0dhjNvKdZJ6zwBxu2QFoWzP48e7s7yWoZWQRR3JoyfI6VsuzGhZTg8VSwDoz9JlMdb9qhb8duDZzQlxmAQpNLe6VS/sA8t3Eo/Ygt7Aoaa9h3jMAxzvOjNUCjneZMDBZ+QRnHXrBrj3wwBRHB4nWM4qlmYp2cdiwt9vl5e4fnBhzPxRMLzYEYjqY+aHsubSD42apcmuhq27X9Yvnnc1Tn3tMIPNoQIYZXXphRZmJQuZpIAfz6AafYW82v+K+b8NY+c2dNFYZqfShcBHp/kIQj1Ppc2j8XpQ LzmsShgn s/6MV/weC9aP2Pcc8XWbVjCWP4KAFzPZqmOrs4yx3CodW6rnNFCeQ9VieO7WjhMRTd1ZDqTjz2lB3wvONUhbzNlRL2DSyWnPzwGscv3l7I/XHBwoYSyzQ+rX3QADsiIvdrmFh0atGSh+G2kBz5TxKWmKloZbm9LnAIuUp0SK40JWtaXtUJbJ3f2sRjecvAb1ep5W/0kl0T2rImjNI+JiLpyCJF07BZAPddQ7odc+5MgHghowLj7ujN2y5qhUsgdtsqbWksFbN3u+qftcyqoH43yudWF0x5Q1GhPatI4xbgTnnUXGGkJ/0Mnh/xNc9w6g4XFAHvunGokhaWTdNOfJp0vvNCbg1wlPAY/EkKqEvPQbaBtdHWhcTDn3kTMRTlFg5mBh+hrN9pdhp3vO0GMM9ajCIew0PASwoExrg5Qee0PsGw+u8yPrp5HVPtgB8Of6lL1Qs3dgjO6kW/aq+QQu8I5KuqJdvEz2uehJ48NV8Ttzw4F15C57F2sWgy02YYrqci6sSCggaTls4D86O4eEjZfAlICGrAjyYp/IG4vJVAU7qnlRLeyA0qAF+wRmQUw40KWlfl6cZVX+VetZbePWPnpfsq19VYDQZBqutMb/eXDLLrUxriLk+b5mgDAqLMYGAzjGKBAjRJXGA7C0kQeJnSXFBwytk87bpXaf6wBlECnmeOHz2rzqvJwHMoM9why8vIz7yUmy5yAw+XLI0OmNJLWEhazYV3X2XahSyfXFvV1VfYga5tmvFgWRyjj/+mjFvvUHMPOTZfiXAm2sVfiq3iZlk/WfkQyPz8lq1G1L/gducaOdD/C2wkBykjUn9o7cTDVK0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/13 19:38, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: d35b2284e966 Add linux-next specific files for 20240607 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=178b77ba980000 > kernel config: https://syzkaller.appspot.com/x/.config?x=d8bf5cd6bcca7343 > dashboard link: https://syzkaller.appspot.com/bug?extid=d6e5c328862b5ae6cbfe > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=174c680a980000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=111b9696980000 > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/e0055a00a2cb/disk-d35b2284.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/192cbb8cf833/vmlinux-d35b2284.xz > kernel image: https://storage.googleapis.com/syzbot-assets/57804c9c9319/bzImage-d35b2284.xz > > The issue was bisected to: > > commit 1c05047ad01693ad92bdf8347fad3b5c2b25e8bb > Author: Baolin Wang > Date: Tue Jun 4 10:17:45 2024 +0000 > > mm: memory: extend finish_fault() to support large folio > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11267f94980000 > final oops: https://syzkaller.appspot.com/x/report.txt?x=13267f94980000 > console output: https://syzkaller.appspot.com/x/log.txt?x=15267f94980000 > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+d6e5c328862b5ae6cbfe@syzkaller.appspotmail.com > Fixes: 1c05047ad016 ("mm: memory: extend finish_fault() to support large folio") > > ================================================================== > BUG: KASAN: use-after-free in ptep_get include/linux/pgtable.h:317 [inline] > BUG: KASAN: use-after-free in ptep_get_lockless include/linux/pgtable.h:581 [inline] > BUG: KASAN: use-after-free in pte_range_none mm/memory.c:4409 [inline] > BUG: KASAN: use-after-free in finish_fault+0xf87/0x1460 mm/memory.c:4905 > Read of size 8 at addr ffff88807bfb7000 by task syz-executor149/5117 > > CPU: 0 PID: 5117 Comm: syz-executor149 Not tainted 6.10.0-rc2-next-20240607-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 > Call Trace: > > __dump_stack lib/dump_stack.c:91 [inline] > dump_stack_lvl+0x241/0x360 lib/dump_stack.c:117 > print_address_description mm/kasan/report.c:377 [inline] > print_report+0x169/0x550 mm/kasan/report.c:488 > kasan_report+0x143/0x180 mm/kasan/report.c:601 > ptep_get include/linux/pgtable.h:317 [inline] > ptep_get_lockless include/linux/pgtable.h:581 [inline] > pte_range_none mm/memory.c:4409 [inline] > finish_fault+0xf87/0x1460 mm/memory.c:4905 > do_read_fault mm/memory.c:5052 [inline] > do_fault mm/memory.c:5178 [inline] > do_pte_missing mm/memory.c:3948 [inline] > handle_pte_fault+0x3db5/0x7130 mm/memory.c:5502 > __handle_mm_fault mm/memory.c:5645 [inline] > handle_mm_fault+0x10df/0x1ba0 mm/memory.c:5810 > faultin_page mm/gup.c:1339 [inline] > __get_user_pages+0x6ef/0x1590 mm/gup.c:1638 > populate_vma_page_range+0x264/0x330 mm/gup.c:2078 > __mm_populate+0x27a/0x460 mm/gup.c:2181 > mm_populate include/linux/mm.h:3442 [inline] > __do_sys_remap_file_pages mm/mmap.c:3177 [inline] > __se_sys_remap_file_pages+0x7a1/0x9a0 mm/mmap.c:3103 > do_syscall_x64 arch/x86/entry/common.c:52 [inline] > do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 > entry_SYSCALL_64_after_hwframe+0x77/0x7f Thanks for reporting. I think the problem is I should also consider the pagetable of PMD size in case the pte entry overflows. I will fix this issue ASAP.